mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-10 05:39:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

iio: adc: ad4030: fix error pointer dereference in probe()

Browse Source 
The intention here was obviously to return an error if devm_regmap_init()
fails, but the return statement was accidentally left out.  This leads to
an error pointer dereference when we call:

	ret = ad4030_detect_chip_info(st);

Add the return statement.

Fixes: ec25cf6f1e ("iio: adc: ad4030: add support for ad4632-16 and ad4632-24")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/cc67cee7-9c65-46d2-aae3-f860fc3cc461@stanley.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Dan Carpenter
2025-02-28 12:35:40 +03:00
committed by Jonathan Cameron
parent 5017dcb8fc
commit 15a007e7ae
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/iio/adc/ad4030.c
View File

@@ -1011,8 +1011,8 @@ static int ad4030_probe(struct spi_device *spi)
st->regmap = devm_regmap_init(dev, &ad4030_regmap_bus, st,
&ad4030_regmap_config);
if (IS_ERR(st->regmap))
dev_err_probe(dev, PTR_ERR(st->regmap),
"Failed to initialize regmap\n");
return dev_err_probe(dev, PTR_ERR(st->regmap),
"Failed to initialize regmap\n");
st->chip = spi_get_device_match_data(spi);
if (!st->chip)