mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-02-03 08:01:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Staging: media: Replace dev_err with pr_err to avoid null pointer derefrence

Browse Source 
This patch replace dev_err with pr_err, for pointer is derefrenced after comparing it to NULL.
This was found using the following coccinelle script:

@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if(E == NULL) S
	f(...,E->fld,...);
-if(E == NULL) S;

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if(!E) S
	f(...,E->fld,...);
-if(!E) S;

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Haneen Mohammed
2015-03-06 20:01:07 +03:00
committed by Greg Kroah-Hartman
parent cd25503f5a
commit 14f63eeecf
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/media/lirc/lirc_zilog.c
View File

@@ -1341,8 +1341,7 @@ static int close(struct inode *node, struct file *filep)
struct IR *ir = filep->private_data;
if (ir == NULL) {
dev_err(ir->l.dev,
"close: no private_data attached to the file!\n");
pr_err("ir: close: no private_data attached to the file!\n");
return -ENODEV;
}