mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-08-23 22:27:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: ops: Log unknown controls in snd_soc_limit_volume()

Browse Source 
When we fail to look up the control name in snd_soc_limit_volume() we don't
log anything, the error code isn't particularly descriptive and checking
the return value of the function at all is a bit erratic among the callers.
Since there is no reason why anyone should ever be attempting to limit the
volume of a nonexistant control add a log message in the core to improve
usability.

Link: https://patch.msgid.link/20260422-asoc-limit-volume-error-v2-1-2e2ced321229@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Mark Brown
2026-04-22 21:34:05 +01:00
parent 0241d6192a
commit 0fa63c7ea9
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/soc-ops.c
View File

@@ -461,6 +461,10 @@ int snd_soc_limit_volume(struct snd_soc_card *card, const char *name, int max)
mc->platform_max = max;
ret = snd_soc_clip_to_platform_max(kctl);
}
} else {
/* Some cards blindly add limits for multiple variants. */
dev_dbg(card->dev, "Volume limit for unknown control '%s'\n",
name);
}
return ret;