mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-15 22:31:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

tools/power turbostat: Cleanup print helper functions

Browse Source 
Make printer helper functions more readable by factoring
out a local 'sep' variable.

Remove the redundant parentheses around sprintf() calls.

Remove an unnecessary cast to "unsigned int" by using the '%08llx' instead
   of '%08x'.

No functional changes.

[lenb: fix typos, simplify]
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Artem Bityutskiy
2026-03-11 11:00:35 +02:00
committed by Len Brown
parent 08e11edd0e
commit 092b76a325
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tools/power/x86/turbostat/turbostat.c
View File

@@ -2866,31 +2866,38 @@ void bic_lookup(cpu_set_t *ret_set, char *name_list, enum show_hide_mode mode)
static inline int print_name(int width, int *printed, char *delim, char *name, enum counter_type type, enum counter_format format)
{
UNUSED(type);
char *sep = (*printed)++ ? delim : "";
if (format == FORMAT_RAW && width >= 64)
return (sprintf(outp, "%s%-8s", ((*printed)++ ? delim : ""), name));
return sprintf(outp, "%s%-8s", sep, name);
else
return (sprintf(outp, "%s%s", ((*printed)++ ? delim : ""), name));
return sprintf(outp, "%s%s", sep, name);
}
static inline int print_hex_value(int width, int *printed, char *delim, unsigned long long value)
{
char *sep = (*printed)++ ? delim : "";
if (width <= 32)
return (sprintf(outp, "%s%08x", ((*printed)++ ? delim : ""), (unsigned int)value));
return sprintf(outp, "%s%08llx", sep, value);
else
return (sprintf(outp, "%s%016llx", ((*printed)++ ? delim : ""), value));
return sprintf(outp, "%s%016llx", sep, value);
}
static inline int print_decimal_value(int width, int *printed, char *delim, unsigned long long value)
{
char *sep = (*printed)++ ? delim : "";
UNUSED(width);
return (sprintf(outp, "%s%lld", ((*printed)++ ? delim : ""), value));
return sprintf(outp, "%s%lld", sep, value);
}
static inline int print_float_value(int *printed, char *delim, double value)
{
return (sprintf(outp, "%s%0.2f", ((*printed)++ ? delim : ""), value));
char *sep = (*printed)++ ? delim : "";
return sprintf(outp, "%s%0.2f", sep, value);
}
void print_header(char *delim)