mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-07-22 03:27:30 -04:00
gpio: remove obsolete UAF FIXMEs from lookup paths
The ACPI and swnode GPIO lookup backends both temporarily grab a reference to the gpio_device, resolve the descriptor, and then drop the reference before returning the descriptor to the caller. They carry FIXME comments warning that the descriptor is being returned without its backing device reference. However, the gpiod_find_and_request() core functionally prevents any use-after-free window by wrapping the entire lookup operation inside the gpio_devices_srcu read lock. The lookup functions are correct to drop their references since the caller (gpiod_request) will subsequently take its own permanent module and device references safely. Remove these obsolete FIXMEs to prevent misleading future subsystem developers. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Marco Scardovi <scardracs@disroot.org> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patch.msgid.link/20260524162708.62949-3-scardracs@disroot.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
This commit is contained in:
committed by
Bartosz Golaszewski
parent
aa7e8b7ef0
commit
07c44ee9fd
@@ -142,10 +142,6 @@ static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)
|
||||
if (!gdev)
|
||||
return ERR_PTR(-EPROBE_DEFER);
|
||||
|
||||
/*
|
||||
* FIXME: keep track of the reference to the GPIO device somehow
|
||||
* instead of putting it here.
|
||||
*/
|
||||
return gpio_device_get_desc(gdev, pin);
|
||||
}
|
||||
|
||||
|
||||
@@ -114,10 +114,6 @@ struct gpio_desc *swnode_find_gpio(struct fwnode_handle *fwnode,
|
||||
if (IS_ERR(gdev))
|
||||
return ERR_CAST(gdev);
|
||||
|
||||
/*
|
||||
* FIXME: The GPIO device reference is put at return but the descriptor
|
||||
* is passed on. Find a proper solution.
|
||||
*/
|
||||
desc = gpio_device_get_desc(gdev, args.args[0]);
|
||||
*flags = args.args[1]; /* We expect native GPIO flags */
|
||||
|
||||
|
||||
Reference in New Issue
Block a user