mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-02 10:59:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

net/mlx5: HWS, reduce memory consumption of a matcher struct

Browse Source 
Instead of having a large array of action templates allocated with
kmalloc, have smaller array and allocate it with kvmalloc.

The size of the array represents the max number of AT attach
operations for the same matcher. This number is not expected
to be very high. In any case, when the limit is reached, the
next attempt to attach new AT will result in creation of a new
matcher and moving all the rules to this matcher.

Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250102181415.1477316-9-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Yevgeny Kliteynik
2025-01-02 20:14:07 +02:00
committed by Jakub Kicinski
parent ad4da6cc36
commit 05e3c287b9
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.h
View File

@@ -8,7 +8,13 @@
#define MLX5HWS_BWC_MATCHER_SIZE_LOG_STEP 1
#define MLX5HWS_BWC_MATCHER_REHASH_PERCENT_TH 70
#define MLX5HWS_BWC_MATCHER_REHASH_BURST_TH 32
#define MLX5HWS_BWC_MATCHER_ATTACH_AT_NUM 255
/* Max number of AT attach operations for the same matcher.
* When the limit is reached, next attempt to attach new AT
* will result in creation of a new matcher and moving all
* the rules to this matcher.
*/
#define MLX5HWS_BWC_MATCHER_ATTACH_AT_NUM 8
#define MLX5HWS_BWC_MAX_ACTS 16

8
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/matcher.c
View File

@@ -999,9 +999,9 @@ hws_matcher_set_templates(struct mlx5hws_matcher *matcher,
if (!matcher->mt)
return -ENOMEM;
matcher->at = kcalloc(num_of_at + matcher->attr.max_num_of_at_attach,
sizeof(*matcher->at),
GFP_KERNEL);
matcher->at = kvcalloc(num_of_at + matcher->attr.max_num_of_at_attach,
sizeof(*matcher->at),
GFP_KERNEL);
if (!matcher->at) {
mlx5hws_err(ctx, "Failed to allocate action template array\n");
ret = -ENOMEM;
@@ -1027,7 +1027,7 @@ hws_matcher_set_templates(struct mlx5hws_matcher *matcher,
static void
hws_matcher_unset_templates(struct mlx5hws_matcher *matcher)
{
kfree(matcher->at);
kvfree(matcher->at);
kfree(matcher->mt);
}