mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-31 15:22:21 -04:00
liveupdate: reject nonzero reserved value for SESSION_FINISH
The UAPI documents liveupdate_session_finish::reserved as requiring zero,
but luo_session_finish() currently ignores it and finishes the session.
Accepting nonzero values prevents the field from being safely repurposed
by a future extension.
Reject nonzero reserved values before changing session state, matching
LIVEUPDATE_SESSION_GET_NAME.
Fixes: 16cec0d265 ("liveupdate: luo_session: add ioctls for file preservation")
Assisted-by: Codex:gpt-5.6-sol
Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
Link: https://patch.msgid.link/20260716012607.22020-2-liu.yun@linux.dev
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
This commit is contained in:
committed by
Mike Rapoport (Microsoft)
parent
797fe91e50
commit
05cf3d87a0
@@ -316,8 +316,12 @@ static int luo_session_finish(struct luo_session *session,
|
||||
struct luo_ucmd *ucmd)
|
||||
{
|
||||
struct liveupdate_session_finish *argp = ucmd->cmd;
|
||||
int err = luo_session_finish_one(session);
|
||||
int err;
|
||||
|
||||
if (argp->reserved)
|
||||
return -EINVAL;
|
||||
|
||||
err = luo_session_finish_one(session);
|
||||
if (err)
|
||||
return err;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user