pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output()

The regmap_update_bits() function can fail, so propagate its error
up to the stack instead of silently ignoring that.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-3-07e9ac1ab737@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Gabor Juhos
2025-05-14 21:18:34 +02:00
committed by Linus Walleij
parent e6ebd49429
commit 0396a8731e

View File

@@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip,
reg = OUTPUT_EN;
armada_37xx_update_reg(&reg, &en_offset);
regmap_update_bits(info->regmap, reg, mask, mask);
return 0;
return regmap_update_bits(info->regmap, reg, mask, mask);
}
static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)