mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 06:41:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

btrfs: make add_pending_csums() to take an ordered extent as parameter

Browse Source 
The structure btrfs_ordered_extent has a lot of list heads for different
purposes, passing a random list_head pointer is never a good idea as if
the wrong list is passed in, the type casting along with the fs will be
screwed up.

Instead pass the btrfs_ordered_extent pointer, and grab the csum_list
inside add_pending_csums() to make it a little safer.

Since we're here, also update the comments to follow the current style.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo
2026-02-10 13:54:30 +10:30
committed by David Sterba
parent 09664971b3
commit 00c865b60b
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/inode.c
View File

@@ -2746,17 +2746,19 @@ void btrfs_clear_delalloc_extent(struct btrfs_inode *inode,
}
/*
* given a list of ordered sums record them in the inode. This happens
* at IO completion time based on sums calculated at bio submission time.
* Given an ordered extent and insert all its checksums into the csum tree.
*
* This happens at IO completion time based on sums calculated at bio
* submission time.
*/
static int add_pending_csums(struct btrfs_trans_handle *trans,
struct list_head *list)
struct btrfs_ordered_extent *oe)
{
struct btrfs_ordered_sum *sum;
struct btrfs_root *csum_root = NULL;
int ret;
list_for_each_entry(sum, list, list) {
list_for_each_entry(sum, &oe->csum_list, list) {
if (!csum_root) {
csum_root = btrfs_csum_root(trans->fs_info,
sum->logical);
@@ -3322,7 +3324,7 @@ int btrfs_finish_one_ordered(struct btrfs_ordered_extent *ordered_extent)
goto out;
}
ret = add_pending_csums(trans, &ordered_extent->csum_list);
ret = add_pending_csums(trans, ordered_extent);
if (unlikely(ret)) {
btrfs_abort_transaction(trans, ret);
goto out;