mirrors/compiler-explorer
1
0
Fork 0
mirror of https://github.com/compiler-explorer/compiler-explorer.git synced 2025-12-27 10:33:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
a9d2910c52ca44d5b8f19f802444190140a5baa5
compiler-explorer/CONTRIBUTORS.md
Sean Garwood a9d2910c52 Warn when assembly output is in AT&T syntax (#4311) (#8272) 
Assembly documentation tooltips always display Intel syntax information,
but when the actual assembly output is in AT&T syntax, this can be
confusing due to the reversed operand order (AT&T uses source, dest
while Intel uses dest, source).

This change adds a warning to the tooltip when the assembly output is
NOT in Intel syntax, informing users that the documentation pertains to
Intel syntax.

The warning appears when:
- The user has not enabled the Intel syntax filter (filters.intel is
false)
- The assembly output is therefore in AT&T syntax

The detection uses filters.isSet('intel') rather than compiler.intelAsm,
ensuring we check the actual output syntax (what the user selected)
rather than just whether the compiler supports Intel syntax.

Fixes #4311

refactor: move assembly-syntax type to frontend, remove from device-view

Move types/assembly-syntax.ts to static/assembly-syntax.ts since it's
only used by frontend code (compiler.ts and device-view.ts), not
backend.

Per CONTRIBUTING.md, types/ directory is for shared types used by both
frontend (static/) and backend (lib/). Since AssemblySyntax is
frontend-only, it belongs in static/.

Also removed syntax tracking from device-view entirely:
- Device assembly (CUDA PTX, GPU, etc.) doesn't have Intel/AT&T variants
- device-view was storing syntax as immutable state that never updated
- This would cause incorrect tooltips if user toggled syntax after
opening
- Reverted device-view to match main branch (no syntax support)

Changes:
- Moved types/assembly-syntax.ts -> static/assembly-syntax.ts
- Updated import paths in compiler.ts
- Removed syntax field and imports from device-view.ts/.interfaces.ts

This means no unit tests are required per CONTRIBUTING.md guidelines
(tests only required for server-side components in lib/).

<!-- THIS COMMENT IS INVISIBLE IN THE FINAL PR, BUT FEEL FREE TO REMOVE
IT
Thanks for taking the time to improve CE. We really appreciate it.
Before opening the PR, please make sure that the tests & linter pass
their checks,
  by running `make check`.
In the best case scenario, you are also adding tests to back up your
changes,
  but don't sweat it if you don't. We can discuss them at a later date.
Feel free to append your name to the CONTRIBUTORS.md file
Thanks again, we really appreciate this!
-->
2025-12-22 19:23:59 -06:00

175 lines
8.1 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

From oldest to newest contributor, we would like to thank:
- [Alin Rus](https://github.com/suchmoleculeswow)
- [android](https://github.com/trevd)
- [Ali Utku Selen](https://github.com/auselen)
- [sudheesh001](https://github.com/sudheesh001)
- [Malcolm Rowe](https://github.com/malcolmr)
- [UplinkCoder](https://github.com/UplinkCoder)
- [Anders Waldenborg](https://github.com/wanders)
- [Peter Bourgon](https://github.com/peterbourgon)
- [Tõnis Tiigi](https://github.com/tonistiigi)
- [Lorenz Hübschle-Schneider](https://github.com/lorenzhs)
- [Ola Jeppsson](https://github.com/olajep)
- [Nicolas Brunie](https://github.com/nibrunie)
- [Iain Buclaw](https://github.com/ibuclaw)
- [Vinzent Steinberg](https://github.com/vks)
- [Emil Laine](https://github.com/emlai)
- [Adam Nemecek](https://github.com/adamnemecek)
- [Arvid Gerstmann](https://github.com/Leandros)
- [Tal Ben-Nun](https://github.com/tbennun)
- [Amila Welihinda](https://github.com/amilajack)
- [Jason Turner](https://github.com/lefticus)
- [Adrian Bibby Walther](https://github.com/Som1Lse)
- [Johan Engelen](https://github.com/JohanEngelen)
- [Sahnvour](https://github.com/Sahnvour)
- [Brian Cain](https://github.com/androm3da)
- [Alexander Monakov](https://github.com/amonakov)
- [David Nadlinger](https://github.com/klickverbot)
- [Marc Poulhiès](https://github.com/dkm)
- [Carlos van Rooijen](https://github.com/CvRXX)
- [Kaartic Sivaraam](https://github.com/sivaraam)
- [Lilian A. Moraru](https://github.com/lilianmoraru)
- [Tim Rakowski](https://github.com/racko)
- [Hana Dusíková](https://github.com/hanickadot)
- [Ilya Yaroshenko](https://github.com/9il)
- [Honggyu Kim](https://github.com/honggyukim)
- [richardthe3rd](https://github.com/richardthe3rd)
- [Sam Kellett](https://github.com/samkellett)
- [Jean-Michaël Celerier](https://github.com/jcelerier)
- [Mike Cochrane](https://github.com/mikenz)
- [gnaggnoyil](https://github.com/gnaggnoyil)
- [Bernardo Sulzbach](https://github.com/bernardosulzbach)
- [Nils Deppe](https://github.com/nilsdeppe)
- [Mustafa Serdar Sanli](https://github.com/mserdarsanli)
- [Ethiraric](https://github.com/Ethiraric)
- [Windel Bouwman](https://github.com/windelbouwman)
- [Daniel Rosenwasser](https://github.com/DanielRosenwasser)
- [Karlis Senko](https://github.com/karliss)
- [Ray Hamel](https://github.com/rayhamel)
- [Sylvain Corlay](https://github.com/SylvainCorlay)
- [Andrew Gresyk](https://github.com/andrew-gresyk)
- [Corentin Jabot](https://github.com/cor3ntin)
- [Ethan Smith](https://github.com/ethanhs)
- [Shubham Rawat](https://github.com/shubhdev)
- [AMS21](https://github.com/AMS21)
- [Darcy Beurle](https://github.com/dbeurle)
- [Michael Bradshaw](https://github.com/mjbshaw)
- [Matthew Webb](https://github.com/Noviv)
- [phuclv90](https://github.com/phuclv90)
- [Nicole Mazzuca](https://github.com/ubsan)
- [Jameson Nash](https://github.com/vtjnash)
- [Raul Tambre](https://github.com/tambry)
- [Dominic Kempf](https://github.com/dokempf)
- [Marc Tiehuis](https://github.com/tiehuis)
- [Petter Wahlman](https://github.com/ilAYAli)
- [Miguel Ojeda](https://github.com/ojeda)
- [Niek J. Bouman](https://github.com/niekbouman)
- [Erik Little](https://github.com/nuclearace)
- [Jülich Supercomputing Centre](https://github.com/FZJ-JSC)
- [Niall Douglas](https://github.com/ned14)
- [Daniel Black](https://github.com/grooverdan)
- [Gennadiy Civil](https://github.com/gennadiycivil)
- [Paul Scharnofske](https://github.com/asynts)
- [Sebastian Staffa](https://github.com/Staff-d)
- [Luka Prebil Grintal](https://github.com/LukaPrebil)
- [Andreas Jonson](https://github.com/andjo403)
- [Sam Clegg](https://github.com/sbc100)
- [Austin Morton](https://github.com/apmorton)
- [Matt Hammerly](https://github.com/mhammerly)
- [Christian Vonrüti](https://github.com/alshain)
- [Alessandro Vergani](https://github.com/Loghorn)
- [Sebastian Rath](https://github.com/seb-mtl)
- [Haze Booth](https://github.com/haze)
- [Cassie Jones](https://github.com/porglezomp)
- [Bastien Penavayre](https://github.com/DaemonSnake)
- [Dave Rodgman](https://github.com/daverodgman)
- [Will Lovett](https://github.com/willlovett-arm)
- [Mark Gillard](https://github.com/marzer)
- [Ethan Slattery](https://github.com/CrustyAuklet)
- [Kale Blankenship](https://github.com/vcabbage)
- [George Gribkov](https://github.com/GeorgeGribkov)
- [Artem Akatev](https://github.com/aakatev)
- [Danil Yarantsev](https://github.com/Yardanico)
- [Krists Niedritis](https://github.com/JesusKrists)
- [Julian Hammer](https://github.com/cod3monk)
- [Peter Schussheim](https://github.com/peterschussheim)
- [Robert Cohn](https://github.com/rscohn2)
- [Serzhan Nasredin](https://github.com/snxx-lppxx)
- [Jeremy Overesch](https://github.com/jovere)
- [Arseniy Zaostrovnykh](https://github.com/necto)
- [Julien Marrec](https://github.com/jmarrec)
- [Dan Okken](https://github.com/okkenator)
- [Shivam Gupta](https://github.com/xgupta)
- [Tamir Bahar](https://github.com/tmr232)
- [Jason Meisel](https://github.com/jasonmeisel)
- [Nabeel Omer](https://github.com/nabeelomer)
- [Daniel Below](https://github.com/DanielBelow)
- [Oleksandr Muliar](https://github.com/msdinit)
- [Quinton Miller](https://github.com/HertzDevil)
- [Kevin Adler](https://github.com/kadler)
- [Björn Gustavsson](https://github.com/bjorng)
- [Steven He](https://github.com/hez2010)
- [Gregory Anders](https://github.com/gpanders)
- [Marcus Geelnard](https://github.com/mbitsnbites)
- [Haneef Mubarak](https://github.com/haneefmubarak)
- [Jeremy Rifkin](https://github.com/jeremy-rifkin)
- [Ankur Saini](https://github.com/Arsenic-ATG)
- [m8mble](https://github.com/m8mble)
- [Anders-T](https://github.com/anders-torbjornsen)
- [Adam Sandberg Eriksson](https://github.com/adamse)
- [Ross Smyth](https://github.com/RossSmyth)
- [Mike Urbach](https://github.com/mikeurbach)
- [J. Ryan Stinnett](https://github.com/jryans)
- [Fábio S. V. Medeiros](https://github.com/fabiosvm)
- [Jackson Machado](https://github.com/jacksjm)
- [Cordell Bloor](https://github.com/cgmb)
- [Sebastian Büttner](https://github.com/bueddl)
- [Madhur Chauhan](https://github.com/madhur4127)
- [VoltrexKeyva](https://github.com/VoltrexKeyva)
- [Johel Ernesto Guerrero Peña](https://github.com/JohelEGP)
- [Ali](https://github.com/aliaegik)
- [Vlad Serebrennikov](https://github.com/endilll)
- [Mauro Baladés](https://github.com/mauro-balades)
- [Jorge López](https://github.com/jolopezl)
- [Spydr06](https://github.com/spydr06)
- [Simon Sobisch](https://github.com/GitMensch)
- [Marc Auberer](https://github.com/marcauberer)
- [Seyed Ali Ghasemi](https://github.com/gha3mi)
- [Guo Ci](https://github.com/guoci)
- [Rupert Tombs](https://github.com/Rupt)
- [Andrew Brey](https://github.com/andrewbrey)
- [Weile Wei](https://github.com/weilewei)
- [Anirudh Sundar Subramaniam](https://github.com/quic-sanirudh)
- [Julian van Doorn](https://github.com/JulianvDoorn)
- [Andrea Tomasi](https://github.com/treere)
- [Khyber Sen](https://github.com/kkysen)
- [Matthew Guidry](https://github.com/mguid65)
- [Adam Thibert](https://github.com/adamaq01)
- [Nazım Can Altınova](https://github.com/canova)
- [Nicholas Hubbard](https://github.com/nhubbard)
- [Detjon Mataj](https://github.com/detjonmataj)
- [Pierre Bayerl](https://github.com/goto40)
- [James Touton](https://github.com/Bekenn)
- [Waqar Ahmed](https://github.com/waqar144)
- [Vipul Cariappa](https://github.com/Vipul-Cariappa)
- [Niles Salter](https://github.com/Validark)
- [Stephen Heumann](https://github.com/sheumann)
- [Joshua Batty](https://github.com/joshuabatty)
- [Dana Jansens](https://github.com/danakj)
- [Mathias Gredal](https://github.com/mathiasgredal)
- [RongDong Xu](https://github.com/arong)
- [Adrien Bertrand](https://github.com/adriweb)
- [Roberto Parolin](https://github.com/rparolin)
- [Alfredo Correa](https://github.com/correaa)
- [Oscar Amoros Huguet](https://github.com/morousg)
- [Florian Freitag](https://github.com/flofriday)
- [Trevor Gross](https://github.com/tgross35)
- [Alex Trotta](https://github.com/Ahajha)
- [natinusala](https://github.com/natinusala)
- [LJ](https://github.com/elle-j)
- [Frank Leon Rose](https://github.com/frankleonrose)
- [Oguz Ulgen](https://github.com/oulgen)
- [Josh Brice](https://github.com/jjb0123)
- [Sean Garwood](https://github.com/sean-garwood)
Reference in New Issue View Git Blame Copy Permalink