mirror of
https://github.com/compiler-explorer/compiler-explorer.git
synced 2025-12-27 09:23:52 -05:00
## Summary This PR improves the pre-commit hook performance by: - Using `vitest related` to run only tests affected by changed files - Adding ability to skip expensive tests (filter tests) during pre-commit - Providing a consistent mechanism for skipping expensive tests ## Changes - Modified `lint-staged.config.mjs` to run `vitest related` with `SKIP_EXPENSIVE_TESTS=true` - Updated `test/filter-tests.ts` to use idiomatic `describe.skipIf()` for conditional test execution - Changed `test-min` script to use `SKIP_EXPENSIVE_TESTS` environment variable instead of `--exclude` - Updated `CLAUDE.md` with documentation about the new test workflow ## Impact - Pre-commit hooks are now much faster as they: - Only run tests related to changed files - Skip 688 expensive filter tests - Use the same skipping mechanism as `npm run test-min` ## Testing - ✅ Verified `vitest related` correctly identifies and runs related tests - ✅ Confirmed filter tests are skipped when `SKIP_EXPENSIVE_TESTS=true` - ✅ Tested that full test suite still runs all tests when env var is not set - ✅ Pre-commit hooks work correctly with the new setup 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude <noreply@anthropic.com>
5.5 KiB
5.5 KiB
CLAUDE.md
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
Build & Test Commands
- Build:
npm run webpack,npm start - Dev Mode:
make dev,make gpu-dev - Lint:
npm run lint(auto-fix),npm run lint-check(check only) - Type Check:
npm run ts-check - Test:
npm run test(all),npm run test-min(minimal) - Test Single File:
npm run test -- --run base-compiler-tests.ts - Test Specific Pattern:
npm run test -- -t "should handle execution failures" - Cypress Tests:
npm run cypress - Pre-commit Check:
make pre-commitornpm run check
Important Workflow Requirements
- ⚠️ NEVER BYPASS PRE-COMMIT HOOKS! NEVER use
git commit -nor--no-verify⚠️ - ALWAYS run
make pre-commitor at minimumnpm run ts-checkandnpm run lintbefore committing - The full process must always be:
- Make changes
- Run
npm run ts-checkto verify TypeScript types - Run
npm run lintto fix style issues (will auto-fix many problems) - Run
npm run testto verify functionality (or at leastnpm run test-min) - ONLY THEN commit changes with plain
git commit(NO FLAGS!)
- Bypassing these checks will lead to broken builds, failed tests, and PRs that cannot be merged
- ALWAYS use HEREDOC syntax for complex shell commands, especially those containing quotes, newlines, or special characters:
gh pr create --title "Title" --body "$(cat <<'EOF' PR body content with "quotes" and special chars like $variables that would otherwise need escaping EOF )"
Style Guidelines
- TypeScript: Strict typing, no implicit any, no unused locals
- Formatting: 4-space indentation, 120 char line width, single quotes
- No semicolon omission, prefer const/let over var
- Client-side: TypeScript transpiled to ES5 JavaScript. This process requires import of
blah.jseven thoughblah.tsis the actual filename - ALWAYS place imports at the top of files, never inside functions or methods, unless absolutely necessary (and confirm before proposing)
- Use Underscore.js for utility functions
- Write tests for new server-side components
- Where appropriate suggest follow-up improvements to code to improve code quality, and DRY up where feasible
- Documentation is in
docs/directory; update where necessary, in particular if anything about the RESTful API changes - Don't add comments above code that's clearly self-documenting. For example, don't put comments like this:
// Initialises the thing initialiseThing(); - Avoid redundant function header comments that merely repeat the function name. For example:
In this case, the function name already clearly states what it does.
/** * Sets up compiler change handling */ function setupCompilerChangeHandling() {...} - Comments should provide additional context or explain "why" something is done, not just restate "what" is being done.
- Only add function header comments when they provide meaningful information beyond what the function name and signature convey.
- Use British English spellings for things like "initialise" and "colour", but only in new code. It's a preference not a hard requirement
- Use modern Typescript features like optional chaining when updating existing code or adding new code
Architecture Guidelines
- Frontend/Backend Separation: Frontend code (
static/) MUST NOT import from backend code (lib/)- Frontend should use API calls to communicate with backend
- Shared types should be imported from
types/directory instead - This separation is enforced by pre-commit hooks (
npm run check-frontend-imports) - Violations will cause build failures and prevent commits
Testing Guidelines
- Use Vitest for unit tests (compatible with Jest syntax)
- Tests are in the
/testdirectory, typically named like the source files they test - Use spy functions with
vi.spyOn()for mocking dependencies - Test structure follows describe/it pattern with descriptive test names
- Separate tests with clear section headers using comments for readability
- Consider cross-platform compatibility (especially Windows path handling)
- For complex files, organize tests by functionality rather than by method
- Use
beforeEach/afterEachto set up and clean up test environment - Remember to restore mocks with
vi.restoreAllMocks()after tests - Test both success and error cases
- Coverage is available with
npm test:coverage - For Windows-specific path issues, either:
- Skip tests with
if (process.platform === 'win32') return; - Write platform-specific assertions
- Use path-agnostic checks
- Skip tests with
Test Execution with Expensive Test Skipping
- The
SKIP_EXPENSIVE_TESTS=trueenvironment variable skips expensive tests (like filter tests) - Pre-commit hooks use
vitest relatedto run only tests related to changed files - Use
npm run test-minto run tests with expensive tests skipped - Use
npm run testto run all tests including expensive ones - To mark tests as expensive, use:
describe.skipIf(process.env.SKIP_EXPENSIVE_TESTS === 'true')('Test suite', () => {...})
Compiler Testing Specifics
- Mock filesystem operations when testing file I/O
- Use
makeFakeCompilerInfo()for creating test compiler configurations - Use
makeCompilationEnvironment()to create test environments - Mock
execcalls for testing compilation and execution - For BaseCompiler, use the test utils from
/test/utils.js - Test specific combinations of compiler capabilities
- Focus tests on behavior, not implementation details
- Use platform-agnostic assertions where possible