Bump used node version to 18 (#4778)

Still assume node 16 compatibility for now.
This commit is contained in:
Matt Godbolt
2023-02-25 12:43:00 -06:00
committed by GitHub
parent 6cbb6a0eb8
commit fb4b7bb16e
6 changed files with 15 additions and 15 deletions

View File

@@ -20,10 +20,10 @@ jobs:
with:
fetch-depth: 0
ref: ${{ github.event.inputs.buildnumber }}
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Build distribution
id: build_dist
@@ -41,10 +41,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Download the built distribution
uses: actions/download-artifact@v3

View File

@@ -10,10 +10,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Install prerequisites
run: make prereqs
@@ -37,10 +37,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Build distribution
id: build_dist
@@ -59,10 +59,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Download the built distribution
uses: actions/download-artifact@v3

View File

@@ -14,10 +14,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: npm
- name: Install prerequisites
run: make prereqs

View File

@@ -20,7 +20,7 @@ in the right direction.
## Node version
**Compiler Explorer** currently targets [Node.js](https://nodejs.org/) LTS version 16 so it's better if you do so as
**Compiler Explorer** currently targets [Node.js](https://nodejs.org/) LTS version 18 so it's better if you do so as
well when testing your changes locally.
## In brief

View File

@@ -58,7 +58,7 @@ running with an Explorer running on port 10240 on your local machine:
[http://localhost:10240/](http://localhost:10240/). If this doesn't work for you, please contact us, as we consider it
important you can quickly and easily get running. Currently, **Compiler Explorer** requires
[`node` 16 _(LTS version)_](CONTRIBUTING.md#node-version) installed, either on the path or at `NODE_DIR` (an environment
variable or `make` parameter).
variable or `make` parameter), and will soon be moving to v18.
Running with `make EXTRA_ARGS='--language LANG'` will allow you to load `LANG` exclusively, where `LANG` is one for the
language ids/aliases defined in `lib/languages.ts`. For example, to only run **Compiler Explorer** with C++ support,

View File

@@ -25,7 +25,7 @@ find_node() {
NODE="$(find_node)"
NODE_MIN_VERSION=16
NODE_VERSION_USED=16
NODE_VERSION_USED=18
NODE_VERSION=$(${NODE} --version)
NODE_MAJOR_VERSION=$(echo "${NODE_VERSION}" | cut -f1 -d. | sed 's/^v//g')