mirrors/compiler-explorer
2
0
Fork 0
mirror of https://github.com/compiler-explorer/compiler-explorer.git synced 2026-07-22 01:46:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Address review: error handler on entry streams, no mkdir for skipped entries

Browse Source 
Attach an error handler to every entry stream so an error while
draining a skipped entry rejects the extraction rather than throwing an
unhandled 'error' event, and only create parent directories for entries
we actually write.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
mattgodbolt-molty
2026-06-11 15:37:17 -05:00
parent 3e1eab0a06
commit 81f0a0744d
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/buildenvsetup/ceconan.ts
View File

@@ -148,6 +148,9 @@ export class BuildEnvSetupCeConanDirect extends BuildEnvSetupBase {
const gunzip = zlib.createGunzip();
extract.on('entry', async (header, stream, next) => {
// Drained streams (skipped entries) have no other error listener; without this an
// entry-stream error would throw as an unhandled 'error' event.
stream.on('error', (error: any) => extract.destroy(error));
try {
const filepath = this.getDestinationFilepath(downloadPath, header.name, libId);
@@ -164,17 +167,20 @@ export class BuildEnvSetupCeConanDirect extends BuildEnvSetupBase {
return;
}
if (!this.extractAllToRoot) {
await fs.promises.mkdir(path.dirname(filepath), {recursive: true});
}
if (header.type !== 'file') {
// Only regular files are ever written; symlinks, hardlinks, directories etc
// are drained and skipped. Draining also avoids a hang on malformed entries
// (e.g. a directory with a non-zero size, whose stream tar-stream never ends).
stream.resume();
next();
} else if (header.size === 0) {
return;
}
if (!this.extractAllToRoot) {
await fs.promises.mkdir(path.dirname(filepath), {recursive: true});
}
if (header.size === 0) {
// tar-stream emits no data for zero-length entries (see
// https://github.com/mafintosh/tar-stream/issues/145): create empty files
// explicitly.