mirrors/compiler-explorer
1
0
Fork 0
mirror of https://github.com/compiler-explorer/compiler-explorer.git synced 2025-12-27 09:23:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix an element on('dragstart') applies to (#6226)

Browse Source 
And change 'toggle' to 'hide' to better express the intention.
Fixes #6225.


<!-- THIS COMMENT IS INVISIBLE IN THE FINAL PR, BUT FEEL FREE TO REMOVE
IT
Thanks for taking the time to improve CE. We really appreciate it.
Before opening the PR, please make sure that the tests & linter pass
their checks,
  by running `make check`.
In the best case scenario, you are also adding tests to back up your
changes,
  but don't sweat it if you don't. We can discuss them at a later date.
Feel free to append your name to the CONTRIBUTORS.md file
Thanks again, we really appreciate this!
-->
This commit is contained in:
Ofek
2024-03-07 20:21:10 +02:00
committed by GitHub
parent 10c6074073
commit 45b743e22b
1 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
static/panes/compiler.ts
View File

@@ -680,8 +680,8 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
};
const newPaneDropdown = this.domRoot.find('.new-pane-dropdown');
const togglePannerAdder = () => {
newPaneDropdown.dropdown('toggle');
const hidePaneAdder = () => {
newPaneDropdown.dropdown('hide');
};
// Note that the .d.ts file lies in more than 1 way!
@@ -691,7 +691,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.domRoot.find('.btn.add-compiler'), cloneComponent as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.domRoot.find('.btn.add-compiler').on('click', () => {
const insertPoint =
@@ -704,7 +704,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.optButton, createOptView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.optButton.on('click', () => {
const insertPoint =
@@ -717,7 +717,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.stackUsageButton, createStackUsageView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.stackUsageButton.on('click', () => {
const insertPoint =
@@ -726,13 +726,13 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
insertPoint.addChild(createStackUsageView());
});
const popularArgumentsMenu = this.domRoot.find('div.populararguments div.dropdown-menu');
if (this.flagsButton) {
const popularArgumentsMenu = this.domRoot.find('div.populararguments div.dropdown-menu');
this.container.layoutManager
.createDragSource(this.flagsButton, createFlagsView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', () => popularArgumentsMenu.dropdown('hide'));
this.flagsButton.on('click', () => {
const insertPoint =
@@ -748,7 +748,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.ppButton, createPpView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.ppButton.on('click', () => {
const insertPoint =
@@ -761,7 +761,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.astButton, createAstView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.astButton.on('click', () => {
const insertPoint =
@@ -774,7 +774,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.irButton, createIrView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.irButton.on('click', () => {
const insertPoint =
@@ -787,7 +787,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.optPipelineButton, createOptPipelineView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.optPipelineButton.on('click', () => {
const insertPoint =
@@ -800,7 +800,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.deviceButton, createDeviceView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.deviceButton.on('click', () => {
const insertPoint =
@@ -813,7 +813,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.rustMirButton, createRustMirView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.rustMirButton.on('click', () => {
const insertPoint =
@@ -826,7 +826,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.haskellCoreButton, createHaskellCoreView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.haskellCoreButton.on('click', () => {
const insertPoint =
@@ -839,7 +839,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.haskellStgButton, createHaskellStgView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.haskellStgButton.on('click', () => {
const insertPoint =
@@ -852,7 +852,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.haskellCmmButton, createHaskellCmmView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.haskellCmmButton.on('click', () => {
const insertPoint =
@@ -865,7 +865,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.rustMacroExpButton, createRustMacroExpView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.rustMacroExpButton.on('click', () => {
const insertPoint =
@@ -878,7 +878,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.rustHirButton, createRustHirView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.rustHirButton.on('click', () => {
const insertPoint =
@@ -891,7 +891,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.gccDumpButton, createGccDumpView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.gccDumpButton.on('click', () => {
const insertPoint =
@@ -904,7 +904,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.gnatDebugTreeButton, createGnatDebugTreeView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.gnatDebugTreeButton.on('click', () => {
const insertPoint =
@@ -917,7 +917,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.gnatDebugButton, createGnatDebugView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.gnatDebugButton.on('click', () => {
const insertPoint =
@@ -930,7 +930,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.cfgButton, createCfgView as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.cfgButton.on('click', () => {
const insertPoint =
@@ -943,7 +943,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(this.executorButton, createExecutor as any)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hidePaneAdder);
this.executorButton.on('click', () => {
const insertPoint =
@@ -2606,7 +2606,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
});
}
initToolButton(togglePannerAdder: () => void, button: JQuery<HTMLElement>, toolId: string): void {
initToolButton(hideToolDropdown: () => void, button: JQuery<HTMLElement>, toolId: string): void {
const createToolView: () => ComponentConfig<ToolViewState> = () => {
let args = '';
let monacoStdin = false;
@@ -2634,7 +2634,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
.createDragSource(button, createToolView())
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
._dragListener.on('dragStart', togglePannerAdder);
._dragListener.on('dragStart', hideToolDropdown);
button.on('click', () => {
button.prop('disabled', true);
@@ -2647,8 +2647,8 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
initToolButtons(): void {
this.toolsMenu = this.domRoot.find('.new-tool-dropdown');
const toggleToolDropdown = () => {
this.toolsMenu?.dropdown('toggle');
const hideToolDropdown = () => {
this.toolsMenu?.dropdown('hide');
};
this.toolsMenu.empty();
@@ -2678,7 +2678,7 @@ export class Compiler extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Co
this.toolsMenu?.append(btn);
if (toolName !== 'none') {
this.initToolButton(toggleToolDropdown, btn, toolName);
this.initToolButton(hideToolDropdown, btn, toolName);
}
};