Identify unused imports during lint (#5130)

.eslintrc.yml

@@ -166,6 +166,7 @@ rules:
   unicorn/no-useless-undefined:
     - error
     - checkArguments: false
+  'unused-imports/no-unused-imports': error
   '@typescript-eslint/no-empty-function': off
   '@typescript-eslint/no-unused-vars': off
   '@typescript-eslint/no-explicit-any': off

lib/.eslintrc.cjs

@@ -24,7 +24,7 @@
 
 module.exports = {
     root: true,
-    plugins: ['promise', 'requirejs'],
+    plugins: ['promise', 'requirejs', 'unused-imports'],
     extends: ['./.eslint-ce-lib.yml'],
     rules: {
         'promise/catch-or-return': 'off',
@@ -57,13 +57,14 @@ module.exports = {
                 project: '../tsconfig.json',
             },
             rules: {
+                'import/no-unresolved': 'off',
+                'node/no-missing-imports': 'off',
+                'unused-imports/no-unused-imports': 'error',
                 '@typescript-eslint/no-empty-function': 'off',
                 '@typescript-eslint/no-unused-vars': 'off',
                 '@typescript-eslint/no-var-requires': 'error',
                 '@typescript-eslint/no-explicit-any': 'off', // Too much js code still exists
                 '@typescript-eslint/ban-ts-comment': 'error',
-                'import/no-unresolved': 'off',
-                'node/no-missing-imports': 'off',
                 // TODO: Disabled for now
                 //'@typescript-eslint/no-unnecessary-condition': 'error',
                 //'@typescript-eslint/no-unnecessary-type-assertion': 'error',

lib/buildenvsetup/base.ts

@@ -24,7 +24,6 @@
 
 import path from 'path';
 
-import fs from 'fs-extra';
 import _ from 'underscore';
 
 import {logger} from '../logger.js';

lib/compilers/clang.ts

@@ -36,7 +36,6 @@ import {AmdgpuAsmParser} from '../parsers/asm-parser-amdgpu.js';
 import {SassAsmParser} from '../parsers/asm-parser-sass.js';
 import * as utils from '../utils.js';
 import {ArtifactType} from '../../types/tool.interfaces.js';
-import {ClangParser} from './argument-parsers.js';
 
 const offloadRegexp = /^#\s+__CLANG_OFFLOAD_BUNDLE__(__START__|__END__)\s+(.*)$/gm;
 

lib/compilers/gnucobol.ts

@@ -22,14 +22,11 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.
 
-import _ from 'underscore';
-
 import path from 'path';
 
-import type {CompilationResult, ExecutionOptions} from '../../types/compilation/compilation.interfaces.js';
+import type {ExecutionOptions} from '../../types/compilation/compilation.interfaces.js';
 import type {ParseFiltersAndOutputOptions} from '../../types/features/filters.interfaces.js';
 import {BaseCompiler} from '../base-compiler.js';
-import * as utils from '../utils.js';
 import {PreliminaryCompilerInfo} from '../../types/compiler.interfaces.js';
 import {CompilationEnvironment} from '../compilation-env.js';
 

lib/compilers/z88dk.ts

@@ -28,7 +28,7 @@ import type {ExecutionOptions} from '../../types/compilation/compilation.interfa
 import type {PreliminaryCompilerInfo} from '../../types/compiler.interfaces.js';
 import type {ParseFiltersAndOutputOptions} from '../../types/features/filters.interfaces.js';
 import {ArtifactType} from '../../types/tool.interfaces.js';
-import {BaseCompiler, c_default_target_description} from '../base-compiler.js';
+import {BaseCompiler} from '../base-compiler.js';
 import {logger} from '../logger.js';
 import {AsmParserZ88dk} from '../parsers/asm-parser-z88dk.js';
 import * as utils from '../utils.js';

lib/compilers/zig.ts

@@ -26,7 +26,6 @@ import path from 'path';
 
 import Semver from 'semver';
 import _ from 'underscore';
-import fs from 'fs-extra';
 
 import type {PreliminaryCompilerInfo} from '../../types/compiler.interfaces.js';
 import type {ParseFiltersAndOutputOptions} from '../../types/features/filters.interfaces.js';

lib/parsers/asm-parser-vc6.ts

@@ -22,13 +22,9 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.
 
-import {logger} from '../logger.js';
 import {PropertyGetter} from '../properties.interfaces.js';
-import * as utils from '../utils.js';
 
-import {AsmParser} from './asm-parser.js';
 import {VcAsmParser} from './asm-parser-vc.js';
-import {AsmRegex} from './asmregex.js';
 
 export class Vc6AsmParser extends VcAsmParser {
     constructor(compilerProps?: PropertyGetter) {

lib/parsers/llvm-pass-dump-parser.ts

@@ -22,8 +22,6 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.
 
-import _ from 'underscore';
-
 import {
     LLVMOptPipelineBackendOptions,
     LLVMOptPipelineResults,

static/.eslintrc.cjs

@@ -25,7 +25,7 @@
 // This file is in js due to #3514
 module.exports = {
     root: true,
-    plugins: ['promise', 'requirejs'],
+    plugins: ['promise', 'requirejs', 'unused-imports'],
     extends: ['./.eslint-ce-static.yml'],
     rules: {
         'promise/catch-or-return': 'off',
@@ -58,6 +58,9 @@ module.exports = {
                 project: './tsconfig.json',
             },
             rules: {
+                'import/no-unresolved': 'off',
+                'node/no-missing-imports': 'off',
+                'unused-imports/no-unused-imports': 'error',
                 '@typescript-eslint/no-empty-function': 'off',
                 '@typescript-eslint/no-unused-vars': 'off',
                 '@typescript-eslint/no-var-requires': 'off', // Needed for now, can't move some
@@ -66,8 +69,6 @@ module.exports = {
                 '@typescript-eslint/no-unnecessary-condition': 'error',
                 '@typescript-eslint/no-unnecessary-type-assertion': 'error',
                 '@typescript-eslint/prefer-includes': 'error',
-                'import/no-unresolved': 'off',
-                'node/no-missing-imports': 'off',
             },
         },
     ],

static/compiler-shared.ts

@@ -22,7 +22,6 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.
 
-import $ from 'jquery';
 import type {ICompilerShared} from './compiler-shared.interfaces.js';
 import {CompilerOverridesWidget} from './widgets/compiler-overrides.js';
 import type {CompilerState} from './panes/compiler.interfaces.js';

static/components.interfaces.ts

@@ -26,7 +26,6 @@ import {CompilerOutputOptions} from '../types/features/filters.interfaces.js';
 import {CfgState} from './panes/cfg-view.interfaces.js';
 import {LLVMOptPipelineViewState} from './panes/llvm-opt-pipeline.interfaces.js';
 import {GccDumpViewState} from './panes/gccdump-view.interfaces.js';
-import {PossibleArguments} from './compiler-arguments.interfaces.js';
 import {ConfiguredOverrides} from './compilation/compiler-overrides.interfaces.js';
 export const COMPILER_COMPONENT_NAME = 'compiler';
 export const EXECUTOR_COMPONENT_NAME = 'executor';

static/graph-layout-core.ts

@@ -24,7 +24,7 @@
 
 import {AnnotatedCfgDescriptor, AnnotatedNodeDescriptor} from '../types/compilation/cfg.interfaces.js';
 
-import IntervalTree, {Node} from '@flatten-js/interval-tree';
+import IntervalTree from '@flatten-js/interval-tree';
 
 // Much of the algorithm is inspired from
 // https://cutter.re/docs/api/widgets/classGraphGridLayout.html

static/panes/executor.ts

@@ -52,7 +52,6 @@ import {CompilerPicker} from '../widgets/compiler-picker.js';
 import {SourceAndFiles} from '../download-service.js';
 import {ICompilerShared} from '../compiler-shared.interfaces.js';
 import {CompilerShared} from '../compiler-shared.js';
-import type {ConfiguredOverrides} from '../compilation/compiler-overrides.interfaces.js';
 import {CompilationRequest, CompilationRequestOptions, LangInfo} from './compiler-request.interfaces.js';
 
 const languages = options.languages;

static/themes.ts

@@ -26,7 +26,6 @@ import $ from 'jquery';
 import {editor} from 'monaco-editor';
 import {SiteSettings} from './settings.js';
 import GoldenLayout from 'golden-layout';
-import {assert} from './assert.js';
 import {isString} from '../lib/common-utils.js';
 
 export type Themes = 'default' | 'dark' | 'darkplus' | 'pink' | 'system';

static/widgets/compiler-picker.ts

@@ -31,7 +31,6 @@ import {EventHub} from '../event-hub.js';
 import {Hub} from '../hub.js';
 import {CompilerService} from '../compiler-service.js';
 import {CompilerInfo} from '../../types/compiler.interfaces.js';
-import {unique} from '../../lib/common-utils.js';
 import {unwrap} from '../assert.js';
 import {CompilerPickerPopup} from './compiler-picker-popup.js';
 

test/base-compiler-tests.ts

@@ -26,7 +26,6 @@ import {BaseCompiler} from '../lib/base-compiler.js';
 import {BuildEnvSetupBase} from '../lib/buildenvsetup/index.js';
 import {CompilationEnvironment} from '../lib/compilation-env.js';
 import {Win32Compiler} from '../lib/compilers/win32.js';
-import * as exec from '../lib/exec.js';
 import {CompilerOverrideType, ConfiguredOverrides} from '../types/compilation/compiler-overrides.interfaces.js';
 import {CompilerInfo} from '../types/compiler.interfaces.js';
 

test/cache-tests.ts

@@ -26,7 +26,7 @@ import {Readable} from 'stream';
 
 import {GetObjectCommand, NoSuchKey, PutObjectCommand, S3} from '@aws-sdk/client-s3';
 import {sdkStreamMixin} from '@aws-sdk/util-stream-node';
-import {AwsClientStub, AwsError, AwsStub, mockClient} from 'aws-sdk-client-mock';
+import {AwsClientStub, mockClient} from 'aws-sdk-client-mock';
 import temp from 'temp';
 
 import {BaseCache} from '../lib/cache/base.js';

test/llvm-ast-parser-tests.ts

@@ -25,7 +25,6 @@
 import cloneDeep from 'lodash.clonedeep';
 
 import {LlvmAstParser} from '../lib/llvm-ast.js';
-import {PropertyValue} from '../lib/properties.interfaces.js';
 import * as properties from '../lib/properties.js';
 import * as utils from '../lib/utils.js';
 

test/options-handler.js

@@ -29,7 +29,6 @@ import _ from 'underscore';
 import {BaseCompiler} from '../lib/base-compiler.js';
 import {ClientOptionsHandler} from '../lib/options-handler.js';
 import * as properties from '../lib/properties.js';
-import {parseOutput} from '../lib/utils.js';
 
 import {should} from './utils.js';
 

test/pp-output-test.ts

@@ -22,8 +22,6 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.
 
-import * as fs from 'fs';
-
 import {BaseCompiler} from '../lib/base-compiler.js';
 import {CompilationEnvironment} from '../lib/compilation-env.js';
 import * as properties from '../lib/properties.js';

test/utils-tests.ts

@@ -27,7 +27,7 @@ import {fileURLToPath} from 'url';
 
 import winston from 'winston';
 
-import {logger, makeLogStream} from '../lib/logger.js';
+import {makeLogStream} from '../lib/logger.js';
 import * as utils from '../lib/utils.js';
 
 import {fs} from './utils.js';