default ripmethod to mkv (#23)

Note on installing MakeMKV license

.gitignore

@@ -2,4 +2,4 @@ logs/*
 test.sh
 archive/
 config
-
+temp/

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "build"]
+	path = build
+	url = https://github.com/caarlos0/shell-travis-build.git

.travis.yml

@@ -0,0 +1,12 @@
+language: bash
+sudo: required
+os:
+  - linux
+before_script:
+  - cp ./config.sample config
+install:
+  - ./build/install.sh
+script:
+  - ./build/build.sh 
+notifications:
+  email: false

CHANGELOG.md

@@ -0,0 +1,35 @@
+# Changelog
+
+## v1.3.0
+ - Get Title for DVD and Blu-Rays so that media servesr can identify them easily.
+ - Determine if video is Movie or TV-Show from OMDB API query so that different actions can be taken (TV shows usually require manual episode identification)
+ - Option for MakeMKV to rip using backup method.
+ - Option to rip only main feature if so desired.
+
+## v1.2.0
+- Distinguish UDF data from UDF video discs
+
+## v1.1.1
+
+- Added devname to abcde command
+- Added logging stats (timers). "grep STAT" to see parse them out.
+
+## v1.1.0
+
+- Added ability to rip from multiple drives at the same time
+- Added a config file for parameters
+- Changed logging
+  - Log name is based on ID_FS_LABEL (dvd name) variable set by udev in order to isolate logging from multiple process running simultaneously
+  - Log file name and path set in config file
+  - Log file cleanup based on parameter set in config file
+- Added phone notification options for Pushbullet and IFTTT
+- Remove MakeMKV destination directory after HandBrake finishes transcoding
+- Misc stuff
+
+## v1.0.1
+
+- Fix ripping "Audio CDs" in ISO9660 format like LOTR.
+
+## v1.0.0
+
+- Initial Release

README

@@ -1,5 +0,0 @@
-Automatic Ripping Machine (ARM)
-
-See: https://b3n.org/automatic-ripping-machine
-
-

README.md

@@ -0,0 +1,81 @@
+# Automatic Ripping Machine (ARM)
+
+[![Build Status](https://travis-ci.org/ahnooie/automatic-ripping-machine.svg?branch=master)](https://travis-ci.org/ahnooie/automatic-ripping-machine)
+
+## Overview
+
+Insert an optical disc (Blu-Ray, DVD, CD) and checks to see if it's audio, video (Movie or TV), or data, then rips it.
+
+See: https://b3n.org/automatic-ripping-machine
+
+
+## Features
+
+- Detects insertion of disc using udev
+- Determines disc type...
+  - If video (Blu-Ray or DVD)
+    - Retrieve title from disc or Windows Media MetaServices API to name the folder "movie title (year)" so that Plex or Emby can pick it up
+    - Determine if video is Movie or TV using OMDb API
+    - Rip using MakeMKV (can rip all features or main feature)
+    - Eject disc and queue up Handbrake transcoding when done 
+    - Transcoding jobs are asynchronusly batched from ripping
+    - Send notification when done via IFTTT or Pushbullet
+  - If audio (CD) - rip using abcde
+  - If data (Blu-Ray, DVD, or CD) - make an ISO backup
+- Headless, designed to be run from a server
+- Can rip from multiple-optical drives in parallel
+
+
+## Requirements
+
+- Ubuntu Server 16.04 (should work with other Linux distros)
+- One or more optical drives to rip Blu-Rays, DVDs, and CDs
+- Lots of drive space (I suggest using a NAS like FreeNAS) to store your movies
+
+## Install
+
+    sudo su
+    add-apt-repository ppa:heyarje/makemkv-beta
+    add-apt-repository ppa:stebbins/handbrake-releases
+    add-apt-repository ppa:mc3man/xerus-media
+    apt update
+    apt install makemkv-bin makemkv-oss
+    apt install handbrake-cli libavcodec-extra
+    apt install abcde flac imagemagick glyrc cdparanoia
+    apt install at
+    apt install python3 python3-pip
+    apt-get install libdvd-pkg
+    dpkg-reconfigure libdvd-pkg
+    cd /opt
+    git clone https://github.com/ahnooie/automatic-ripping-machine.git arm
+    cd arm
+    pip3 install -r requirements.txt
+    ln -s /opt/arm/51-automedia.rules /lib/udev/rules.d/
+    ln -s /opt/arm/.abcde.conf /root/
+    cp config.sample config
+
+- Edit your "config" file to determine what options you'd like to use
+- To rip Blu-Rays after the MakeMKV trial is up you will need to purchase a license key or while MakeMKV is in BETA you can get a free key (which you will need to update from time to time) here:  https://www.makemkv.com/forum2/viewtopic.php?f=5&t=1053 and create /root/.MakeMKV/settings.conf with the contents:
+
+        app_Key = "insertlicensekeyhere" 
+
+
+Optionally if you want something more stable than master you can download the latest release from the releases page.
+
+## Usage
+
+- Insert disc
+- Wait for disc to eject
+- Repeat
+
+## Troubleshooting
+
+Check /opt/arm/log to see if you can find where the script failed.  If you need any help feel free to open an issue.
+
+## Contributing
+
+Pull requests are welcome
+
+## License
+
+[MIT License](LICENSE)

arm_wrapper.sh

@@ -1,2 +1,2 @@
 #!/bin/bash
-echo bash /opt/arm/identify.sh | at now
+echo bash /opt/arm/identify.sh /opt/arm/config | at now

config.sample

@@ -1,4 +1,3 @@
-#!/bin/bash
 # ARM (Automatic Ripping Machine) oonfig file
 
 #################
@@ -8,6 +7,9 @@
 # Distinguish UDF video discs from UDF data discs.  Requires mounting disc so adds a few seconds to the identify script.
 ARM_CHECK_UDF=true
 
+# When enabled if the disc is a DVD use dvdid to calculate a crc64 and query Windows Media Meta Services for the Movie Title.
+# For BluRays attempts to extract the title from an XML file on the disc
+GET_VIDEO_TITLE=true
 
 #####################
 ## Directory setup ##
@@ -21,6 +23,10 @@ ARMPATH="/mnt/media/ARM/"
 #Destination for MakeMKV and source for HandBrake
 RAWPATH="/mnt/media/ARM/raw/"
 
+#Path to final media directory
+#Destination for final file.  Only used for movies that are positively identified
+MEDIA_DIR="/mnt/media/ARM/emby/movies/"
+
 #Path to directory to hold log files
 #Make sure to include trailing /
 LOGPATH="/opt/arm/logs/"
@@ -35,6 +41,13 @@ LOGLIFE=1
 #Minimum length of track for MakeMKV rip (in seconds)
 MINLENGTH="600"
 
+#Method of MakeMKV to use for Blu Ray discs.  Options are "mkv" or "backup".
+#mkv is the normal method of ripping mkv files directly from the DVD
+#backup decrypts the dvd and then copies it to the hard drive.  This allows HandBrake to apply some of it's
+#analytical abilities such as the main-feature identification.  This method seems to offer success on bluray 
+#discs that fail in "mkv" mode. *** NOTE: MakeMKV only supports the backup method on BluRay discs.  Regular
+#DVD's will always default back to the "mkv" mode. If this is set to "backup" then you must also set HandBrake's MAINFEATURE to true. 
+RIPMETHOD="mkv" 
 
 ##########################
 ## HandBrake Parameters ##
@@ -50,13 +63,22 @@ DEST_EXT=mkv
 #Handbrake binary to call
 HANDBRAKE_CLI=HandBrakeCLI
 
+#Have HandBrake transcode the main feature only.  BluRay discs must have RIPMETHOD="backup" for this to work.
+#If MAINFEATURE is true, blurays will be backed up to the HD and then HandBrake will go to work on the backed up
+#files.  For normal DVDs, ARM will by pass MakeMKV and be accessed directly by HandBrake.  This will require 
+#libdvdcss2 be installed.
+#NOTE: For the most part, HandBrake correctly identifies the main feature on movie DVD's, although it is not perfect. 
+#However, it does not handle tv shows well at all.  You will likely want this value to be false when ripping tv shows.
+#MAINFEATURE=false
+MAINFEATURE=false
+
 #############################
 ## Notification Parameters ##
 #############################
 
 #Pushbullet API Key
 #Leave empty or comment out to disable Pushbullet notifications
-#PB_KEY=""
+PB_KEY=""
 
 #IFTTT API KEY
 #Leave empty or comment out to disable IFTTT notifications
@@ -69,7 +91,7 @@ IFTTT_EVENT="arm_event"
 #use the label of the DVD/CD or else use empty.log
 #this is required for udev events where there is no media available
 #such as ejecting the drive
-if [ -z $ID_FS_LABEL]; then
+if [ -z "$ID_FS_LABEL" ]; then
         LOGFILE="empty.log"
 else
         LOGFILE=${ID_FS_LABEL}".log"
@@ -77,3 +99,4 @@ fi
 
 #Set full logfile path
 LOG=$LOGPATH$LOGFILE
+

data_rip.sh

@@ -1,22 +1,24 @@
 #!/bin/bash
-#
 # Rip Data using DD
-source /opt/arm/config
+
+# shellcheck disable=SC1091
+# shellcheck source=config
+source "$ARM_CONFIG"
 
 {
 
 
 
-        TIMESTAMP=`date '+%Y%m%d_%H%M%S'`;
-        DEST=/mnt/media/ARM/${TIMESTAMP}_${ID_FS_LABEL}
-        mkdir $DEST
+        TIMESTAMP=$(date '+%Y%m%d_%H%M%S');
+        DEST="/mnt/media/ARM/${TIMESTAMP}_${ID_FS_LABEL}"
+        mkdir "$DEST"
 	FILENAME=${ID_FS_LABEL}_disc.iso
 
 
 	#dd if=/dev/sr0 of=$DEST/$FILENAME 
-	cat /dev/sr0 > $DEST/$FILENAME
+	cat "$DEVNAME" > "$DEST/$FILENAME"
 
 	eject
 
 
-} >> $LOG
+} >> "$LOG"

getmovietitle.py

@@ -0,0 +1,74 @@
+#!/usr/bin/python3
+
+import argparse
+import urllib
+import os
+import datetime
+import pydvdid
+import unicodedata
+import xmltodict
+import sys
+import re
+
+
+def entry():
+    """ Entry to program, parses arguments"""
+    parser = argparse.ArgumentParser(description='Get Movie Title from DVD or Blu-Ray')
+    parser.add_argument('-p', '--path', help='Mount path to disc', required=True)
+
+    return parser.parse_args()
+
+def getdvdtitle():
+    """ Calculates CRC64 for the DVD and calls Windows Media
+        Metaservices and returns the Title and year of DVD """
+    crc64 = pydvdid.compute(args.path)
+    # print (crc64)
+    dvd_info_xml = urllib.request.urlopen(
+        "http://metaservices.windowsmedia.com/pas_dvd_B/template/GetMDRDVDByCRC.xml?CRC={0}".
+        format(crc64)).read()
+
+    doc = xmltodict.parse(dvd_info_xml)
+    dvd_title = doc['METADATA']['MDR-DVD']['dvdTitle']
+    dvd_release_date = doc['METADATA']['MDR-DVD']['releaseDate']
+
+    # title + release year
+    return dvd_title + " (" + dvd_release_date.split()[0] + ")"
+
+def getbluraytitle():
+    """ Get's Blu-Ray title by parsing XML in bdmt_eng.xml """
+    with open(args.path + '/BDMV/META/DL/bdmt_eng.xml', "rb") as xml_file:
+        doc = xmltodict.parse(xml_file.read())
+
+
+    bluray_title = doc['disclib']['di:discinfo']['di:title']['di:name']
+
+    bluray_modified_timestamp = os.path.getmtime(args.path + '/BDMV/META/DL/bdmt_eng.xml')
+    bluray_year = (datetime.datetime.fromtimestamp(bluray_modified_timestamp).strftime('%Y'))
+
+    bluray_title = unicodedata.normalize('NFKD', bluray_title).encode('ascii', 'ignore').decode()
+
+    bluray_title = bluray_title.replace(' - Blu-rayTM', '')
+    bluray_title = bluray_title.replace(' - BLU-RAYTM', '')
+    bluray_title = bluray_title.replace(' - BLU-RAY', '')
+    bluray_title = bluray_title.replace(' - Blu-ray', '')
+    return bluray_title + " (" + bluray_year + ")"
+
+def clean_for_filename(string):
+    """ Cleans up string for use in filename """
+    string = re.sub('\[(.*?)\]', '', string)
+    string = re.sub( '\s+', ' ', string)
+    string = string.replace(' : ',' - ')
+    string = string.replace(': ',' - ')
+    return re.sub('[^\w\-_\.\(\) ]', '', string)
+
+#pylint: disable=C0103
+
+args = entry()
+
+try:
+    disc_title = clean_for_filename(getdvdtitle())
+except:
+    disc_title = clean_for_filename(getbluraytitle())
+    print(disc_title)
+else:
+    print(disc_title)

getvideotype.py

@@ -0,0 +1,54 @@
+#!/usr/bin/python3
+
+import sys
+import argparse
+import urllib
+import os
+import xmltodict
+import json
+import re
+
+def entry():
+    """ Entry to program, parses arguments"""
+    parser = argparse.ArgumentParser(description='Get type of dvd--movie or tv series')
+    parser.add_argument('-t', '--title', help='Title', required=True)
+
+    return parser.parse_args()
+
+def getdvdtype():
+    """ Queries OMDbapi.org for title information and parses if it's a movie
+        or a tv series """
+    dvd_title = args.title
+
+    year = dvd_title[(dvd_title.rindex('(')):len(dvd_title)]
+    year = re.sub('[()]','', year)
+
+    dvd_title = dvd_title[0:(dvd_title.rindex('('))].strip()
+    dvd_title = cleanupstring(dvd_title)
+
+    if year is None:
+        year = ""
+    
+    dvd_title_info_json = urllib.request.urlopen("http://www.omdbapi.com/?t={0}&y={1}&plot=short&r=json".format(dvd_title, year)).read()
+    doc = json.loads(dvd_title_info_json.decode())
+
+    return doc['Type']
+
+
+def cleanupstring(string):
+    # clean up title string to pass to OMDbapi.org
+    return re.sub('[_ ]',"+",string)
+
+args = entry()
+
+    
+try:
+    dvd_type = getdvdtype()
+except:
+    print("fail")
+else:
+    # we only want "movie" or "series"
+    if dvd_type == "movie" or dvd_type == "series":
+        print(dvd_type)
+    else:
+        print("other")

identify.sh

@@ -1,62 +1,106 @@
 #!/bin/bash
-#
-source /opt/arm/config
+
+export ARM_CONFIG=$1
+
+echo "$ARM_CONFIG"
+
+# shellcheck source=config
+# shellcheck disable=SC1091
+source "$ARM_CONFIG"
 
 # Create log dir if needed
-mkdir -p $LOGPATH
+mkdir -p "$LOGPATH"
 
+#shellcheck disable=SC2094
 {
-echo "Starting Identify Script..." >> $LOG
+echo "Starting Identify Script..." >> "$LOG"
+
+VIDEO_TITLE=""
+HAS_NICE_TITLE=""
 
 
 #Clean up old log files
-FILESFOUND=( $(find $LOGPATH -mtime +$LOGLIFE -type f))
-echo "Deleting ${#FILESFOUND[@]} old log files:"${FILESFOUND[@]} >> $LOG
-find $LOGPATH -mtime +$LOGLIFE -type f -delete
+FILESFOUND=( $(find "$LOGPATH" -mtime +"$LOGLIFE" -type f))
+echo "Deleting ${#FILESFOUND[@]} old log files: ${FILESFOUND[*]}" >> "$LOG"
+find "$LOGPATH" -mtime +"$LOGLIFE" -type f -delete
 
 # Set Home to home folder of user that is setup to run MakeMKV
 export HOME="/root/"
 
+# Output UDEV info
+udevadm info -q env -n "$DEVNAME" >> "$LOG"
 
-if [ $ID_FS_TYPE == "udf" ]; then
-	echo "identified udf" >> $LOG
-	echo "found ${ID_FS_LABEL} on ${DEVNAME}" >> $LOG
+if [ "$ID_FS_TYPE" == "udf" ]; then
+	echo "identified udf" >> "$LOG"
+	echo "found ${ID_FS_LABEL} on ${DEVNAME}" >> "$LOG"
 
-	if [ $ARM_CHECK_UDF == true ]; then
+	if [ "$ARM_CHECK_UDF" == true ]; then
 		# check to see if this is really a video
-		mkdir -p /mnt/${DEVNAME}
-		mount ${DEVNAME} /mnt/${DEVNAME}
+		mkdir -p /mnt/"$DEVNAME"
+		mount "$DEVNAME" /mnt/"$DEVNAME"
 		if [[ -d /mnt/${DEVNAME}/VIDEO_TS || -d /mnt/${DEVNAME}/BDMV ]]; then
-			echo "identified udf as video" >> $LOG
-			umount /mnt/${DEVNAME}
-			/opt/arm/video_rip.sh $LOG
+			echo "identified udf as video" >> "$LOG"
+
+			if [ "$GET_VIDEO_TITLE" == true ]; then
+
+				GET_TITLE_OUTPUT=$(/opt/arm/getmovietitle.py -p /mnt"${DEVNAME}" 2>&1)
+				GET_TITLE_RESULT=$?
+
+				if [ $GET_TITLE_RESULT = 0 ]; then
+					echo "Obtained Title $GET_TITLE_OUTPUT"
+					HAS_NICE_TITLE=true
+					VIDEO_TITLE=${GET_TITLE_OUTPUT}
+				else
+					echo "failed to get title $GET_TITLE_OUTPUT"
+					HAS_NICE_TITLE=false
+					VIDEO_TITLE=${ID_FS_LABEL} 
+				fi
+
+			else
+				HAS_NICE_TITLE=false
+				VIDEO_TITLE=${ID_FS_LABEL} 
+			fi
+
+			if [ $HAS_NICE_TITLE == true ]; then
+				VIDEO_TYPE=$(/opt/arm/getvideotype.py -t "${VIDEO_TITLE}" 2>&1)
+			else
+				VIDEO_TYPE="unknown"
+			fi
+
+			echo "got to here"
+			echo "HAS_NICE_TITLE is ${HAS_NICE_TITLE}"
+			echo "video title is now ${VIDEO_TITLE}"
+			echo "video type is ${VIDEO_TYPE}"
+
+			umount "/mnt/$DEVNAME"
+			/opt/arm/video_rip.sh "$VIDEO_TITLE" "$HAS_NICE_TITLE" "$VIDEO_TYPE" "$LOG"
 		else
-			umount /mnt/${DEVNAME}
-			echo "identified udf as data" >> $LOG
-			/opt/arm/data_rip.sh $LOG
-			eject $DEVNAME
+			umount "/mnt/$DEVNAME"
+			echo "identified udf as data" >> "$LOG"
+			/opt/arm/data_rip.sh
+			eject "$DEVNAME"
 
 		fi
 	else
-		echo "ARM_CHECK_UDF is false, assuming udf is video" >> $LOG
-		/opt/arm/video_rip.sh $LOG
+		echo "ARM_CHECK_UDF is false, assuming udf is video" >> "$LOG"
+		/opt/arm/video_rip.sh "$LOG"
 	fi	
 
 
-elif (($ID_CDROM_MEDIA_TRACK_COUNT_AUDIO > 0 )); then
-	echo "identified audio" >> $LOG
-	abcde -d $DEVNAME
+elif (("$ID_CDROM_MEDIA_TRACK_COUNT_AUDIO" > 0 )); then
+	echo "identified audio" >> "$LOG"
+	abcde -d "$DEVNAME"
 
-elif [ $ID_FS_TYPE == "iso9660" ]; then
-	echo "identified data" >> $LOG
-	/opt/arm/data_rip.sh $LOG
-	eject $DEVNAME
+elif [ "$ID_FS_TYPE" == "iso9660" ]; then
+	echo "identified data" >> "$LOG"
+	/opt/arm/data_rip.sh "$LOG"
+	eject "$DEVNAME"
 else
-	echo "unable to identify" >> $LOG
-	echo $ID_CDROM_MEDIA_TRACK_COUNT_AUDIO >> $LOG
-	echo $ID_FS_TYPE >> $LOG
-	eject $DEVNAME
+	echo "unable to identify"
+	echo "$ID_CDROM_MEDIA_TRACK_COUNT_AUDIO" >> "$LOG"
+	echo "$ID_FS_TYPE" >> "$LOG"
+	eject "$DEVNAME"
 fi
 
 
-} >> $LOG
+} >> "$LOG"

notify.sh

@@ -1,28 +1,30 @@
 #!/bin/bash
 
-source /opt/arm/config
+# shellcheck source=config
+# shellcheck disable=SC1091
+source "$ARM_CONFIG"
 MSG=$1
 
 {
 #Notification via pushbullet
 #Trigger onl if variable is set
 if [ -z "$PB_KEY" ]; then
-	echo "Pushbullet notifications not enabled" >> $LOG
+	echo "Pushbullet notifications not enabled" >> "$LOG"
 else
-	echo "Sending Pushbullet notification" >> $LOG
-	curl -s -u $PB_KEY: https://api.pushbullet.com/v2/pushes -d type=note -d title="Alert" -d body="$MSG"
-	echo "Pushbullet notification sent" >> $LOG
+	echo "Sending Pushbullet notification" >> "$LOG"
+	curl -s -u "$PB_KEY": https://api.pushbullet.com/v2/pushes -d type=note -d title="Alert" -d body="$MSG"
+	echo "Pushbullet notification sent" >> "$LOG"
 fi
 
 #Notification via IFTTT
 #Trigger only if variable is set
 if [ -z "$IFTTT_KEY" ]; then
-	echo "IFTTT notifications not enabled" >> $LOG
+	echo "IFTTT notifications not enabled" >> "$LOG"
 else
-	echo "Sending IFTTT notification" >> $LOG
-	curl -s -X POST -H "Content-Type: application/json" -d '{"value1":"'"$MSG"'"}' https://maker.ifttt.com/trigger/${IFTTT_EVENT}/with/key/${IFTTT_KEY}
-	printf "\nIFTTT notification sent" >> $LOG
+	echo "Sending IFTTT notification" >> "$LOG"
+	curl -s -X POST -H "Content-Type: application/json" -d '{"value1":"'"$MSG"'"}' https://maker.ifttt.com/trigger/"$IFTTT_EVENT"/with/key/"$IFTTT_KEY"
+	printf "\nIFTTT notification sent" >> "$LOG"
 fi
 
-} >> $LOG
+} >> "$LOG"
 

requirements.txt

@@ -0,0 +1,5 @@
+pycurl>=7.43.0
+pydvdid>=1.0
+requests>=2.9.1
+urllib3>=1.13.1
+xmltodict>=0.10.2

video_rip.sh

@@ -1,33 +1,57 @@
 #!/bin/bash
-#
 # Rip video using MakeMKV then eject and call transcode script
 
-source /opt/arm/config
+# shellcheck source=config
+# shellcheck disable=SC1091
+source "$ARM_CONFIG"
+
+VIDEO_TITLE=$1
+HAS_NICE_TITLE=$2
+VIDEO_TYPE=$3
 
 {
 
-        echo "Ripping video ${ID_FS_LABEL} from ${DEVNAME}" >> $LOG
-	TIMESTAMP=`date '+%Y%m%d_%H%M%S'`;
-        DEST=${RAWPATH}/${ID_FS_LABEL}_${TIMESTAMP}
+	echo "Video Title is ${VIDEO_TITLE}"
+ 	echo "Ripping video ${ID_FS_LABEL} from ${DEVNAME}" >> "$LOG"
+	TIMESTAMP=$(date '+%Y%m%d_%H%M%S');
+	DEST="${RAWPATH}/${VIDEO_TITLE}_${TIMESTAMP}"
 	RIPSTART=$(date +%s);
-        mkdir $DEST
+    
+	mkdir "$DEST"
 
+	#echo /opt/arm/video_transcode.sh \"$DEST\" \"$VIDEO_TITLE\" $TIMESTAMP >> $LOG
+	if [ "$RIPMETHOD" = "backup" ] && [ "$ID_CDROM_MEDIA_BD" = "1" ]; then
+		echo "Using backup method of ripping." >> "$LOG"
+		DISC="${DEVNAME: -1}"
+		echo "Sending command: makemkvcon backup --decrypt -r disc:$DISC $DEST"
+		makemkvcon backup --decrypt -r disc:"$DISC" "$DEST"/
+		eject "$DEVNAME"
+	elif [ "$MAINFEATURE" = true ] && [ "$ID_CDROM_MEDIA_DVD" = "1" ] && [ -z "$ID_CDROM_MEDIA_BD" ]; then
+		echo "Media is DVD and Main Feature parameter in config file is true.  Bypassing MakeMKV." >> "$LOG"
+		# rmdir "$DEST"
 
-	makemkvcon mkv dev:$DEVNAME all $DEST --minlength=$MINLENGTH -r
+	echo "DEST is ${DEST}"
+	else
+		echo "Using mkv method of ripping." >> "$LOG"
+		makemkvcon mkv dev:"$DEVNAME" all "$DEST" --minlength="$MINLENGTH" -r
+		eject "$DEVNAME"
+	fi
 
 	RIPEND=$(date +%s);
-	RIPSEC=$(($RIPEND-$RIPSTART));
-	RIPTIME="$(($RIPSEC / 3600)) hours, $((($RIPSEC / 60) % 60)) minutes and $(($RIPSEC % 60)) seconds."
+	RIPSEC=$((RIPEND-RIPSTART));
+	RIPTIME="$((RIPSEC / 3600)) hours, $(((RIPSEC / 60) % 60)) minutes and $((RIPSEC % 60)) seconds."
 
-	eject $DEVNAME
+	#eject $DEVNAME
 
-	echo /opt/arm/notify.sh "\"Ripped: ${ID_FS_LABEL} completed from ${DEVNAME} in ${RIPTIME}\"" |at now
+	#echo /opt/arm/notify.sh "\"Ripped: ${ID_FS_LABEL} completed from ${DEVNAME} in ${RIPTIME}\"" |at now
 
-	echo "STAT: ${ID_FS_LABEL} ripped in ${RIPTIME}" >> $LOG
-	echo /opt/arm/video_transcode.sh $DEST $ID_FS_LABEL $TIMESTAMP | batch
+	echo "STAT: ${ID_FS_LABEL} ripped in ${RIPTIME}" >> "$LOG"
 
-	echo "${ID_FS_LABEL} sent to transcoding queue..." >> $LOG
+	echo "/opt/arm/video_transcode.sh \"$DEST\" \"$VIDEO_TITLE\" \"$HAS_NICE_TITLE\" \"$VIDEO_TYPE\" $TIMESTAMP"
+	echo "/opt/arm/video_transcode.sh \"$DEST\" \"$VIDEO_TITLE\" \"$HAS_NICE_TITLE\" \"$VIDEO_TYPE\" \"$TIMESTAMP\"" | batch
+
+	echo "${ID_FS_LABEL} sent to transcoding queue..." >> "$LOG"
 
 
 
-} >> $LOG
+} >> "$LOG"

video_transcode.sh

@@ -1,41 +1,87 @@
 #!/bin/bash
 # Transcodes Video files using HandBrake and removes source files when done
 
-source /opt/arm/config
+# shellcheck source=config
+# shellcheck disable=SC1091
+source "$ARM_CONFIG"
 
 SRC=$1
 LABEL=$2
-TIMESTAMP=$3
-TRANSSTART=$(date +%s);
+HAS_NICE_TITLE=$3
+VIDEO_TYPE=$4
+TIMESTAMP=$5
 
-echo "Start video transcoding script" >> $LOG
 
-	DEST=${ARMPATH}/${LABEL}_${TIMESTAMP}
-	mkdir $DEST
+	TRANSSTART=$(date +%s);
+	echo "Start video transcoding script" >> "$LOG"
 
-        for FILE in `ls $SRC`
-                do
-                filename=$(basename $FILE)
-                extension=${filename##*.}
-                filename=${filename%.*}
-	
-		echo "Transcoding file $FILE" >> $LOG
+	if [ "$HAS_NICE_TITLE" = true ]; then
+		echo "transcoding with a nice title" >> "$LOG"
+		DEST="${ARMPATH}/${LABEL}"
+		echo "dest ${DEST} variable created"
+		if [ -d "$DEST" ]; then
+			echo "directory already exists... adding timestamp" >> "$LOG"
+			DEST="${ARMPATH}/${LABEL}_${TIMESTAMP}"
+		fi
+	else
+		echo "transcoding without a nice title" >> "$LOG"
+		DEST="${ARMPATH}/${LABEL}_${TIMESTAMP}"
+	fi	
 
-                $HANDBRAKE_CLI -i $SRC/$FILE -o $DEST/$filename.$DEST_EXT --preset="$HB_PRESET" --subtitle scan -F 2>> $LOG
-		#TIMESTAMP=`date '+%Y_%m_%d__%H_%M_%S'`;
-		#mv $SRC/$FILE $SRC/done/$TIMESTAMP.$FILE
-		#mv $DEST/$FILE $DEST/done/$FILE
-		rm $SRC/$FILE
+	# DEST="${ARMPATH}/${LABEL}_${TIMESTAMP}"
+	mkdir "$DEST"
+	if [ "$RIPMETHOD" = "backup" ] && [ "$MAINFEATURE" = true ] && [ "$ID_CDROM_MEDIA_BD" = "1" ]; then
+		echo "Transcoding BluRay main feature only." >> "$LOG"
+		$HANDBRAKE_CLI -i "$SRC" -o "$DEST/$LABEL.$DEST_EXT" --main-feature --preset="$HB_PRESET" --subtitle scan -F 2>> "$LOG"
+		rmdir "$SRC"	
+	elif [ "$RIPMETHOD" = "backup" ] && [ "$MAINFEATURE" = false ] && [ "$ID_CDROM_MEDIA_BD" = "1" ]; then		
+		echo "Transcoding BluRay all titles above minlength." >> "$LOG"
+		# This fails, need to figure out how to iterate through all fetures on a backup source
+		$HANDBRAKE_CLI -i "$SRC" -o "$DEST/$LABEL.$DEST_EXT" --min-duration "$MINLENGTH" --preset="$HB_PRESET" --subtitle scan -F 2>> "$LOG"		
+		rmdir "$SRC"
+	elif [ "$MAINFEATURE" = true ] && [ "$ID_CDROM_MEDIA_DVD" = "1" ]; then
+		echo "Transcoding DVD main feature only." >> "$LOG"
+		# echo "$HANDBRAKE_CLI -i $DEVNAME -o \"${DEST}/${LABEL}.${DEST_EXT}\" --main-feature --preset="${HB_PRESET}" --subtitle scan -F 2" >> $LOG
+        $HANDBRAKE_CLI -i "$DEVNAME" -o "${DEST}/${LABEL}.${DEST_EXT}" --main-feature --preset="${HB_PRESET}" --subtitle scan -F 2>> "$LOG"
+		# $HANDBRAKE_CLI -i $DEVNAME -o "${DEST}/${LABEL}.${DEST_EXT}" --main-feature --preset="${HB_PRESET}">> $LOG
+		eject "$DEVNAME"
+	else
+		echo "Transcoding all files." >> "$LOG"
+		# shellcheck disable=SC2045
+	        for FILE in $(ls "$SRC")
+                	do
+                	filename=$(basename "$FILE")
 
-       	done
+                	#extension=${filename##*.}
+                	filename=${filename%.*}
 
-rmdir $SRC
+			echo "Transcoding file $FILE" >> "$LOG"
+                	$HANDBRAKE_CLI -i "$SRC/$FILE" -o "$DEST/$filename.$DEST_EXT" --preset="$HB_PRESET" --subtitle scan -F 2>> "$LOG"
+			rm "$SRC/$FILE"
+       		done
+		rmdir "$SRC"
+	fi
+
+	if [ "$VIDEO_TYPE" = "movie" ] && [ "$MAINFEATURE" = true ] && [ "$HAS_NICE_TITLE" = true ]; then
+        echo "checing for existing file" >> "$LOG"
+		if [ ! -f "$MEDIA_DIR/$LABEL.$DEST_EXT" ]; then
+			echo "No file found.  Moving \"$DEST/$LABEL.$DEST_EXT to $MEDIA_DIR/$LABEL.$DEST_EXT\"" >> "$LOG"
+			mv -n "$DEST/$LABEL.$DEST_EXT" "$MEDIA_DIR/$LABEL.$DEST_EXT"
+		else	
+			echo "Warning: $MEDIA_DIR/$LABEL.$DEST_EXT File exists! File moving aborted" >> "$LOG"
+        fi
+    else
+        echo "Nothing here..." >> "$LOG"
+	fi
+
+rmdir "$SRC" 
 
 TRANSEND=$(date +%s);
-TRANSSEC=$(($TRANSEND-$TRANSSTART));
-TRANSTIME="$(($TRANSSEC / 3600)) hours, $((($TRANSSEC / 60) % 60)) minutes and $(($TRANSSEC % 60)) seconds."
+TRANSSEC=$((TRANSEND-TRANSSTART));
+TRANSTIME="$((TRANSSEC / 3600)) hours, $(((TRANSSEC / 60) % 60)) minutes and $((TRANSSEC % 60)) seconds."
 
-echo "STAT: ${ID_FS_LABEL} transcoded in ${TRANSTIME}" >> $LOG
+echo "STAT: ${ID_FS_LABEL} transcoded in ${TRANSTIME}" >> "$LOG"
+
+#echo /opt/arm/rename.sh $DEST
 
 echo /opt/arm/notify.sh "\"Transcode: ${ID_FS_LABEL} completed in ${TRANSTIME}\"" |at now
-