aargonian/PopularMovies
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Various UI tweaks

Browse Source 
Resized the Image View in sw600-land layout to fit with the new detail_text_layout.

Fixed detail_text_layout sizes.

Fixed trailer_layout to be less hideous when large amounts of horizontal space are present.

Moved detail_text_fields common layout attrs to a style.
This commit is contained in:
Aargonian
2016-03-02 07:47:12 -05:00
parent 7fa36f7a21
commit 634cad9de7
9 changed files with 32 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/example/android/popularmovies/DetailFragment.java
View File

@@ -203,6 +203,7 @@ public class DetailFragment extends Fragment implements View.OnClickListener
reviews.removeAllViews();
if(movie.getReviews() != null && movie.getReviews().length > 0) {
reviewHeader.setVisibility(View.VISIBLE);
reviews.addView(reviewHeader); //Because it clears everytime we change movies
for(int i = 0; i < movie.getReviews().length; i++) {
TextView view =
(TextView)getLayoutInflater(null).inflate(R.layout.review_layout, null);
@@ -216,7 +217,6 @@ public class DetailFragment extends Fragment implements View.OnClickListener
TypedValue.COMPLEX_UNIT_DIP, 5, getResources().getDisplayMetrics());
params.setMargins(0, px, 0, px);
divider.setLayoutParams(params);
divider.setBackgroundColor(getResources().getColor(R.color.dividerColor));
reviews.addView(divider);
}
}
@@ -227,6 +227,7 @@ public class DetailFragment extends Fragment implements View.OnClickListener
if(shareActionProvider == null)
return;
Intent shareTrailerIntent = new Intent(Intent.ACTION_SEND);
//noinspection deprecation
shareTrailerIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET);
shareTrailerIntent.setType("text/plain");
shareTrailerIntent.putExtra(Intent.EXTRA_TEXT, trailer);

3
app/src/main/res/layout-land/fragment_detail.xml
View File

@@ -76,8 +76,9 @@
</RelativeLayout>
<LinearLayout
android:id="@+id/trailerList"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:orientation="vertical" />
<LinearLayout
android:id="@+id/reviewList"

5
app/src/main/res/layout-sw600dp-land/fragment_detail.xml
View File

@@ -37,7 +37,7 @@
style="@style/Poster_Image_Details"
android:id="@+id/posterImage"
android:layout_width="1dp"
android:layout_height="300dp"
android:layout_height="200dp"
android:layout_toLeftOf="@id/text_fields"
android:layout_toStartOf="@id/text_fields"
android:src="@mipmap/ic_launcher" />
@@ -77,8 +77,9 @@
</RelativeLayout>
<LinearLayout
android:id="@+id/trailerList"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:orientation="vertical" />
<LinearLayout
android:id="@+id/reviewList"

3
app/src/main/res/layout-sw600dp-port/fragment_detail.xml
View File

@@ -75,8 +75,9 @@
</RelativeLayout>
<LinearLayout
android:id="@+id/trailerList"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:orientation="vertical" />
<LinearLayout
android:id="@+id/reviewList"

18
app/src/main/res/layout/detail_text_fields.xml
View File

@@ -8,11 +8,11 @@
android:id="@+id/releaseHeader"
android:layout_alignParentTop="true"
android:layout_alignParentStart="true"
android:layout_alignParentLeft="true"/>
android:layout_alignParentLeft="true"
android:text="@string/release_header"/>
<TextView
style="@style/DetailText"
android:id="@+id/releaseDate"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_toRightOf="@id/releaseHeader"
android:layout_toEndOf="@id/releaseHeader"/>
<TextView
@@ -20,11 +20,11 @@
android:id="@+id/ratingHeader"
android:layout_below="@id/releaseHeader"
android:layout_alignStart="@id/releaseHeader"
android:layout_alignLeft="@id/releaseHeader"/>
android:layout_alignLeft="@id/releaseHeader"
android:text="@string/rating_header"/>
<TextView
style="@style/DetailText"
android:id="@+id/rating"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_toEndOf="@id/ratingHeader"
android:layout_toRightOf="@id/ratingHeader"
android:layout_alignTop="@id/ratingHeader"/>
@@ -33,11 +33,11 @@
android:id="@+id/runtimeHeader"
android:layout_below="@id/ratingHeader"
android:layout_alignStart="@id/ratingHeader"
android:layout_alignLeft="@id/ratingHeader"/>
android:layout_alignLeft="@id/ratingHeader"
android:text="@string/runtime_header"/>
<TextView
style="@style/DetailText"
android:id="@+id/runtime"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_toRightOf="@id/runtimeHeader"
android:layout_toEndOf="@id/runtimeHeader"
android:layout_alignTop="@id/runtimeHeader"/>

3
app/src/main/res/layout/fragment_detail.xml
View File

@@ -76,8 +76,9 @@
</RelativeLayout>
<LinearLayout
android:id="@+id/trailerList"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:orientation="vertical" />
<LinearLayout
android:id="@+id/reviewList"

5
app/src/main/res/layout/trailer_layout.xml
View File

@@ -1,12 +1,15 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:padding="10dp"
android:orientation="horizontal">
<ImageView
android:layout_width="96dp"
android:layout_height="96dp"
android:layout_marginRight="32dp"
android:layout_marginEnd="32dp"
android:adjustViewBounds="true"
android:scaleType="fitXY"
android:src="@drawable/trailer_icon"/>

1
app/src/main/res/values/strings.xml
View File

@@ -10,6 +10,7 @@
<string name="pref_sort_default">Popularity</string>
<string name="release_header">Release Date:</string>
<string name="rating_header">Rating:</string>
<string name="runtime_header">Runtime:</string>
<string name="pref_sort_popularity_value">Popularity</string>
<string name="pref_sort_rating_value">Rating</string>
<string name="pref_sort_favorite_value">Favorites</string>

10
app/src/main/res/values/styles.xml
View File

@@ -17,11 +17,15 @@
<style name="AppTheme.PopupOverlay" parent="ThemeOverlay.AppCompat.Light" />
<style name="HeaderText">
<item name="android:textStyle">bold</item>
<style name="DetailText">
<item name="android:layout_width">wrap_content</item>
<item name="android:layout_height">wrap_content</item>
<item name="android:textSize">12sp</item>
<item name="android:textSize">14sp</item>
</style>
<style name="HeaderText" parent="DetailText">
<item name="android:textStyle">bold</item>
<item name="android:layout_marginRight">5dp</item>
</style>
<style name="Poster_Image_Details">