mirrors/mdBook
1
0
Fork 0
mirror of https://github.com/rust-lang/mdBook.git synced 2025-12-27 10:16:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

serve: Fix repeated error message when HTML config is invalid

Browse Source 
This fixes an issue where `mdbook serve` would repeatedly show an error
message every second if the `output.html` config had a problem. The
issue is that `set_roots` was doing more work than I realized. It is not
necessary to call it every time in the main polling loop, since the
roots only change when the book configuration changes.

The solution is to just reset the roots whenever the book config
changes.

Fixes https://github.com/rust-lang/mdBook/issues/2946
This commit is contained in:
Eric Huss
2025-12-11 11:21:38 -08:00
parent f857ab294c
commit 723d9df6c7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/watch/poller.rs
View File

@@ -41,7 +41,6 @@ pub fn rebuild_on_change(
loop { loop {
std::thread::sleep(Duration::new(1, 0)); std::thread::sleep(Duration::new(1, 0));
watcher.set_roots(&book);
let start = Instant::now(); let start = Instant::now();
let paths = watcher.scan(); let paths = watcher.scan();
let elapsed = start.elapsed().as_secs_f64(); let elapsed = start.elapsed().as_secs_f64();
@@ -67,6 +66,7 @@ pub fn rebuild_on_change(
post_build(); post_build();
} }
book = b; book = b;
watcher.set_roots(&book);
} }
Err(e) => error!("failed to load book config: {e:?}"), Err(e) => error!("failed to load book config: {e:?}"),
} }