Alexey Dobriyan
99b7623380
proc 2/2: remove struct proc_dir_entry::owner
...
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454 . Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.
We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.
But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.
->read_proc/->write_proc were just fixed to not require ->owner for
protection.
rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.
Removing ->owner will also make PDE smaller.
So, let's nuke it.
Kudos to Jeff Layton for reminding about this, let's say, oversight.
http://bugzilla.kernel.org/show_bug.cgi?id=12454
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com >
2009-03-31 01:14:44 +04:00
..
2009-03-27 15:12:08 -07:00
2009-03-28 20:29:51 +00:00
2008-10-16 09:24:42 -07:00
2009-03-31 01:14:44 +04:00
2009-01-06 10:44:38 -08:00
2009-01-21 14:03:37 -08:00
2009-01-02 10:19:38 -08:00
2009-03-26 11:17:04 -07:00
2008-12-17 11:23:07 -08:00
2009-01-12 20:56:39 +01:00
2008-07-16 23:27:02 +02:00
2008-10-16 11:21:47 -07:00
2008-04-25 08:04:56 +08:00
2008-06-20 14:05:55 -06:00
2009-01-13 14:48:00 +11:00
2009-01-06 15:59:30 -08:00
2008-12-13 11:25:49 -08:00
2008-06-20 14:05:53 -06:00
2009-01-02 10:19:43 -08:00
2008-03-03 14:53:16 -08:00
2008-10-20 08:52:41 -07:00
2008-12-13 09:12:07 +00:00
2008-10-16 09:24:42 -07:00
2008-06-20 14:05:53 -06:00
2008-08-04 16:59:56 -07:00
2009-01-06 11:28:07 +01:00
2008-07-20 17:12:36 -07:00
2009-01-02 10:19:38 -08:00
2008-06-12 18:05:41 -07:00
2009-01-02 10:19:40 -08:00
2008-06-20 14:05:57 -06:00
2008-02-03 17:11:42 +02:00
2008-11-24 10:05:12 +01:00
2009-01-08 16:25:16 +11:00
2009-01-16 16:15:16 +11:00
2008-12-03 21:04:13 +11:00
2009-01-13 14:48:01 +11:00
2008-12-03 21:04:09 +11:00
2009-03-26 15:24:08 +01:00
2008-02-14 22:11:02 +11:00
2008-11-19 16:04:25 +11:00
2008-12-03 21:04:09 +11:00
2008-10-22 10:59:54 +11:00
2009-03-11 10:44:26 +11:00
2009-03-11 10:44:26 +11:00
2009-01-02 10:28:32 -08:00
2009-01-02 10:19:40 -08:00
2009-01-02 10:19:40 -08:00
2009-01-31 01:21:59 +01:00
2008-10-08 23:45:36 -04:00
2008-10-16 09:24:42 -07:00
2008-12-28 16:54:33 -08:00
2008-06-20 14:05:48 -06:00
2008-02-07 08:42:25 -08:00
2009-01-06 15:59:05 -08:00
2008-10-16 09:24:42 -07:00
2008-07-17 11:34:49 -07:00
2009-01-02 10:19:38 -08:00
2008-04-30 08:29:43 -07:00
2008-07-24 10:47:14 -07:00
2009-01-02 10:19:40 -08:00
2008-04-30 08:29:49 -07:00
2008-10-13 09:51:44 -07:00
2009-01-02 10:19:40 -08:00
2009-01-02 10:19:40 -08:00
2009-01-02 10:19:40 -08:00
2008-11-11 09:56:00 +00:00
2007-02-12 09:48:30 -08:00
2008-12-13 09:12:07 +00:00
2008-10-20 08:52:40 -07:00
2008-10-16 09:24:42 -07:00
2009-01-16 16:15:14 +11:00
2009-01-12 16:37:00 -08:00
2009-01-11 16:06:03 +01:00
2009-03-27 10:59:09 -06:00
2009-01-02 10:19:40 -08:00
2008-07-20 17:12:38 -07:00
2009-01-02 10:19:39 -08:00
2009-01-02 10:19:42 -08:00
2009-01-02 10:19:39 -08:00
2009-01-08 16:44:03 -07:00
2009-02-22 09:23:02 -08:00
2008-06-20 14:05:53 -06:00
2009-01-31 15:51:31 -08:00
2009-01-12 20:56:39 +01:00
2009-01-02 10:19:40 -08:00
2008-05-16 12:01:45 -07:00
2008-10-16 09:24:42 -07:00
2008-04-18 22:22:54 -04:00
2009-03-16 08:34:35 -06:00
2008-07-20 17:12:38 -07:00
2009-01-02 10:19:40 -08:00
2009-01-02 10:19:40 -08:00
2009-02-20 17:57:49 -08:00
2008-02-07 08:42:33 -08:00
2009-01-21 14:03:37 -08:00
2009-01-21 14:03:37 -08:00
2009-01-21 14:03:37 -08:00
2009-01-15 16:39:36 -08:00
2008-06-20 14:05:53 -06:00
2008-06-20 14:05:51 -06:00
2008-04-30 23:15:34 +02:00
2008-12-09 20:32:06 +11:00
2008-10-13 09:51:40 -07:00
2009-03-16 08:32:27 -06:00
2009-01-15 12:48:35 -08:00
2009-01-02 10:19:38 -08:00
2009-01-02 10:19:42 -08:00
2009-03-24 16:38:26 -07:00
2008-10-16 09:24:42 -07:00
2008-12-30 09:26:10 +10:30
2009-01-12 20:56:38 +01:00
2008-10-16 16:52:05 +02:00
2009-01-02 10:19:40 -08:00
2009-03-24 16:38:26 -07:00