mirrors/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-06 02:05:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
fe9ae05cfbe587dda724fcf537c00bc2f287da62
linux/drivers/video/fbdev
History
Takashi Iwai fe9ae05cfb fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release() 
The recent fix for the deferred I/O by the commit
  3efc61d952 ("fbdev: Fix invalid page access after closing deferred I/O devices")
caused a regression when the same fb device is opened/closed while
it's being used.  It resulted in a frozen screen even if something
is redrawn there after the close.  The breakage is because the patch
was made under a wrong assumption of a single open; in the current
code, fb_deferred_io_release() cleans up the page mapping of the
pageref list and it calls cancel_delayed_work_sync() unconditionally,
where both are no correct behavior for multiple opens.

This patch adds a refcount for the opens of the device, and applies
the cleanup only when all files get closed.

As both fb_deferred_io_open() and _close() are called always in the
fb_info lock (mutex), it's safe to use the normal int for the
refcounting.

Also, a useless BUG_ON() is dropped.

Fixes: 3efc61d952 ("fbdev: Fix invalid page access after closing deferred I/O devices")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230308105012.1845-1-tiwai@suse.de
2023-03-10 14:13:02 +01:00
..
aty
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
core
fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()
2023-03-10 14:13:02 +01:00
geode
fbdev: geode: don't build on UML
2022-12-14 20:01:51 +01:00
i810
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
intelfb
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
kyro
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
matrox
fbdev: matroxfb: Convert to i2c's .probe_new()
2022-12-14 20:01:50 +01:00
mb862xx
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
mmp
video: fbdev: mmp: replace usage of found with dedicated list iterator variable
2022-04-12 22:06:10 +02:00
nvidia
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
omap
fbdev: omap: Remove unnecessary print function dev_err()
2022-08-24 21:53:41 +02:00
omap2
fbdev: omapfb: panel-sharp-ls037v7dw01: fix included headers
2022-12-14 20:01:50 +01:00
riva
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
savage
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
sis
Backmerge tag 'v6.1-rc6' into drm-next
2022-11-24 11:05:43 +10:00
vermilion
fbdev: vermilion: decrease reference count in error path
2022-12-14 20:01:50 +01:00
via
fbdev: via: Fix error in via_core_init()
2022-12-14 20:01:50 +01:00
68328fb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
acornfb.c
video: fbdev: acornfb: remove free_unused_pages()
2021-02-24 13:38:31 -08:00
acornfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
amba-clcd.c
video: fbdev: amba-clcd: Fix refcount leak bugs
2022-07-26 08:56:22 +02:00
amifb.c
video: fbdev: amiga: Simplify amifb_pan_display()
2022-07-18 07:54:17 +02:00
arcfb.c
video: fbdev: arcfb: remove redundant initialization of variable err
2021-07-21 13:09:21 +02:00
arkfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
asiliantfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
atafb_iplan2p2.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_iplan2p4.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_iplan2p8.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_mfb.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_utils.h
…
atafb.c
video: fbdev: atari: Remove backward bug-compatibility
2022-07-18 07:56:18 +02:00
atafb.h
…
atmel_lcdfb.c
video: fbdev: atmel_lcdfb: fix an error code in atmel_lcdfb_probe()
2022-01-30 19:38:35 +01:00
au1100fb.c
video: fbdev: au1100fb: Drop unnecessary NULL ptr check
2022-06-20 20:19:50 +02:00
au1100fb.h
video: fbdev: au1100fb: Spelling s/palette/palette/
2022-02-16 10:54:42 +01:00
au1200fb.c
video: fbdev: au1200fb: Make use of dma_mmap_coherent()
2022-01-29 22:24:25 +01:00
au1200fb.h
…
broadsheetfb.c
fbdev: Use pageref offset for deferred-I/O writeback
2022-05-03 16:04:22 +02:00
bt431.h
…
bt455.h
…
bw2.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
c2p_core.h
fbdev: c2p: Use BUILD_BUG() instead of custom solution
2020-03-09 11:12:19 +01:00
c2p_iplan2.c
…
c2p_planar.c
…
c2p.h
…
carminefb_regs.h
…
carminefb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
carminefb.h
…
cg3.c
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
2020-12-08 18:34:08 +01:00
cg6.c
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
2020-12-08 18:34:08 +01:00
cg14.c
fbdev: cg14fb: use resource_size
2020-01-15 17:31:50 +01:00
chipsfb.c
fbdev: chipsfb: Fix error codes in chipsfb_pci_init()
2023-02-28 09:20:04 +01:00
cirrusfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
clps711x-fb.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
cobalt_lcdfb.c
video: constify fb ops across all drivers
2019-12-05 10:57:53 +02:00
controlfb.c
fbdev: controlfb: fix spelling mistake "paramaters"->"parameters"
2022-12-14 20:01:50 +01:00
controlfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cyber2000fb.c
Backmerge tag 'v6.1-rc6' into drm-next
2022-11-24 11:05:43 +10:00
cyber2000fb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
da8xx-fb.c
fbdev: da8xx-fb: add missing regulator_disable() in fb_probe
2022-12-14 20:01:50 +01:00
dnfb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
edid.h
…
efifb.c
Merge drm/drm-next into drm-misc-next
2022-06-20 18:21:25 +02:00
ep93xx-fb.c
fbdev: ep93xx-fb: Add missing clk_disable_unprepare in ep93xxfb_probe()
2022-12-14 20:01:50 +01:00
ffb.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
fm2fb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
fsl-diu-fb.c
video: fbdev: fsl-diu-fb: remove unneeded variable 'res'
2020-10-17 08:23:14 +02:00
g364fb.c
fbdev/g364fb: Fix build failure
2020-02-19 10:58:22 -08:00
gbefb.c
fbdev: gbefb: Convert sysfs snprintf to sysfs_emit
2022-10-18 10:28:41 +02:00
goldfishfb.c
video: fbdev: goldfishfb: Fix defined but not used warning
2020-12-08 18:34:50 +01:00
grvga.c
video: fbdev: Replace HTTP links with HTTPS ones
2020-07-20 11:47:29 +02:00
gxt4500.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
hecubafb.c
fbdev: Rename pagelist to pagereflist for deferred I/O
2022-05-03 16:04:22 +02:00
hgafb.c
video: hgafb: correctly handle card detect failure during probe
2021-05-21 15:04:05 +02:00
hitfb.c
mm: don't include asm/pgtable.h if linux/mm.h is already included
2020-06-09 09:39:13 -07:00
hpfb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
hyperv_fb.c
Merge tag 'drm-next-2022-12-13' of git://anongit.freedesktop.org/drm/drm
2022-12-13 11:59:58 -08:00
i740_reg.h
…
i740fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
imsttfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
imxfb.c
fbdev: imxfb: Remove redundant dev_err() call
2022-10-08 15:20:08 +02:00
Kconfig
fbdev: uvesafb: don't build on UML
2022-12-14 20:01:51 +01:00
leo.c
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
2020-12-08 18:34:08 +01:00
macfb.c
video: fbdev: Replace HTTP links with HTTPS ones
2020-07-20 11:47:29 +02:00
macmodes.c
…
macmodes.h
…
Makefile
ARM: omap1: move lcd_dma code into omapfb driver
2022-04-21 15:00:45 +02:00
maxinefb.c
video: constify fb ops across all drivers
2019-12-05 10:57:53 +02:00
metronomefb.c
fbdev: Use pageref offset for deferred-I/O writeback
2022-05-03 16:04:22 +02:00
mx3fb.c
dmaengine: imx: Move header to include/dma/
2022-04-19 12:06:18 +01:00
n411.c
…
neofb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
ocfb.c
video: fbdev: ocfb: add const to of_device_id
2022-01-29 22:24:25 +01:00
offb.c
video: fbdev: offb: Include missing linux/platform_device.h
2022-07-28 16:22:12 +10:00
p9100.c
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
2020-12-08 18:34:08 +01:00
platinumfb.c
video: fbdev: aty/matrox/...: Prepare cleanup of powerpc's asm/prom.h
2022-04-04 08:55:23 +02:00
platinumfb.h
…
pm2fb.c
fbdev: pm2fb: fix missing pci_disable_device()
2022-12-14 20:01:50 +01:00
pm3fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
pmag-aa-fb.c
Merge tag 'drm-next-2020-01-30' of git://anongit.freedesktop.org/drm/drm
2020-01-30 08:04:01 -08:00
pmag-ba-fb.c
Merge tag 'drm-next-2020-01-30' of git://anongit.freedesktop.org/drm/drm
2020-01-30 08:04:01 -08:00
pmagb-b-fb.c
Merge tag 'drm-next-2020-01-30' of git://anongit.freedesktop.org/drm/drm
2020-01-30 08:04:01 -08:00
ps3fb.c
powerpc/ps3: make system bus's remove and shutdown callbacks return void
2020-12-04 01:01:22 +11:00
pvr2fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
pxa3xx-gcu.c
video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
2022-06-20 20:12:17 +02:00
pxa3xx-gcu.h
…
pxa3xx-regs.h
ARM: pxa: move regs-lcd.h into driver
2022-04-19 16:29:03 +02:00
pxa168fb.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
pxa168fb.h
…
pxafb.c
fbdev: pxafb: Remove unnecessary print function dev_err()
2022-12-14 20:01:50 +01:00
pxafb.h
video: pxafb: Remove cpufreq policy notifier
2019-08-26 10:02:02 +02:00
q40fb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
s1d13xxxfb.c
video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings
2020-11-29 22:51:07 +01:00
s3c2410fb-regs-lcd.h
fbdev: s3c2410fb: remove mach header dependency
2020-08-20 17:48:12 +02:00
s3c2410fb.c
fbdev: s3c2410fb: remove mach header dependency
2020-08-20 17:48:12 +02:00
s3c2410fb.h
…
s3c-fb.c
Merge tag 'drm-next-2022-03-24' of git://anongit.freedesktop.org/drm/drm
2022-03-24 16:19:43 -07:00
s3fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
sa1100fb.c
video: fbdev: sa1100fb: Remove unused sa1100fb_setup()
2022-07-18 07:54:18 +02:00
sa1100fb.h
ARM/fbdev: sa11x0: Switch to use GPIO descriptors
2020-04-17 15:50:11 +02:00
sbuslib.c
fbdev: sbuslib: remove compat_alloc_user_space usage
2020-09-25 16:34:50 +02:00
sbuslib.h
…
sh7760fb.c
Merge tag 'drm-next-2020-01-30' of git://anongit.freedesktop.org/drm/drm
2020-01-30 08:04:01 -08:00
sh_mobile_lcdcfb.c
fbdev: sh_mobile_lcdcfb: use sysfs_emit() to instead of scnprintf()
2022-12-14 20:01:51 +01:00
sh_mobile_lcdcfb.h
fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
2019-06-12 20:28:11 +02:00
simplefb.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
skeletonfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
sm501fb.c
fbdev: sm501fb: Convert sysfs snprintf to sysfs_emit
2022-10-18 10:22:28 +02:00
sm712.h
fbdev: sm712fb: use 1024x768 by default on non-MIPS, fix garbled display
2019-04-01 17:46:59 +02:00
sm712fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
smscufx.c
fbdev: smscufx: fix error handling code in ufx_usb_probe
2022-12-14 20:01:50 +01:00
ssd1307fb.c
fbdev: ssd1307fb: Drop duplicate NULL checks for PWM APIs
2022-12-14 20:01:48 +01:00
sstfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
sticore.h
parisc/stifb: Keep track of hardware path of graphics card
2022-06-04 15:47:03 +02:00
stifb.c
fbdev: stifb: Fall back to cfb_fillrect() on 32-bit HCRX cards
2022-10-18 10:22:28 +02:00
sunxvr500.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
sunxvr1000.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
sunxvr2500.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
tcx.c
fbdev: Move fbdev drivers from strlcpy to strscpy
2022-08-24 22:06:15 +02:00
tdfxfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
tgafb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
tmiofb.c
video: constify fb ops across all drivers
2019-12-05 10:57:53 +02:00
tridentfb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
udlfb.c
fbdev: udlfb: Remove redundant initialization to variable identical
2022-10-08 15:20:08 +02:00
uvesafb.c
fbdev: uvesafb: use sysfs_emit() to instead of scnprintf()
2022-12-14 20:01:51 +01:00
valkyriefb.c
video: fbdev: Make *fb_setup() and *fb_init() static
2022-07-18 07:54:20 +02:00
valkyriefb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
vesafb.c
video: fbdev: vesafb: Fix a use-after-free due early fb_info cleanup
2022-05-28 19:26:56 +02:00
vfb.c
video: constify fb ops across all drivers
2019-12-05 10:57:53 +02:00
vga16fb.c
fbdev: vga16fb: Add missing MODULE_DEVICE_TABLE() entry
2022-10-08 15:20:09 +02:00
vt8500lcdfb.c
video: vt8500lcdfb: fix fallthrough warning
2020-04-17 15:50:08 +02:00
vt8500lcdfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
vt8623fb.c
fbdev: Add support for the nomodeset kernel parameter
2022-11-16 13:26:25 +01:00
w100fb.c
video: fbdev: w100fb: Reset global state
2022-01-29 22:24:26 +01:00
w100fb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
wm8505fb_regs.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
wm8505fb.c
video: fbdev: wm8505fb: fix sparse warnings about using incorrect types
2020-03-02 16:32:04 +01:00
wmt_ge_rops.c
video: fbdev: wmt_ge_rops: Fix function not declared warnings
2020-12-08 18:34:36 +01:00
wmt_ge_rops.h
…
xen-fbfront.c
printk, xen: fbfront: create/use safe function for forcing preferred
2022-12-02 11:25:02 +01:00
xilinxfb.c
fbdev: xilinxfb: Make xilinxfb_release() return void
2022-10-20 08:36:41 +02:00