Files
linux/fs
Chandan Rajendra fbdb440132 copy_mount_string: Limit string length to PATH_MAX
On ppc64le, When a string with PAGE_SIZE - 1 (i.e. 64k-1) length is
passed as a "filesystem type" argument to the mount(2) syscall,
copy_mount_string() ends up allocating 64k (the PAGE_SIZE on ppc64le)
worth of space for holding the string in kernel's address space.

Later, in set_precision() (invoked by get_fs_type() ->
__request_module() -> vsnprintf()), we end up assigning
strlen(fs-type-string) i.e. 65535 as the
value to 'struct printf_spec'->precision member. This field has a width
of 16 bits and it is a signed data type. Hence an invalid value ends
up getting assigned. This causes the "WARN_ONCE(spec->precision != prec,
"precision %d too large", prec)" statement inside set_precision() to be
executed.

This commit fixes the bug by limiting the length of the string passed by
copy_mount_string() to strndup_user() to PATH_MAX.

Signed-off-by: Chandan Rajendra <chandan@linux.ibm.com>
Reported-by: Abdul Haleem <abdhalee@linux.ibm.com>
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-02-01 01:57:33 -05:00
..
2019-01-04 13:13:48 -08:00
2019-01-06 08:36:21 -05:00
2018-08-21 23:54:17 -04:00
2018-12-03 15:30:24 -06:00
2018-11-30 14:56:14 -08:00
2018-08-17 16:20:28 -07:00
2018-09-29 22:47:48 -04:00
2018-05-22 14:27:52 -04:00
2018-11-05 14:57:05 -05:00
2018-05-22 14:27:52 -04:00
2019-01-07 08:53:32 +01:00
2018-07-03 16:44:45 -04:00
2018-06-05 19:23:26 +02:00
2018-10-31 08:54:16 -07:00
2018-10-21 10:46:42 -04:00
2018-06-11 08:22:34 -07:00
2018-02-15 15:34:42 -05:00