Tom Rix f4544e5361
net: mvneta: fix double free of txq->buf ...
clang static analysis reports this problem:
drivers/net/ethernet/marvell/mvneta.c:3465:2: warning:
Attempt to free released memory
kfree(txq->buf);
^~~~~~~~~~~~~~~
When mvneta_txq_sw_init() fails to alloc txq->tso_hdrs,
it frees without poisoning txq->buf. The error is caught
in the mvneta_setup_txqs() caller which handles the error
by cleaning up all of the txqs with a call to
mvneta_txq_sw_deinit which also frees txq->buf.
Since mvneta_txq_sw_deinit is a general cleaner, all of the
partial cleaning in mvneta_txq_sw_deinit()'s error handling
is not needed.
Fixes: 2adb719d74trix@redhat.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2020-10-04 15:07:19 -07:00
2020-08-26 10:50:50 -07:00
2020-09-16 19:36:26 +02:00
2020-07-29 17:05:44 +02:00
2020-09-04 13:19:19 -07:00
2020-09-04 21:42:57 -07:00
2020-09-05 14:22:46 -07:00
2020-09-13 09:02:59 -07:00
2020-08-02 18:26:51 +03:00
2020-10-02 15:27:08 -07:00
2020-07-31 15:11:52 -07:00
2020-08-23 17:36:59 -05:00
2020-08-30 15:53:44 -07:00
2020-09-10 13:42:35 -07:00
2020-09-20 10:51:11 -07:00
2020-08-22 11:38:42 +01:00
2020-09-01 21:15:00 +02:00
2020-09-18 11:48:25 -07:00
2020-08-30 15:53:44 -07:00
2020-09-20 08:57:36 -07:00
2020-07-30 17:22:58 +09:00
2020-09-04 12:12:39 -07:00
2020-09-03 17:47:02 +05:30
2020-09-15 09:42:15 +02:00
2020-08-23 17:36:59 -05:00
2020-09-20 15:18:11 -07:00
2020-07-27 11:49:37 +02:00
2020-08-23 17:36:59 -05:00
2020-09-18 08:52:06 +10:00
2020-07-29 16:58:08 +02:00
2020-09-02 12:55:46 -07:00
2020-08-23 17:36:59 -05:00
2020-09-15 16:20:43 -07:00
2020-08-29 12:37:00 -07:00
2020-08-23 17:36:59 -05:00
2020-09-18 23:11:44 +02:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-26 12:41:53 +02:00
2020-09-13 09:15:20 -07:00
2020-09-28 15:00:15 -07:00
2020-09-20 10:40:43 -07:00
2020-09-04 00:07:12 +03:00
2020-09-18 11:17:19 +02:00
2020-08-30 11:56:54 -07:00
2020-08-23 17:36:59 -05:00
2020-08-05 19:24:27 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-14 19:56:57 -07:00
2020-09-20 08:55:09 -07:00
2020-09-03 08:22:16 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-28 10:15:33 -07:00
2020-09-13 08:52:21 -07:00
2020-09-07 08:57:44 +02:00
2020-07-31 14:38:12 +02:00
2020-09-14 20:58:27 +05:30
2020-08-23 17:36:59 -05:00
2020-10-04 15:07:19 -07:00
2020-09-03 18:50:48 -07:00
2020-08-23 17:36:59 -05:00
2020-08-17 14:47:38 -06:00
2020-10-02 15:27:08 -07:00
2020-07-29 17:12:09 +02:00
2020-08-19 16:30:57 -06:00
2020-09-01 19:44:20 +02:00
2020-08-12 12:41:15 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-04 12:41:55 +02:00
2020-08-09 12:52:28 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-16 14:16:04 +02:00
2020-08-23 17:36:59 -05:00
2020-08-19 16:23:22 -07:00
2020-08-14 16:00:09 -07:00
2020-09-05 19:52:54 +03:00
2020-09-11 11:25:55 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-22 14:43:50 -07:00
2020-10-02 15:27:08 -07:00
2020-08-14 19:56:57 -07:00
2020-08-23 17:36:59 -05:00
2020-09-03 14:10:19 +05:30
2020-09-11 11:35:55 -07:00
2020-08-23 17:36:59 -05:00
2020-09-13 09:15:20 -07:00
2020-09-08 11:42:58 -07:00
2020-09-04 12:49:03 -07:00
2020-09-15 13:52:14 +02:00
2020-09-16 13:23:33 +02:00
2020-09-17 18:45:30 +02:00
2020-08-26 08:13:59 -04:00
2020-08-23 17:36:59 -05:00
2020-09-03 18:50:48 -07:00
2020-09-20 10:46:26 -07:00
2020-08-14 19:56:57 -07:00
2020-08-23 17:36:59 -05:00
2020-09-06 09:59:27 -07:00
f4544e5361