Files
linux/include/linux
Marco Elver efa90c11f6 stack: Constrain and fix stack offset randomization with Clang builds
All supported versions of Clang perform auto-init of __builtin_alloca()
when stack auto-init is on (CONFIG_INIT_STACK_ALL_{ZERO,PATTERN}).

add_random_kstack_offset() uses __builtin_alloca() to add a stack
offset. This means, when CONFIG_INIT_STACK_ALL_{ZERO,PATTERN} is
enabled, add_random_kstack_offset() will auto-init that unused portion
of the stack used to add an offset.

There are several problems with this:

	1. These offsets can be as large as 1023 bytes. Performing
	   memset() on them isn't exactly cheap, and this is done on
	   every syscall entry.

	2. Architectures adding add_random_kstack_offset() to syscall
	   entry implemented in C require them to be 'noinstr' (e.g. see
	   x86 and s390). The potential problem here is that a call to
	   memset may occur, which is not noinstr.

A x86_64 defconfig kernel with Clang 11 and CONFIG_VMLINUX_VALIDATION shows:

 | vmlinux.o: warning: objtool: do_syscall_64()+0x9d: call to memset() leaves .noinstr.text section
 | vmlinux.o: warning: objtool: do_int80_syscall_32()+0xab: call to memset() leaves .noinstr.text section
 | vmlinux.o: warning: objtool: __do_fast_syscall_32()+0xe2: call to memset() leaves .noinstr.text section
 | vmlinux.o: warning: objtool: fixup_bad_iret()+0x2f: call to memset() leaves .noinstr.text section

Clang 14 (unreleased) will introduce a way to skip alloca initialization
via __builtin_alloca_uninitialized() (https://reviews.llvm.org/D115440).

Constrain RANDOMIZE_KSTACK_OFFSET to only be enabled if no stack
auto-init is enabled, the compiler is GCC, or Clang is version 14+. Use
__builtin_alloca_uninitialized() if the compiler provides it, as is done
by Clang 14.

Link: https://lkml.kernel.org/r/YbHTKUjEejZCLyhX@elver.google.com
Fixes: 39218ff4c6 ("stack: Optionally randomize kernel stack offset each syscall")
Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220131090521.1947110-2-elver@google.com
2022-02-14 11:07:12 -08:00
..
2021-09-20 12:43:34 +01:00
2021-08-29 14:47:42 +03:00
2022-01-22 08:33:34 +02:00
2021-05-06 19:24:11 -07:00
2021-10-07 16:51:57 +02:00
2021-04-14 16:30:30 +03:00
2022-01-15 08:47:31 -08:00
2021-10-18 14:43:23 -06:00
2022-01-09 10:36:51 -07:00
2021-11-12 10:19:09 -08:00
2021-11-17 10:36:15 -05:00
2021-04-08 16:04:20 -07:00
2021-09-08 15:32:35 -07:00
2021-12-10 17:10:55 -08:00
2021-12-10 12:51:28 +01:00
2021-12-01 00:06:43 +01:00
2021-08-26 15:32:28 -04:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2021-04-12 15:04:23 +02:00
2022-01-15 08:47:31 -08:00
2022-01-22 08:33:38 +02:00
2021-06-25 19:57:01 -04:00
2021-07-26 15:09:44 +02:00
2022-01-20 08:52:54 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2021-10-18 07:49:38 -04:00
2022-01-04 13:15:33 -05:00
2021-08-05 11:46:42 +01:00
2021-12-17 09:06:15 +01:00
2021-12-20 09:03:05 +01:00
2021-10-05 06:54:16 -05:00
2021-07-27 17:05:06 +01:00
2021-06-01 10:29:21 +01:00
2021-10-18 07:49:39 -04:00
2021-06-17 13:09:27 -04:00
2021-06-15 17:46:57 +02:00
2021-09-30 12:46:44 -06:00
2021-07-01 11:06:05 -07:00
2021-12-16 22:22:20 +01:00
2021-08-23 13:19:12 +02:00
2021-09-21 13:44:55 -07:00
2022-01-12 10:14:09 -06:00
2021-11-16 19:07:53 -08:00
2021-09-17 13:52:17 +01:00
2021-09-27 09:27:29 -04:00
2022-01-15 16:30:28 +02:00
2021-09-27 17:00:21 +02:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2022-01-15 16:30:28 +02:00
2021-10-14 13:29:18 +02:00
2021-06-07 14:11:47 -07:00
2021-08-18 22:08:24 +02:00
2022-01-22 08:33:37 +02:00
2022-01-08 12:43:57 -06:00
2021-11-18 09:36:39 +01:00
2021-10-07 16:51:57 +02:00
2022-01-24 14:45:02 +01:00
2021-11-30 17:25:20 -08:00
2021-10-18 07:49:39 -04:00
2021-10-18 17:20:50 +02:00
2022-01-22 08:33:37 +02:00
2022-01-22 08:33:38 +02:00
2021-11-16 13:10:34 +00:00
2021-10-26 14:58:45 +01:00
2021-08-06 13:41:48 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2021-11-03 11:41:25 -07:00
2021-07-01 11:06:03 -07:00
2021-11-25 18:35:23 +01:00
2021-09-08 15:32:35 -07:00
2021-10-12 11:41:39 -03:00
2021-12-30 12:13:04 +01:00
2022-01-14 18:50:52 -05:00
2021-08-11 06:44:24 -04:00
2021-12-09 10:49:56 -08:00
2022-01-08 00:28:41 -05:00
2021-10-19 23:44:30 +08:00