Sara Sharon
efa40c7ef6
iwlwifi: mvm: fix suspicious rcu usage warnings
mvm mutex isn't held by iwl_mvm_set_aes_rx_seq or it caller.
iee80211_local->key_mtx is held, but that is internal to mac80211.
The same applies to iwl_mvm_wowlan_program_keys.
Just hold rcu_read_lock, even though we are protected, the penalty
isn't that bad.
Warnings fixed are:
[ 4143.788196] WARNING: suspicious RCU usage
[ 4143.788211] -----------------------------
[ 4143.788220] suspicious rcu_dereference_protected() usage!
[ 4143.788227]
[ 4143.788234] rcu_scheduler_active = 2, debug_locks = 1
[ 4143.788242] 5 locks held by kworker/u8:9/5921:
[ 4143.788331] #4: ffff88804e69ad08 (&local->key_mtx){+.+.}, at ie80211_iter_keys+0x46/0x380 [mac80211]
[ 4143.788441]
[ 4143.788441] Call Trace:
[ 4143.788455] dump_stack+0xc1/0x11a
[ 4143.788471] lockdep_rcu_suspicious+0x14a/0x153
[ 4143.788515] iwl_mvm_set_aes_rx_seq+0x4a9/0x570 [iwlmvm]
[ 4143.788657] iwl_mvm_d3_update_keys+0x2ac/0x600 [iwlmvm]
[ 4143.788784] ieee80211_iter_keys+0x10e/0x380 [mac80211]
[ 4143.788838] iwl_mvm_setup_connection_keep+0x287/0x8d0 [iwlmvm]
[ 7243.206556] WARNING: suspicious RCU usage
[ 7243.206811] -----------------------------
[ 7243.206926] /suspicious rcu_dereference_protected() usage!
[ 7243.207086]
[ 7243.207204] rcu_scheduler_active = 2, debug_locks = 1
[ 7243.207321] 2 locks held by cat/15952:
[ 7243.207564] #1: ffff888008c8ad08 (&local->key_mtx){+.+.}, at:
ieee80211_iter_keys+0x46/0x380 [mac80211]
[ 7243.207751]
[ 7243.208094] Call Trace:
[ 7243.208211] dump_stack+0xc1/0x11a
[ 7243.208355] lockdep_rcu_suspicious+0x14a/0x153
[ 7243.208509] iwl_mvm_wowlan_program_keys+0x1db7/0x2340 [iwlmvm]
[ 7243.209852] ieee80211_iter_keys+0x10e/0x380 [mac80211]
Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/iwlwifi.20201008181047.65872d5f1670.I0b2fb2a65904ae686c3c7c05f881a1e3634dc900@changeid
2020-10-08 20:14:53 +03:00
..
2020-08-26 10:50:50 -07:00
2020-09-16 19:36:26 +02:00
2020-07-29 17:05:44 +02:00
2020-09-04 13:19:19 -07:00
2020-09-28 16:03:30 -07:00
2020-09-05 14:22:46 -07:00
2020-09-13 09:02:59 -07:00
2020-10-01 16:23:50 +03:00
2020-10-02 19:11:11 -07:00
2020-09-27 23:44:50 +02:00
2020-08-23 17:36:59 -05:00
2020-07-08 16:20:01 -06:00
2020-08-30 15:53:44 -07:00
2020-09-10 13:42:35 -07:00
2020-09-20 10:51:11 -07:00
2020-09-21 13:48:29 -07:00
2020-08-22 11:38:42 +01:00
2020-09-01 21:15:00 +02:00
2020-09-18 11:48:25 -07:00
2020-09-11 17:26:39 -07:00
2020-09-20 08:57:36 -07:00
2020-07-30 17:22:58 +09:00
2020-09-04 12:12:39 -07:00
2020-09-03 17:47:02 +05:30
2020-09-15 09:42:15 +02:00
2020-08-23 17:36:59 -05:00
2020-09-20 15:18:11 -07:00
2020-07-27 11:49:37 +02:00
2020-08-23 17:36:59 -05:00
2020-09-18 08:52:06 +10:00
2020-07-29 16:58:08 +02:00
2020-09-02 12:55:46 -07:00
2020-08-23 17:36:59 -05:00
2020-09-15 16:20:43 -07:00
2020-08-29 12:37:00 -07:00
2020-07-13 22:29:28 -07:00
2020-08-23 17:36:59 -05:00
2020-09-18 23:11:44 +02:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-26 12:41:53 +02:00
2020-09-13 09:15:20 -07:00
2020-09-11 10:02:36 -07:00
2020-09-20 10:40:43 -07:00
2020-09-04 00:07:12 +03:00
2020-09-18 11:17:19 +02:00
2020-08-30 11:56:54 -07:00
2020-08-23 17:36:59 -05:00
2020-08-05 19:24:27 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-14 19:56:57 -07:00
2020-09-20 08:55:09 -07:00
2020-09-03 08:22:16 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-28 10:15:33 -07:00
2020-09-13 08:52:21 -07:00
2020-09-07 08:57:44 +02:00
2020-07-31 14:38:12 +02:00
2020-09-14 20:58:27 +05:30
2020-08-23 17:36:59 -05:00
2020-10-08 20:14:53 +03:00
2020-09-10 15:22:16 -07:00
2020-08-23 17:36:59 -05:00
2020-08-17 14:47:38 -06:00
2020-09-22 14:31:38 -07:00
2020-07-29 17:12:09 +02:00
2020-09-24 19:49:36 -07:00
2020-09-01 19:44:20 +02:00
2020-08-12 12:41:15 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-04 12:41:55 +02:00
2020-08-09 12:52:28 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-16 14:16:04 +02:00
2020-08-23 17:36:59 -05:00
2020-09-18 17:49:20 -07:00
2020-08-14 16:00:09 -07:00
2020-09-05 19:52:54 +03:00
2020-09-11 11:25:55 -07:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-10-02 16:22:49 -07:00
2020-09-15 16:30:20 -07:00
2020-08-14 19:56:57 -07:00
2020-08-23 17:36:59 -05:00
2020-09-03 14:10:19 +05:30
2020-09-11 11:35:55 -07:00
2020-09-21 16:01:35 +03:00
2020-09-13 09:15:20 -07:00
2020-10-02 19:11:11 -07:00
2020-07-13 15:11:44 +02:00
2020-10-02 19:11:11 -07:00
2020-09-15 13:52:14 +02:00
2020-09-16 13:23:33 +02:00
2020-07-10 13:42:33 +02:00
2020-09-17 18:45:30 +02:00
2020-08-26 08:13:59 -04:00
2020-08-23 17:36:59 -05:00
2020-09-03 18:50:48 -07:00
2020-09-20 10:46:26 -07:00
2020-07-10 13:45:32 +02:00
2020-08-14 19:56:57 -07:00
2020-08-23 17:36:59 -05:00
2020-09-06 09:59:27 -07:00