Files
linux/include/linux
Rasmus Villemoes ef4d6f6b27 include/linux/bitops.h: sanitize rotate primitives
The ror32 implementation (word >> shift) | (word << (32 - shift) has
undefined behaviour if shift is outside the [1, 31] range.  Similarly
for the 64 bit variants.  Most callers pass a compile-time constant
(naturally in that range), but there's an UBSAN report that these may
actually be called with a shift count of 0.

Instead of special-casing that, we can make them DTRT for all values of
shift while also avoiding UB.  For some reason, this was already partly
done for rol32 (which was well-defined for [0, 31]).  gcc 8 recognizes
these patterns as rotates, so for example

  __u32 rol32(__u32 word, unsigned int shift)
  {
	return (word << (shift & 31)) | (word >> ((-shift) & 31));
  }

compiles to

0000000000000020 <rol32>:
  20:   89 f8                   mov    %edi,%eax
  22:   89 f1                   mov    %esi,%ecx
  24:   d3 c0                   rol    %cl,%eax
  26:   c3                      retq

Older compilers unfortunately do not do as well, but this only affects
the small minority of users that don't pass constants.

Due to integer promotions, ro[lr]8 were already well-defined for shifts
in [0, 8], and ro[lr]16 were mostly well-defined for shifts in [0, 16]
(only mostly - u16 gets promoted to _signed_ int, so if bit 15 is set,
word << 16 is undefined).  For consistency, update those as well.

Link: http://lkml.kernel.org/r/20190410211906.2190-1-linux@rasmusvillemoes.dk
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reported-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-05-14 19:52:49 -07:00
..
2018-11-14 10:56:33 -08:00
2019-05-07 11:46:02 -07:00
2018-10-16 11:13:50 +02:00
2018-11-12 10:33:49 +01:00
2019-04-16 18:03:48 +02:00
2019-05-02 10:37:55 +09:00
2018-06-15 18:10:01 -03:00
2019-04-15 18:14:01 -04:00
2018-11-07 13:44:59 -07:00
2018-11-07 13:44:59 -07:00
2019-04-23 01:50:43 +02:00
2019-04-09 17:05:46 -07:00
2019-05-07 08:39:02 -06:00
2019-04-19 11:26:48 -07:00
2018-06-15 18:10:01 -03:00
2018-08-22 10:52:48 -07:00
2018-11-13 21:55:24 +01:00
2019-02-28 03:28:53 -05:00
2019-02-28 08:24:23 -07:00
2018-12-19 10:42:08 +01:00
2018-07-27 09:57:23 +10:00
2019-04-29 12:37:46 +02:00
2019-03-12 10:04:02 -07:00
2019-04-22 09:48:12 -06:00
2019-02-15 16:54:38 +01:00
2018-10-21 10:46:33 -04:00
2019-03-09 19:52:47 -08:00
2018-11-07 13:42:32 -07:00
2019-03-22 14:36:02 +01:00
2019-05-01 07:47:37 -07:00
2018-11-19 19:03:46 -07:00
2018-06-22 13:43:27 +09:00
2019-04-08 22:56:14 +02:00
2018-12-06 13:57:03 +01:00
2018-07-12 21:35:28 +02:00
2019-04-16 15:38:07 +02:00
2018-11-30 13:29:04 +00:00
2019-03-07 18:32:03 -08:00
2019-01-30 20:51:47 -05:00
2018-10-17 13:56:58 -07:00
2019-04-19 14:07:40 -07:00
2019-02-20 07:22:17 -07:00
2019-02-20 07:22:10 -07:00
2018-12-06 15:45:46 +01:00
2019-02-08 15:02:49 -08:00
2018-07-10 17:22:35 +02:00
2019-03-05 21:07:19 -08:00
2019-05-14 09:47:51 -07:00
2018-10-21 10:46:39 -04:00
2018-10-26 16:26:35 -07:00
2019-05-07 14:31:03 +02:00
2018-10-08 22:53:10 +11:00
2019-03-12 10:04:03 -07:00
2019-05-14 19:52:48 -07:00
2018-12-03 17:11:02 -08:00
2018-07-20 01:11:45 +02:00
2019-05-08 22:14:36 +02:00
2018-09-25 20:17:35 -07:00
2018-07-07 17:25:23 +02:00
2019-03-15 15:29:47 -07:00
2019-02-07 16:38:35 +01:00
2018-06-20 11:35:56 +02:00
2018-09-29 22:47:49 -04:00
2018-10-11 09:16:44 -07:00
2019-02-07 00:13:27 +01:00
2018-12-10 10:17:45 +01:00
2019-04-06 10:48:35 -06:00
2018-09-25 20:33:24 +02:00
2019-05-01 08:38:47 -06:00
2019-01-11 18:05:40 -08:00
2019-04-30 12:37:51 +02:00
2018-09-11 14:11:51 +02:00
2019-04-09 15:14:49 -06:00
2018-12-22 12:15:29 +01:00