Luis Henriques
eeca958dce
ceph: fix memory leak in __ceph_setxattr()
The ceph_inode_xattr needs to be released when removing an xattr. Easily
reproducible running the 'generic/020' test from xfstests or simply by
doing:
attr -s attr0 -V 0 /mnt/test && attr -r attr0 /mnt/test
While there, also fix the error path.
Here's the kmemleak splat:
unreferenced object 0xffff88001f86fbc0 (size 64):
comm "attr", pid 244, jiffies 4294904246 (age 98.464s)
hex dump (first 32 bytes):
40 fa 86 1f 00 88 ff ff 80 32 38 1f 00 88 ff ff @........28.....
00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................
backtrace:
[<ffffffff81560199>] kmemleak_alloc+0x49/0xa0
[<ffffffff810f3e5b>] kmem_cache_alloc+0x9b/0xf0
[<ffffffff812b157e>] __ceph_setxattr+0x17e/0x820
[<ffffffff812b1c57>] ceph_set_xattr_handler+0x37/0x40
[<ffffffff8111fb4b>] __vfs_removexattr+0x4b/0x60
[<ffffffff8111fd37>] vfs_removexattr+0x77/0xd0
[<ffffffff8111fdd1>] removexattr+0x41/0x60
[<ffffffff8111fe65>] path_removexattr+0x75/0xa0
[<ffffffff81120aeb>] SyS_lremovexattr+0xb/0x10
[<ffffffff81564b20>] entry_SYSCALL_64_fastpath+0x13/0x94
[<ffffffffffffffff>] 0xffffffffffffffff
Cc: stable@vger.kernel.org
Signed-off-by: Luis Henriques <lhenriques@suse.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2017-05-04 09:19:24 +02:00
..
2017-03-03 21:44:35 -08:00
2017-03-02 08:42:31 +01:00
2017-03-16 16:29:30 +00:00
2017-03-02 08:42:31 +01:00
2017-03-02 08:42:31 +01:00
2016-12-24 11:46:01 -08:00
2017-04-28 10:13:17 -07:00
2017-03-02 08:42:31 +01:00
2017-05-04 09:19:24 +02:00
2017-04-17 15:44:23 -05:00
2017-03-03 11:38:56 -08:00
2016-12-24 11:46:01 -08:00
2017-03-25 15:36:56 -07:00
2017-02-23 20:33:51 -08:00
2017-03-09 18:23:27 -08:00
2017-03-03 11:38:56 -08:00
2016-12-24 11:46:01 -08:00
2017-01-14 11:37:18 +01:00
2017-03-03 11:38:56 -08:00
2017-03-02 08:42:31 +01:00
2017-04-03 01:06:00 -04:00
2017-03-20 10:00:18 -04:00
2017-03-09 17:01:10 -08:00
2017-03-02 10:09:00 +11:00
2017-03-03 12:14:13 -08:00
2017-03-15 10:06:07 -04:00
2017-03-03 21:44:35 -08:00
2017-03-02 08:42:31 +01:00
2016-12-09 16:45:04 +01:00
2017-03-02 08:42:32 +01:00
2017-04-13 18:24:21 -07:00
2017-03-02 08:42:31 +01:00
2017-03-15 15:08:48 -04:00
2017-03-02 08:42:32 +01:00
2017-02-27 18:43:46 -08:00
2017-03-17 10:25:59 +09:00
2017-03-02 08:42:29 +01:00
2017-03-02 20:51:15 -05:00
2017-03-03 10:16:38 -08:00
2017-04-17 14:23:20 -04:00
2016-11-18 10:59:15 -05:00
2017-04-25 16:36:23 -04:00
2017-03-02 08:42:32 +01:00
2017-03-02 08:42:32 +01:00
2017-03-02 08:42:32 +01:00
2017-03-09 18:23:27 -08:00
2017-03-02 08:42:31 +01:00
2016-12-24 11:46:01 -08:00
2017-04-17 14:23:20 -04:00
2017-03-08 10:42:13 -08:00
2017-04-13 18:24:21 -07:00
2017-02-24 17:46:57 -08:00
2017-03-02 08:42:31 +01:00
2016-12-24 11:46:01 -08:00
2017-02-27 18:43:46 -08:00
2017-01-24 16:26:14 -08:00
2017-02-24 17:46:57 -08:00
2017-04-08 17:33:32 +02:00
2017-03-02 20:51:15 -05:00
2017-04-18 23:18:02 +02:00
2017-03-02 20:51:15 -05:00
2016-12-24 11:46:01 -08:00
2017-04-09 08:26:21 -07:00
2017-03-03 10:16:38 -08:00
2016-12-24 11:46:01 -08:00
2017-03-02 08:42:29 +01:00
2017-03-02 20:51:15 -05:00
2017-03-02 08:42:36 +01:00
2017-03-02 08:42:39 +01:00
2017-03-02 08:42:39 +01:00
2017-03-02 08:42:36 +01:00
2017-03-02 08:42:37 +01:00
2017-03-02 08:56:59 -07:00
2017-03-02 08:42:37 +01:00
2017-02-01 09:13:51 +01:00
2016-12-24 11:46:01 -08:00
2017-03-02 08:42:31 +01:00
2017-03-02 08:42:36 +01:00
2017-04-08 00:47:49 -07:00
2017-01-10 13:34:43 +13:00
2016-12-24 11:46:01 -08:00
2017-02-27 18:43:46 -08:00
2017-03-02 08:42:32 +01:00
2017-03-02 08:42:32 +01:00
2017-03-02 08:42:35 +01:00
2017-03-02 08:42:35 +01:00
2016-12-24 11:46:01 -08:00
2017-03-02 08:42:31 +01:00
2017-03-02 08:42:29 +01:00
2016-12-24 11:46:01 -08:00
2017-03-02 08:42:35 +01:00
2017-03-13 08:27:34 -06:00
2017-01-30 16:32:25 -08:00
2017-03-02 08:42:37 +01:00
2017-03-06 09:50:01 -08:00
2017-01-24 16:26:14 -08:00
2017-03-03 11:38:56 -08:00
2016-12-24 11:46:01 -08:00
2016-12-14 23:48:11 -05:00
2016-12-03 15:55:01 -05:00
2017-02-04 00:01:06 +13:00
2017-02-27 18:43:46 -08:00
2017-04-15 09:34:52 -07:00
2017-03-02 08:42:38 +01:00
2017-04-19 15:56:24 -07:00
2017-02-07 15:05:04 +01:00
2016-12-24 11:46:01 -08:00
2017-02-04 00:01:06 +13:00
2017-02-04 00:01:06 +13:00
2017-03-02 08:42:31 +01:00
2017-03-02 08:42:38 +01:00
2017-03-03 10:16:38 -08:00
2016-12-24 11:46:01 -08:00
2017-03-02 08:42:29 +01:00
2016-12-24 11:46:01 -08:00
2017-03-03 10:16:38 -08:00
2017-04-27 10:45:09 -07:00
2016-12-05 19:03:49 -05:00
2017-02-23 20:33:51 -08:00
2017-02-20 16:51:23 +01:00
2017-03-01 12:53:44 +01:00
2017-04-08 00:47:48 -07:00
2016-12-24 11:46:01 -08:00
2016-12-24 11:46:01 -08:00