Dan Carpenter
ee560e7bba
scsi: mpt3sas: Fix double free in attach error handling
The caller also calls _base_release_memory_pools() on error so it leads to
a number of double frees:
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->chain_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->hpr_lookup' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->internal_lookup' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->pcie_sgl_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_free_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_post_free_array_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_post_free_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->sense_dma_pool' double freed
Fixes: 74522a92bb ("scsi: mpt3sas: Optimize I/O memory consumption in driver.")
Link: https://lore.kernel.org/r/20191203093652.gyntgvnkw2udatyc@kili.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-12-16 21:48:52 -05:00
..
2019-12-04 10:56:35 -08:00
2019-12-01 13:46:15 -08:00
2019-12-03 13:58:22 -08:00
2019-12-04 19:44:12 -08:00
2019-12-05 11:43:31 -08:00
2019-12-07 14:49:20 -08:00
2019-11-22 13:35:20 +01:00
2019-12-06 08:26:50 -08:00
2019-11-26 13:02:24 -07:00
2019-12-06 10:28:09 -08:00
2019-12-05 11:38:40 -08:00
2019-12-03 12:20:25 -08:00
2019-12-06 08:28:13 -08:00
2019-11-29 11:49:32 +01:00
2019-12-02 17:23:21 -08:00
2019-12-01 18:43:25 -08:00
2019-11-29 12:50:34 +01:00
2019-11-22 11:16:26 +05:30
2019-12-01 13:46:15 -08:00
2019-11-22 10:18:29 +01:00
2019-11-27 10:53:50 -08:00
2019-12-02 14:13:00 -08:00
2019-12-06 14:19:37 -08:00
2019-12-04 19:44:14 -08:00
2019-12-06 10:28:09 -08:00
2019-12-01 18:20:54 -08:00
2019-12-01 20:36:41 -08:00
2019-12-01 13:46:15 -08:00
2019-12-01 13:46:15 -08:00
2019-12-01 18:29:36 -08:00
2019-12-01 13:46:15 -08:00
2019-11-29 11:48:39 +01:00
2019-12-03 14:37:12 -08:00
2019-12-04 12:27:13 -08:00
2019-12-07 18:33:01 -08:00
2019-12-03 13:58:22 -08:00
2019-12-03 13:58:22 -08:00
2019-12-01 13:46:15 -08:00
2019-12-01 16:09:28 -08:00
2019-11-30 14:35:43 -08:00
2019-12-01 18:42:02 -08:00
2019-12-03 08:51:25 -07:00
2019-12-01 13:46:15 -08:00
2019-12-06 08:28:51 -08:00
2019-12-03 13:58:22 -08:00
2019-12-03 14:37:12 -08:00
2019-12-04 19:44:13 -08:00
2019-11-27 11:06:20 -08:00
2019-12-03 14:09:14 -08:00
2019-12-08 13:28:11 -08:00
2019-11-22 16:27:24 -08:00
2019-12-07 18:38:17 -08:00
2019-12-01 18:43:25 -08:00
2019-12-03 13:58:22 -08:00
2019-12-05 11:43:31 -08:00
2019-12-02 11:41:35 -08:00
2019-11-25 19:40:40 -08:00
2019-11-13 19:09:49 +08:00
2019-12-03 13:58:22 -08:00
2019-11-22 07:03:45 +01:00
2019-12-05 11:43:31 -08:00
2019-12-03 09:29:50 -08:00
2019-12-03 14:37:12 -08:00
2019-12-04 10:48:09 -08:00
2019-11-16 21:51:42 -08:00
2019-12-05 11:28:14 -08:00
2019-12-04 19:44:13 -08:00
2019-11-22 19:56:20 +00:00
2019-11-18 20:35:16 -08:00
2019-12-05 11:43:31 -08:00
2019-12-01 18:39:24 -08:00
2019-12-03 13:31:08 -08:00
2019-12-08 13:28:11 -08:00
2019-12-16 21:48:52 -05:00
2019-12-06 14:19:37 -08:00
2019-11-22 19:56:35 +00:00
2019-12-03 13:58:22 -08:00
2019-12-02 13:37:02 -08:00
2019-12-05 13:18:54 -08:00
2019-12-05 11:21:24 -08:00
2019-11-19 17:35:57 +01:00
2019-12-03 14:09:14 -08:00
2019-11-14 11:49:48 +08:00
2019-12-04 19:44:14 -08:00
2019-12-07 14:51:04 -08:00
2019-12-08 13:28:11 -08:00
2019-12-03 13:58:22 -08:00
2019-12-01 13:46:15 -08:00
2019-11-20 02:15:57 -05:00
2019-11-14 13:06:33 +08:00
2019-12-01 18:01:03 -08:00
2019-12-07 14:49:20 -08:00