Xin Long
ecca8f88da
sctp: set frag_point in sctp_setsockopt_maxseg correctly
...
Now in sctp_setsockopt_maxseg user_frag or frag_point can be set with
val >= 8 and val <= SCTP_MAX_CHUNK_LEN. But both checks are incorrect.
val >= 8 means frag_point can even be less than SCTP_DEFAULT_MINSEGMENT.
Then in sctp_datamsg_from_user(), when it's value is greater than cookie
echo len and trying to bundle with cookie echo chunk, the first_len will
overflow.
The worse case is when it's value is equal as cookie echo len, first_len
becomes 0, it will go into a dead loop for fragment later on. In Hangbin
syzkaller testing env, oom was even triggered due to consecutive memory
allocation in that loop.
Besides, SCTP_MAX_CHUNK_LEN is the max size of the whole chunk, it should
deduct the data header for frag_point or user_frag check.
This patch does a proper check with SCTP_DEFAULT_MINSEGMENT subtracting
the sctphdr and datahdr, SCTP_MAX_CHUNK_LEN subtracting datahdr when
setting frag_point via sockopt. It also improves sctp_setsockopt_maxseg
codes.
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com >
Reported-by: Hangbin Liu <liuhangbin@gmail.com >
Signed-off-by: Xin Long <lucien.xin@gmail.com >
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-11-18 10:32:41 +09:00
..
2017-07-11 06:08:58 -04:00
2017-10-30 12:25:45 +02:00
2017-11-02 11:10:55 +01:00
2017-11-15 13:46:33 -08:00
2017-11-15 14:09:52 +09:00
2017-04-05 10:15:20 +02:00
2017-10-07 23:15:08 +01:00
2017-11-18 10:32:41 +09:00
2017-11-10 15:32:20 +09:00
2017-04-12 22:02:36 +02:00
2017-11-10 10:00:18 +09:00
2017-11-05 09:17:27 +09:00
2017-10-18 11:42:48 +01:00
2017-11-02 11:10:55 +01:00
2017-10-05 18:44:17 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-05-27 18:51:41 -04:00
2017-10-25 10:54:39 +09:00
2017-08-11 14:59:24 -07:00
2017-07-04 22:35:16 +01:00
2017-10-02 14:08:27 +02:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-06-25 12:19:35 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-31 14:42:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-04 09:26:51 +09:00
2017-11-13 10:34:54 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-08-22 14:29:30 -07:00
2017-11-02 11:10:55 +01:00
2017-11-01 11:50:43 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-11 15:36:05 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-30 21:09:24 +09:00
2017-10-11 09:49:34 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-16 10:49:00 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-01-25 16:00:33 +01:00
2017-07-04 01:29:04 -07:00
2017-11-02 11:10:55 +01:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:55 +01:00
2017-11-04 09:26:51 +09:00
2017-11-04 09:26:51 +09:00
2017-08-07 11:39:21 -07:00
2017-10-30 21:09:24 +09:00
2016-12-29 11:38:31 -05:00
2017-11-02 11:10:55 +01:00
2017-10-07 21:22:58 +01:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2017-09-29 06:19:32 +01:00
2017-11-04 09:26:51 +09:00
2017-11-07 10:32:44 +01:00
2017-08-21 17:06:42 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-11 22:09:40 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-08-17 19:36:23 -04:00
2016-10-13 12:05:26 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2017-07-04 22:35:15 +01:00
2017-11-02 11:10:55 +01:00
2017-09-21 11:42:00 +02:00
2016-07-08 13:23:12 +02:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-07-01 07:39:09 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-07-08 12:20:57 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2017-11-10 10:00:18 +09:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 11:39:21 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-20 13:21:36 +01:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-04 09:26:51 +09:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-11-09 20:40:06 -05:00
2017-08-25 17:10:23 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-14 16:18:36 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 10:37:11 +09:00
2017-11-10 13:41:40 +09:00
2017-11-15 19:48:42 +09:00
2017-11-11 15:36:05 +09:00
2017-11-15 13:54:18 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00