Kuniyuki Iwashima
17ce3e5949
bpf: Disable migration in nf_hook_run_bpf().
syzbot reported that the netfilter bpf prog can be called without
migration disabled in xmit path.
Then the assertion in __bpf_prog_run() fails, triggering the splat
below. [0]
Let's use bpf_prog_run_pin_on_cpu() in nf_hook_run_bpf().
[0]:
BUG: assuming non migratable context at ./include/linux/filter.h:703
in_atomic(): 0, irqs_disabled(): 0, migration_disabled() 0 pid: 5829, name: sshd-session
3 locks held by sshd-session/5829:
#0: ffff88807b4e4218 (sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1667 [inline]
#0: ffff88807b4e4218 (sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sendmsg+0x20/0x50 net/ipv4/tcp.c:1395
#1: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire include/linux/rcupdate.h:331 [inline]
#1: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: rcu_read_lock include/linux/rcupdate.h:841 [inline]
#1: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: __ip_queue_xmit+0x69/0x26c0 net/ipv4/ip_output.c:470
#2: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire include/linux/rcupdate.h:331 [inline]
#2: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: rcu_read_lock include/linux/rcupdate.h:841 [inline]
#2: ffffffff8e5c4e00 (rcu_read_lock){....}-{1:3}, at: nf_hook+0xb2/0x680 include/linux/netfilter.h:241
CPU: 0 UID: 0 PID: 5829 Comm: sshd-session Not tainted 6.16.0-rc6-syzkaller-00002-g155a3c003e55 #0 PREEMPT(full)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x16c/0x1f0 lib/dump_stack.c:120
__cant_migrate kernel/sched/core.c:8860 [inline]
__cant_migrate+0x1c7/0x250 kernel/sched/core.c:8834
__bpf_prog_run include/linux/filter.h:703 [inline]
bpf_prog_run include/linux/filter.h:725 [inline]
nf_hook_run_bpf+0x83/0x1e0 net/netfilter/nf_bpf_link.c:20
nf_hook_entry_hookfn include/linux/netfilter.h:157 [inline]
nf_hook_slow+0xbb/0x200 net/netfilter/core.c:623
nf_hook+0x370/0x680 include/linux/netfilter.h:272
NF_HOOK_COND include/linux/netfilter.h:305 [inline]
ip_output+0x1bc/0x2a0 net/ipv4/ip_output.c:433
dst_output include/net/dst.h:459 [inline]
ip_local_out net/ipv4/ip_output.c:129 [inline]
__ip_queue_xmit+0x1d7d/0x26c0 net/ipv4/ip_output.c:527
__tcp_transmit_skb+0x2686/0x3e90 net/ipv4/tcp_output.c:1479
tcp_transmit_skb net/ipv4/tcp_output.c:1497 [inline]
tcp_write_xmit+0x1274/0x84e0 net/ipv4/tcp_output.c:2838
__tcp_push_pending_frames+0xaf/0x390 net/ipv4/tcp_output.c:3021
tcp_push+0x225/0x700 net/ipv4/tcp.c:759
tcp_sendmsg_locked+0x1870/0x42b0 net/ipv4/tcp.c:1359
tcp_sendmsg+0x2e/0x50 net/ipv4/tcp.c:1396
inet_sendmsg+0xb9/0x140 net/ipv4/af_inet.c:851
sock_sendmsg_nosec net/socket.c:712 [inline]
__sock_sendmsg net/socket.c:727 [inline]
sock_write_iter+0x4aa/0x5b0 net/socket.c:1131
new_sync_write fs/read_write.c:593 [inline]
vfs_write+0x6c7/0x1150 fs/read_write.c:686
ksys_write+0x1f8/0x250 fs/read_write.c:738
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe7d365d407
Code: 48 89 fa 4c 89 df e8 38 aa 00 00 8b 93 08 03 00 00 59 5e 48 83 f8 fc 74 1a 5b c3 0f 1f 84 00 00 00 00 00 48 8b 44 24 10 0f 05 <5b> c3 0f 1f 80 00 00 00 00 83 e2 39 83 fa 08 75 de e8 23 ff ff ff
RSP:
Fixes: fd9c663b9a ("bpf: minimal support for programs hooked into netfilter framework")
Reported-by: syzbot+40f772d37250b6d10efc@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6879466d.a00a0220.3af5df.0022.GAE@google.com/
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Tested-by: syzbot+40f772d37250b6d10efc@syzkaller.appspotmail.com
Acked-by: Florian Westphal <fw@strlen.de>
Link: https://patch.msgid.link/20250722224041.112292-1-kuniyu@google.com
2025-07-23 18:58:03 -07:00
..
2025-06-08 09:07:37 +02:00
2025-07-02 14:32:29 -07:00
2025-05-23 13:57:12 +02:00
2025-07-03 13:51:39 +02:00
2025-07-03 13:51:39 +02:00
2025-07-23 18:58:03 -07:00
2025-03-12 15:28:33 +01:00
2022-02-04 06:30:28 +01:00
2025-01-19 16:41:55 +01:00
2024-05-22 15:00:56 -07:00
2025-01-19 16:41:55 +01:00
2025-07-17 11:00:33 -07:00
2025-01-09 14:42:16 +01:00
2025-06-08 09:07:37 +02:00
2023-09-13 21:57:50 +02:00
2022-09-20 23:50:03 +02:00
2024-03-07 03:10:35 +01:00
2025-01-19 16:41:55 +01:00
2019-06-19 17:09:52 +02:00
2023-10-10 16:34:28 +02:00
2022-09-07 15:55:23 +02:00
2023-10-24 13:16:30 +02:00
2022-01-11 10:41:44 +01:00
2025-07-03 13:51:39 +02:00
2023-03-08 14:25:41 +01:00
2022-07-11 16:25:15 +02:00
2019-06-19 17:09:55 +02:00
2023-07-05 14:42:15 +02:00
2021-06-18 14:47:43 +02:00
2024-05-06 11:13:56 +02:00
2025-01-12 20:21:01 -08:00
2024-10-02 17:23:23 -04:00
2023-02-01 12:18:51 +01:00
2025-07-03 13:51:39 +02:00
2022-08-11 16:50:25 +02:00
2022-02-04 06:30:28 +01:00
2025-01-19 16:41:55 +01:00
2019-05-30 11:26:32 -07:00
2025-07-03 13:51:39 +02:00
2019-07-16 13:16:59 +02:00
2022-07-11 16:25:15 +02:00
2022-02-04 06:30:28 +01:00
2025-05-23 13:57:12 +02:00
2024-07-01 17:03:01 +02:00
2025-04-17 11:14:22 +02:00
2024-09-12 15:41:03 +02:00
2025-02-12 10:35:20 +01:00
2025-03-06 12:59:43 -08:00
2022-07-11 16:25:14 +02:00
2024-07-01 17:01:53 +02:00
2024-07-24 20:59:29 +02:00
2024-06-19 18:41:59 +02:00
2025-03-17 13:49:46 +00:00
2024-07-24 20:59:29 +02:00
2022-09-07 16:46:04 +02:00
2024-01-31 20:40:56 -08:00
2025-07-03 13:51:39 +02:00
2022-09-07 16:46:04 +02:00
2022-11-18 02:15:15 +01:00
2022-09-07 16:46:04 +02:00
2022-05-13 18:56:27 +02:00
2024-01-03 11:17:17 +01:00
2025-07-03 13:51:39 +02:00
2023-11-08 16:40:30 +01:00
2022-09-07 16:46:04 +02:00
2019-07-16 13:16:59 +02:00
2024-02-21 12:03:22 +01:00
2020-07-24 15:41:54 -07:00
2024-10-02 17:23:23 -04:00
2025-07-17 11:00:33 -07:00
2025-03-23 10:53:47 +01:00
2025-05-23 13:57:13 +02:00
2025-07-14 15:22:35 +02:00
2021-05-29 01:04:53 +02:00
2022-07-11 16:25:15 +02:00
2025-07-03 13:51:39 +02:00
2023-04-21 11:34:14 -07:00
2025-06-08 09:07:37 +02:00
2023-11-08 13:52:32 +01:00
2025-03-23 10:20:33 +01:00
2025-07-14 15:22:47 +02:00
2024-11-15 12:07:04 +01:00
2024-10-02 17:23:23 -04:00
2025-07-14 15:22:47 +02:00
2023-11-08 13:52:32 +01:00
2021-05-29 01:04:54 +02:00
2024-08-20 12:37:24 +02:00
2025-03-06 13:35:54 +01:00
2024-05-10 11:13:45 +02:00
2024-09-03 10:47:16 +02:00
2023-05-03 13:49:08 +02:00
2025-03-03 13:46:49 +01:00
2024-08-20 12:37:24 +02:00
2024-09-03 18:19:44 +02:00
2025-07-03 13:51:39 +02:00
2022-03-20 00:29:47 +01:00
2022-03-20 00:29:47 +01:00
2024-09-03 10:47:17 +02:00
2025-05-23 13:57:12 +02:00
2024-09-03 10:47:17 +02:00
2024-08-20 12:37:24 +02:00
2024-09-03 10:47:17 +02:00
2025-05-23 13:57:12 +02:00
2024-05-10 11:13:45 +02:00
2024-05-10 11:13:45 +02:00
2024-09-26 13:03:02 +02:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2024-09-26 13:03:02 +02:00
2024-09-03 10:47:17 +02:00
2024-09-26 13:03:02 +02:00
2024-08-20 12:37:24 +02:00
2024-09-03 10:47:17 +02:00
2024-10-31 10:54:49 +01:00
2024-09-03 10:47:17 +02:00
2025-05-05 13:15:09 +02:00
2024-08-20 12:37:24 +02:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2024-11-05 22:06:22 +01:00
2025-04-02 22:50:56 +02:00
2025-06-05 10:49:58 +02:00
2021-05-29 01:04:27 +02:00
2025-05-05 13:17:32 +02:00
2024-07-17 19:00:47 +02:00
2025-01-19 16:41:41 +01:00
2024-11-28 13:14:24 +01:00
2024-09-03 10:47:17 +02:00
2024-09-03 10:47:17 +02:00
2025-05-23 13:57:12 +02:00
2024-12-05 10:01:28 +01:00
2024-02-21 12:03:22 +01:00
2024-10-30 13:17:36 +01:00
2024-10-09 23:20:46 +02:00
2021-06-01 23:53:51 +02:00
2021-08-17 00:45:07 +02:00
2025-04-24 16:04:02 +02:00
2024-10-09 23:20:46 +02:00
2024-10-09 23:20:46 +02:00
2024-10-09 23:20:46 +02:00
2019-05-21 10:50:45 +02:00
2024-10-09 23:20:46 +02:00
2019-06-19 17:09:55 +02:00
2024-10-09 23:20:46 +02:00
2024-10-09 23:20:46 +02:00
2024-10-09 23:20:46 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2024-10-09 23:20:46 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2025-03-12 16:37:48 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2025-06-08 09:07:37 +02:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2025-06-08 09:07:37 +02:00
2023-02-22 21:25:23 -08:00
2021-05-29 01:04:52 +02:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2025-05-22 17:16:02 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-12-01 09:45:29 +01:00
2024-10-21 11:31:26 +02:00
2019-06-19 17:09:55 +02:00
2023-06-20 22:43:42 +02:00
2023-12-06 17:52:15 +01:00
2024-01-17 12:02:48 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2024-10-09 23:20:46 +02:00
2019-06-19 17:09:55 +02:00
2024-06-28 17:57:50 +02:00
2023-03-22 21:48:59 +01:00
2025-03-23 10:53:47 +01:00
2023-08-30 17:34:01 +02:00
2024-10-09 23:20:46 +02:00
2019-08-13 12:14:26 +02:00
2023-07-29 18:13:41 +01:00
2019-06-19 17:09:55 +02:00
2022-10-11 17:42:58 -06:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2025-05-22 17:16:02 +02:00
2023-03-22 21:48:59 +01:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2022-07-21 00:56:00 +02:00
2024-10-21 11:31:26 +02:00
2023-08-30 17:34:01 +02:00