Eric Biggers
e8cfed5e4e
crypto: cipher - remove crt_u.cipher (struct cipher_tfm)
...
Of the three fields in crt_u.cipher (struct cipher_tfm), ->cit_setkey()
is pointless because it always points to setkey() in crypto/cipher.c.
->cit_decrypt_one() and ->cit_encrypt_one() are slightly less pointless,
since if the algorithm doesn't have an alignmask, they are set directly
to ->cia_encrypt() and ->cia_decrypt(). However, this "optimization"
isn't worthwhile because:
- The "cipher" algorithm type is the only algorithm still using crt_u,
so it's bloating every struct crypto_tfm for every algorithm type.
- If the algorithm has an alignmask, this "optimization" actually makes
things slower, as it causes 2 indirect calls per block rather than 1.
- It adds extra code complexity.
- Some templates already call ->cia_encrypt()/->cia_decrypt() directly
instead of going through ->cit_encrypt_one()/->cit_decrypt_one().
- The "cipher" algorithm type never gives optimal performance anyway.
For that, a higher-level type such as skcipher needs to be used.
Therefore, just remove the extra indirection, and make
crypto_cipher_setkey(), crypto_cipher_encrypt_one(), and
crypto_cipher_decrypt_one() be direct calls into crypto/cipher.c.
Also remove the unused function crypto_cipher_cast().
Signed-off-by: Eric Biggers <ebiggers@google.com >
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au >
2019-12-11 16:37:01 +08:00
..
2019-11-12 21:45:37 +02:00
2019-06-05 17:37:06 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:32 -07:00
2019-11-17 09:02:41 +08:00
2019-11-17 09:02:38 +08:00
2019-10-26 02:06:05 +11:00
2019-10-26 02:06:05 +11:00
2019-10-26 02:06:05 +11:00
2019-08-30 18:05:30 +10:00
2019-08-15 21:52:14 +10:00
2019-07-26 14:55:33 +10:00
2019-10-10 23:42:45 +11:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-11-17 09:02:49 +08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2018-05-26 09:16:44 +02:00
2019-10-05 01:04:31 +10:00
2019-05-24 17:27:12 +02:00
2019-06-13 14:31:39 +08:00
2019-12-11 16:37:01 +08:00
2019-07-08 20:57:08 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-11-22 18:48:35 +08:00
2019-11-17 09:02:42 +08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-21 11:28:45 +02:00
2019-05-30 11:25:16 -07:00
2019-12-11 16:36:54 +08:00
2019-05-24 17:27:12 +02:00
2019-05-30 11:26:32 -07:00
2019-06-18 08:52:34 +02:00
2019-04-18 22:15:03 +08:00
2019-07-08 20:57:08 -07:00
2019-11-22 18:48:39 +08:00
2019-12-11 16:37:01 +08:00
2019-05-30 11:26:32 -07:00
2019-12-11 16:37:01 +08:00
2019-04-18 22:15:03 +08:00
2019-05-30 11:26:32 -07:00
2013-09-12 15:31:34 +10:00
2019-04-18 22:15:03 +08:00
2019-11-01 13:38:32 +08:00
2019-11-17 09:02:49 +08:00
2019-07-08 20:57:08 -07:00
2019-10-10 23:42:45 +11:00
2019-11-01 13:38:32 +08:00
2019-05-30 11:26:32 -07:00
2019-04-18 22:15:03 +08:00
2019-11-17 09:02:43 +08:00
2019-07-08 20:57:08 -07:00
2019-08-22 14:57:33 +10:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-23 14:01:06 +08:00
2019-05-30 11:26:32 -07:00
2019-04-18 22:15:02 +08:00
2019-11-17 09:02:42 +08:00
2019-04-18 22:15:02 +08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-04-18 22:15:02 +08:00
2019-04-18 22:15:02 +08:00
2019-04-18 22:15:02 +08:00
2019-04-18 22:15:02 +08:00
2019-12-11 16:36:57 +08:00
2019-06-13 14:31:39 +08:00
2019-07-26 14:51:57 +10:00
2019-08-09 15:11:58 +10:00
2019-11-17 09:02:38 +08:00
2017-12-22 19:52:40 +11:00
2019-07-27 21:08:38 +10:00
2019-05-30 11:26:32 -07:00
2019-12-11 16:36:57 +08:00
2019-12-11 16:37:01 +08:00
2019-10-18 18:49:40 +11:00
2019-10-18 18:49:40 +11:00
2019-10-18 18:49:40 +11:00
2019-11-22 18:48:38 +08:00
2019-04-18 22:15:03 +08:00
2019-06-13 14:31:39 +08:00
2019-05-30 11:26:32 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-11-17 09:02:49 +08:00
2019-06-13 14:31:39 +08:00
2019-06-13 14:31:39 +08:00
2013-12-09 20:09:12 +08:00
2019-07-08 20:57:08 -07:00
2019-11-17 09:02:41 +08:00
2019-04-18 22:15:03 +08:00
2019-05-30 11:26:32 -07:00
2019-12-11 16:36:55 +08:00
2019-11-17 09:02:41 +08:00
2019-05-30 11:26:32 -07:00
2017-11-02 11:10:55 +01:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-07-08 20:57:08 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2016-07-05 23:05:26 +08:00
2015-10-14 22:23:16 +08:00
2019-04-18 22:15:03 +08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-12-11 16:36:54 +08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-09-05 14:54:54 +10:00
2019-05-24 17:27:12 +02:00
2019-12-11 16:36:57 +08:00
2019-05-21 11:28:45 +02:00
2019-12-11 16:36:56 +08:00
2019-06-19 17:09:07 +02:00
2019-04-18 22:15:03 +08:00
2019-08-15 21:52:14 +10:00
2019-11-17 09:02:44 +08:00
2019-05-30 11:26:32 -07:00
2019-07-08 20:57:08 -07:00
2019-12-11 16:37:01 +08:00
2019-12-11 16:37:01 +08:00
2019-11-15 13:44:17 +08:00
2019-05-21 11:28:45 +02:00
2019-05-21 11:28:45 +02:00
2019-04-18 22:15:03 +08:00
2019-06-13 14:31:39 +08:00
2019-05-21 11:28:45 +02:00
2019-05-24 17:27:13 +02:00
2019-08-15 21:52:14 +10:00
2019-06-06 14:38:57 +08:00
2019-07-08 20:57:08 -07:00