mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-29 17:30:01 -04:00
Fix the following dead_code warning on some configurations in an
atomic development branch:
warning: constant `WARN_ON_FLAGS` is never used
--> linux/rust/kernel/bug.rs:126:19
|
126 | const WARN_ON_FLAGS: u32 = $crate:🐛:bugflag_taint($crate::bindings::TAINT_WARN);
| ^^^^^^^^^^^^^
|
::: linux/rust/kernel/sync/srcu.rs:106:12
|
106 | if crate::warn_on!(
| ____________-
107 | | // SAFETY: By the type invariants, `self` contains a valid and pinned `struct srcu_struct`
108 | | // and `srcu_readers_active()` only checks the active reader count.
109 | | unsafe { bindings::srcu_readers_active(ptr) }
110 | | ) {
| |_________- in this macro invocation
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
= note: this warning originates in the macro `crate::warn_on` (in Nightly builds, run with -Z macro-backtrace for more info)
The warn_on! macro always defines a WARN_ON_FLAGS constant and hands it
to warn_flags!. On configurations where warn_flags! does not reference
its flags argument (the LOONGARCH/ARM variant, which only calls
WARN_ON(), and the !CONFIG_BUG no-op variant), the constant is left
unused and triggers a dead_code warning.
warn_flags! is the macro that accepts (and here discards) the flags
argument, so make it responsible for the argument it drops.
Also rename `_COND_STR` to `COND_STR` and consume `$file` for consistency.
Fixes: dff64b0727 ("rust: Add warn_on macro")
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260801024841.786664-1-tomo@flapping.org
[ Added newlines. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
151 lines
4.5 KiB
Rust
151 lines
4.5 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
// Copyright (C) 2024, 2025 FUJITA Tomonori <fujita.tomonori@gmail.com>
|
|
|
|
//! Support for BUG and WARN functionality.
|
|
//!
|
|
//! C header: [`include/asm-generic/bug.h`](srctree/include/asm-generic/bug.h)
|
|
|
|
#[macro_export]
|
|
#[doc(hidden)]
|
|
#[cfg(all(CONFIG_BUG, not(CONFIG_UML), not(CONFIG_LOONGARCH), not(CONFIG_ARM)))]
|
|
#[cfg(CONFIG_DEBUG_BUGVERBOSE)]
|
|
macro_rules! warn_flags {
|
|
($file:expr, $flags:expr) => {
|
|
const FLAGS: u32 = $crate::bindings::BUGFLAG_WARNING | $flags;
|
|
const _FILE: &[u8] = $file.as_bytes();
|
|
// Plus one for null-terminator.
|
|
static FILE: [u8; _FILE.len() + 1] = {
|
|
let mut bytes = [0; _FILE.len() + 1];
|
|
let mut i = 0;
|
|
while i < _FILE.len() {
|
|
bytes[i] = _FILE[i];
|
|
i += 1;
|
|
}
|
|
bytes
|
|
};
|
|
|
|
// SAFETY:
|
|
// - `file`, `line`, `flags`, and `size` are all compile-time constants or
|
|
// symbols, preventing any invalid memory access.
|
|
// - The asm block has no side effects and does not modify any registers
|
|
// or memory. It is purely for embedding metadata into the ELF section.
|
|
unsafe {
|
|
$crate::asm!(
|
|
concat!(
|
|
"/* {size} */",
|
|
include!(concat!(env!("OBJTREE"), "/rust/kernel/generated_arch_warn_asm.rs")),
|
|
include!(concat!(env!("OBJTREE"), "/rust/kernel/generated_arch_reachable_asm.rs")));
|
|
file = sym FILE,
|
|
line = const line!(),
|
|
flags = const FLAGS,
|
|
size = const ::core::mem::size_of::<$crate::bindings::bug_entry>(),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
#[macro_export]
|
|
#[doc(hidden)]
|
|
#[cfg(all(CONFIG_BUG, not(CONFIG_UML), not(CONFIG_LOONGARCH), not(CONFIG_ARM)))]
|
|
#[cfg(not(CONFIG_DEBUG_BUGVERBOSE))]
|
|
macro_rules! warn_flags {
|
|
($file:expr, $flags:expr) => {
|
|
const FLAGS: u32 = $crate::bindings::BUGFLAG_WARNING | $flags;
|
|
|
|
if false {
|
|
_ = $file;
|
|
}
|
|
|
|
// SAFETY:
|
|
// - `flags` and `size` are all compile-time constants, preventing
|
|
// any invalid memory access.
|
|
// - The asm block has no side effects and does not modify any registers
|
|
// or memory. It is purely for embedding metadata into the ELF section.
|
|
unsafe {
|
|
$crate::asm!(
|
|
concat!(
|
|
"/* {size} */",
|
|
include!(concat!(env!("OBJTREE"), "/rust/kernel/generated_arch_warn_asm.rs")),
|
|
include!(concat!(env!("OBJTREE"), "/rust/kernel/generated_arch_reachable_asm.rs")));
|
|
flags = const FLAGS,
|
|
size = const ::core::mem::size_of::<$crate::bindings::bug_entry>(),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
#[macro_export]
|
|
#[doc(hidden)]
|
|
#[cfg(all(CONFIG_BUG, CONFIG_UML))]
|
|
macro_rules! warn_flags {
|
|
($file:expr, $flags:expr) => {
|
|
if false {
|
|
_ = $file;
|
|
}
|
|
|
|
// SAFETY: It is always safe to call `warn_slowpath_fmt()`
|
|
// with a valid null-terminated string.
|
|
unsafe {
|
|
$crate::bindings::warn_slowpath_fmt(
|
|
$crate::c_str!(::core::file!()).as_char_ptr(),
|
|
line!() as $crate::ffi::c_int,
|
|
$flags as $crate::ffi::c_uint,
|
|
::core::ptr::null(),
|
|
);
|
|
}
|
|
};
|
|
}
|
|
|
|
#[macro_export]
|
|
#[doc(hidden)]
|
|
#[cfg(all(CONFIG_BUG, any(CONFIG_LOONGARCH, CONFIG_ARM)))]
|
|
macro_rules! warn_flags {
|
|
($file:expr, $flags:expr) => {
|
|
if false {
|
|
_ = $file;
|
|
_ = $flags;
|
|
}
|
|
|
|
// SAFETY: It is always safe to call `WARN_ON()`.
|
|
unsafe { $crate::bindings::WARN_ON(true) }
|
|
};
|
|
}
|
|
|
|
#[macro_export]
|
|
#[doc(hidden)]
|
|
#[cfg(not(CONFIG_BUG))]
|
|
macro_rules! warn_flags {
|
|
($file:expr, $flags:expr) => {
|
|
if false {
|
|
_ = $file;
|
|
_ = $flags;
|
|
}
|
|
};
|
|
}
|
|
|
|
#[doc(hidden)]
|
|
pub const fn bugflag_taint(value: u32) -> u32 {
|
|
value << 8
|
|
}
|
|
|
|
/// Report a warning if `cond` is true and return the condition's evaluation result.
|
|
#[macro_export]
|
|
macro_rules! warn_on {
|
|
($cond:expr) => {{
|
|
let cond = $cond;
|
|
|
|
#[cfg(CONFIG_DEBUG_BUGVERBOSE_DETAILED)]
|
|
const COND_STR: &str = concat!("[", stringify!($cond), "] ", file!());
|
|
#[cfg(not(CONFIG_DEBUG_BUGVERBOSE_DETAILED))]
|
|
const COND_STR: &str = file!();
|
|
|
|
if cond {
|
|
const WARN_ON_FLAGS: u32 = $crate::bug::bugflag_taint($crate::bindings::TAINT_WARN);
|
|
|
|
$crate::warn_flags!(COND_STR, WARN_ON_FLAGS);
|
|
}
|
|
cond
|
|
}};
|
|
}
|