Files
linux/fs
Matthew Wilcox (Oracle) bcd30d4cd9 buffer: fix unintended successful return
If try_to_free_buffers() succeeded and then folio_alloc_buffers() failed,
grow_dev_folio() would return success.  This would be incorrect; memory
allocation failure is supposed to result in a failure.  It's a harmless
bug; the caller will simply go around the loop one more time and
grow_dev_folio() will correctly return a failure that time.  But it was an
unintended change and looks like a more serious bug than it is.

While I'm in here, improve the commentary about why we return success even
though we failed.

Link: https://lkml.kernel.org/r/20240101093848.2017115-1-willy@infradead.org
Fixes: 6d840a1877 ("buffer: return bool from grow_dev_folio()")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reported-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-01-05 10:17:43 -08:00
..
2023-12-29 11:58:34 -08:00
2023-11-03 22:24:11 +09:00
2023-12-29 11:58:34 -08:00
2023-08-31 12:07:34 -05:00
2023-12-29 11:58:35 -08:00
2023-05-17 09:16:59 +02:00
2023-08-21 13:46:25 -07:00
2023-10-19 11:02:47 +02:00
2023-08-19 12:12:12 +02:00
2023-10-22 17:08:07 -04:00
2023-05-19 04:30:22 +02:00
2023-05-19 04:30:22 +02:00
2023-08-15 08:32:45 +02:00
2023-12-29 11:58:24 -08:00