Files
linux/drivers/gpu/drm/xe
Lucas De Marchi a9ab6591b4 drm/xe: Fix and re-enable xe_print_blob_ascii85()
Commit 70fb86a85d ("drm/xe: Revert some changes that break a mesa
debug tool") partially reverted some changes to workaround breakage
caused to mesa tools. However, in doing so it also broke fetching the
GuC log via debugfs since xe_print_blob_ascii85() simply bails out.

The fix is to avoid the extra newlines: the devcoredump interface is
line-oriented and adding random newlines in the middle breaks it. If a
tool is able to parse it by looking at the data and checking for chars
that are out of the ascii85 space, it can still do so. A format change
that breaks the line-oriented output on devcoredump however needs better
coordination with existing tools.

v2: Add suffix description comment
v3: Reword explanation of xe_print_blob_ascii85() calling drm_puts()
    in a loop

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: stable@vger.kernel.org
Fixes: 70fb86a85d ("drm/xe: Revert some changes that break a mesa debug tool")
Fixes: ec1455ce7e ("drm/xe/devcoredump: Add ASCII85 dump helper function")
Link: https://patchwork.freedesktop.org/patch/msgid/20250123202307.95103-2-jose.souza@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit 2c95bbf500)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2025-02-03 12:56:52 -05:00
..
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2024-05-09 21:28:25 +02:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2024-11-15 15:59:51 -08:00
2024-11-15 15:59:51 -08:00
2024-11-15 15:59:51 -08:00
2024-05-13 21:36:50 +02:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2024-11-15 15:59:51 -08:00
2025-01-09 17:58:09 +01:00
2024-05-22 12:03:55 +02:00
2024-12-05 07:37:53 -08:00
2024-09-19 10:15:40 +02:00
2025-01-09 17:58:09 +01:00
2024-05-07 12:03:49 +02:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2024-05-13 21:36:52 +02:00
2024-06-18 12:03:29 -07:00
2025-01-09 17:58:09 +01:00
2025-01-09 17:58:09 +01:00
2024-07-18 10:25:33 -04:00
2024-07-18 10:25:33 -04:00
2024-12-02 15:03:58 -05:00
2024-12-09 09:59:47 -05:00
2024-12-03 15:02:55 -05:00
2024-11-27 05:36:55 -05:00
2024-07-24 09:05:37 -07:00