Files
linux/include/linux
Stanislav Fomichev 04efcee6ef net: hold instance lock during NETDEV_CHANGE
Cosmin reports an issue with ipv6_add_dev being called from
NETDEV_CHANGE notifier:

[ 3455.008776]  ? ipv6_add_dev+0x370/0x620
[ 3455.010097]  ipv6_find_idev+0x96/0xe0
[ 3455.010725]  addrconf_add_dev+0x1e/0xa0
[ 3455.011382]  addrconf_init_auto_addrs+0xb0/0x720
[ 3455.013537]  addrconf_notify+0x35f/0x8d0
[ 3455.014214]  notifier_call_chain+0x38/0xf0
[ 3455.014903]  netdev_state_change+0x65/0x90
[ 3455.015586]  linkwatch_do_dev+0x5a/0x70
[ 3455.016238]  rtnl_getlink+0x241/0x3e0
[ 3455.019046]  rtnetlink_rcv_msg+0x177/0x5e0

Similarly, linkwatch might get to ipv6_add_dev without ops lock:
[ 3456.656261]  ? ipv6_add_dev+0x370/0x620
[ 3456.660039]  ipv6_find_idev+0x96/0xe0
[ 3456.660445]  addrconf_add_dev+0x1e/0xa0
[ 3456.660861]  addrconf_init_auto_addrs+0xb0/0x720
[ 3456.661803]  addrconf_notify+0x35f/0x8d0
[ 3456.662236]  notifier_call_chain+0x38/0xf0
[ 3456.662676]  netdev_state_change+0x65/0x90
[ 3456.663112]  linkwatch_do_dev+0x5a/0x70
[ 3456.663529]  __linkwatch_run_queue+0xeb/0x200
[ 3456.663990]  linkwatch_event+0x21/0x30
[ 3456.664399]  process_one_work+0x211/0x610
[ 3456.664828]  worker_thread+0x1cc/0x380
[ 3456.665691]  kthread+0xf4/0x210

Reclassify NETDEV_CHANGE as a notifier that consistently runs under the
instance lock.

Link: https://lore.kernel.org/netdev/aac073de8beec3e531c86c101b274d434741c28e.camel@nvidia.com/
Reported-by: Cosmin Ratiu <cratiu@nvidia.com>
Tested-by: Cosmin Ratiu <cratiu@nvidia.com>
Fixes: ad7c7b2172 ("net: hold netdev instance lock during sysfs operations")
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250404161122.3907628-1-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-04-07 11:13:39 -07:00
..
2025-03-21 09:46:08 +01:00
2025-03-06 09:25:06 +01:00
2024-10-11 14:34:11 -04:00
2024-10-13 17:16:57 +02:00
2025-03-21 20:57:55 -03:00
2025-03-13 14:15:54 +00:00
2024-10-14 23:27:57 +05:30
2025-02-21 17:31:45 -06:00
2025-02-21 09:54:01 +01:00
2024-11-11 10:45:03 +01:00
2024-10-09 15:42:48 +01:00
2024-10-14 18:33:04 -07:00
2025-04-02 07:06:59 -06:00
2025-03-08 14:37:39 +01:00
2025-02-26 12:10:48 +01:00
2025-02-06 11:27:16 -07:00
2025-03-20 17:33:31 -04:00
2025-03-17 22:06:41 -07:00
2024-11-05 13:32:21 +01:00
2025-02-24 12:08:51 +02:00
2025-03-20 09:45:39 +01:00
2024-11-28 14:49:28 +01:00
2025-01-07 18:06:51 -08:00
2024-11-24 17:05:27 -08:00
2025-03-10 13:13:04 -07:00
2024-10-16 21:56:59 +02:00
2025-03-22 15:36:49 +02:00
2024-11-05 16:56:26 -08:00
2025-01-14 19:45:35 +01:00
2024-12-13 08:49:31 -07:00
2025-03-08 12:13:25 +01:00
2024-12-09 13:48:23 -08:00
2024-10-14 16:33:24 -05:00
2025-02-20 15:24:13 +01:00
2025-02-07 23:15:01 +05:30
2025-02-07 16:53:04 +01:00
2025-01-15 15:07:23 -08:00
2025-02-10 10:41:00 +01:00
2025-03-17 13:54:50 +00:00
2024-09-23 15:03:30 -04:00
2025-02-18 11:51:22 -05:00
2024-11-05 16:56:26 -08:00
2025-03-06 15:13:13 -04:00
2024-11-16 10:09:30 -06:00
2025-03-27 13:14:46 -05:00
2025-03-08 15:08:45 -06:00
2024-10-02 16:23:10 -05:00
2025-03-27 13:14:45 -05:00
2025-03-10 08:53:40 +01:00
2025-03-12 20:41:14 +01:00
2025-01-10 11:59:00 +01:00
2025-01-07 15:16:48 +01:00
2025-03-16 17:40:22 -07:00
2025-01-02 10:37:14 -06:00
2024-12-09 14:44:59 -08:00
2025-03-17 11:52:25 +01:00
2024-09-11 20:44:31 -07:00
2025-01-29 13:32:23 -08:00
2025-01-29 09:04:28 -08:00
2025-02-28 11:51:26 -08:00
2024-10-02 16:53:38 +02:00
2025-03-20 08:00:50 -07:00
2025-02-28 11:51:26 -08:00
2025-03-25 09:15:07 -07:00
2025-02-12 12:12:27 +01:00
2025-02-28 11:51:26 -08:00
2024-12-09 14:44:59 -08:00
2024-11-06 12:59:44 -05:00
2025-03-13 13:25:58 -07:00
2025-03-13 13:25:58 -07:00
2025-03-13 13:25:58 -07:00