mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-07-25 09:41:09 -04:00
While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. The mentioned robustness is relevant for a planned change to struct i2c_device_id that replaces .driver_data by an anonymous union. This patch doesn't modify the compiled arrays, only their representation in source form benefits. The former was confirmed with x86 and arm64 builds. Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com> Link: https://patch.msgid.link/20260515164848.497608-2-u.kleine-koenig@baylibre.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
74 lines
1.6 KiB
C
74 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* TSC2004 touchscreen driver
|
|
*
|
|
* Copyright (C) 2015 QWERTY Embedded Design
|
|
* Copyright (C) 2015 EMAC Inc.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/input.h>
|
|
#include <linux/of.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/regmap.h>
|
|
#include "tsc200x-core.h"
|
|
|
|
static const struct input_id tsc2004_input_id = {
|
|
.bustype = BUS_I2C,
|
|
.product = 2004,
|
|
};
|
|
|
|
static int tsc2004_cmd(struct device *dev, u8 cmd)
|
|
{
|
|
u8 tx = TSC200X_CMD | TSC200X_CMD_12BIT | cmd;
|
|
s32 data;
|
|
struct i2c_client *i2c = to_i2c_client(dev);
|
|
|
|
data = i2c_smbus_write_byte(i2c, tx);
|
|
if (data < 0) {
|
|
dev_err(dev, "%s: failed, command: %x i2c error: %d\n",
|
|
__func__, cmd, data);
|
|
return data;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int tsc2004_probe(struct i2c_client *i2c)
|
|
|
|
{
|
|
return tsc200x_probe(&i2c->dev, i2c->irq, &tsc2004_input_id,
|
|
devm_regmap_init_i2c(i2c, &tsc200x_regmap_config),
|
|
tsc2004_cmd);
|
|
}
|
|
|
|
static const struct i2c_device_id tsc2004_idtable[] = {
|
|
{ .name = "tsc2004" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, tsc2004_idtable);
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id tsc2004_of_match[] = {
|
|
{ .compatible = "ti,tsc2004" },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tsc2004_of_match);
|
|
#endif
|
|
|
|
static struct i2c_driver tsc2004_driver = {
|
|
.driver = {
|
|
.name = "tsc2004",
|
|
.dev_groups = tsc200x_groups,
|
|
.of_match_table = of_match_ptr(tsc2004_of_match),
|
|
.pm = pm_sleep_ptr(&tsc200x_pm_ops),
|
|
},
|
|
.id_table = tsc2004_idtable,
|
|
.probe = tsc2004_probe,
|
|
};
|
|
module_i2c_driver(tsc2004_driver);
|
|
|
|
MODULE_AUTHOR("Michael Welling <mwelling@ieee.org>");
|
|
MODULE_DESCRIPTION("TSC2004 Touchscreen Driver");
|
|
MODULE_LICENSE("GPL");
|