Hans de Goede
e298d8a38b
leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value
...
led_blink_set[_oneshot]()'s delay_on and delay_off function parameters
are pass by reference, so that hw-blink implementations can report
back the actual achieved delays when the values have been rounded
to something the hw supports.
This is really only interesting for the sysfs API / the timer trigger.
Other triggers don't really care about this and none of the callers of
led_trigger_blink[_oneshot]() do anything with the returned delay values.
Change the led_trigger_blink[_oneshot]() delay parameters to pass-by-value,
there are 2 reasons for this:
1. led_cdev->blink_set() may sleep, while led_trigger_blink() may not.
So on hw where led_cdev->blink_set() sleeps the call needs to be deferred
to a workqueue, in which case the actual achieved delays are unknown
(this is a preparation patch for the deferring).
2. Since the callers don't care about the actual achieved delays, allowing
callers to directly pass a value leads to simpler code for most callers.
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com >
Tested-by: Yauhen Kharuzhy <jekhor@gmail.com >
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com >
Acked-by: Florian Westphal <fw@strlen.de >
Link: https://lore.kernel.org/r/20230510162234.291439-2-hdegoede@redhat.com
Signed-off-by: Lee Jones <lee@kernel.org >
2023-05-25 12:16:27 +01:00
..
2023-01-25 22:39:56 -08:00
2023-04-22 01:39:41 +02:00
2023-04-21 11:34:14 -07:00
2023-04-21 11:34:14 -07:00
2023-04-21 11:34:14 -07:00
2023-04-21 11:34:50 -07:00
2022-05-16 13:05:40 +02:00
2022-02-04 06:30:28 +01:00
2019-07-16 13:16:59 +02:00
2023-04-26 10:17:46 +02:00
2022-07-11 16:25:15 +02:00
2023-04-26 10:17:46 +02:00
2023-02-22 00:28:47 +01:00
2022-01-09 23:30:13 +01:00
2022-05-13 18:52:16 +02:00
2022-09-20 23:50:03 +02:00
2020-07-22 01:18:05 +02:00
2022-08-11 16:50:49 +02:00
2019-06-19 17:09:52 +02:00
2023-02-10 16:23:03 -08:00
2022-09-07 15:55:23 +02:00
2022-02-04 06:30:28 +01:00
2022-01-11 10:41:44 +01:00
2023-04-26 10:17:46 +02:00
2023-03-08 14:25:41 +01:00
2022-07-11 16:25:15 +02:00
2021-06-18 14:47:43 +02:00
2019-06-19 17:09:55 +02:00
2021-07-02 02:07:01 +02:00
2021-06-18 14:47:43 +02:00
2022-11-30 23:01:20 +01:00
2023-02-02 14:49:55 -08:00
2023-02-17 13:04:56 +01:00
2023-02-01 12:18:51 +01:00
2023-01-18 13:05:24 +01:00
2022-08-11 16:50:25 +02:00
2022-02-04 06:30:28 +01:00
2022-09-07 15:06:26 +02:00
2019-05-30 11:26:32 -07:00
2023-02-01 12:18:52 +01:00
2019-07-16 13:16:59 +02:00
2022-07-11 16:25:15 +02:00
2022-02-04 06:30:28 +01:00
2022-06-21 10:50:41 +02:00
2023-02-03 09:31:24 +00:00
2023-02-03 09:31:24 +00:00
2022-12-08 22:11:00 +01:00
2023-02-03 09:31:24 +00:00
2022-07-11 16:25:14 +02:00
2021-08-30 01:51:36 +02:00
2020-05-27 22:20:34 +02:00
2023-02-01 20:54:27 -08:00
2022-09-07 16:46:03 +02:00
2022-09-07 16:46:04 +02:00
2023-02-02 00:25:14 +01:00
2023-03-08 14:25:44 +01:00
2022-09-07 16:46:04 +02:00
2022-11-18 02:15:15 +01:00
2022-09-07 16:46:04 +02:00
2022-05-13 18:56:27 +02:00
2022-12-12 10:14:03 +00:00
2021-04-26 03:20:07 +02:00
2023-03-22 21:48:59 +01:00
2022-09-07 16:46:04 +02:00
2019-07-16 13:16:59 +02:00
2022-03-01 11:51:15 +01:00
2020-07-24 15:41:54 -07:00
2022-07-15 11:49:55 +01:00
2023-05-03 08:24:32 +02:00
2023-04-22 01:39:41 +02:00
2022-06-06 19:19:15 +02:00
2023-04-22 01:39:41 +02:00
2021-05-29 01:04:53 +02:00
2022-07-11 16:25:15 +02:00
2022-06-17 23:31:20 +02:00
2023-04-21 11:34:14 -07:00
2023-03-30 22:20:09 +02:00
2022-09-07 15:55:28 +02:00
2023-03-30 22:20:09 +02:00
2023-04-22 01:39:40 +02:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2021-10-22 11:41:16 +01:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:54 +02:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:53:17 +01:00
2023-05-03 13:49:08 +02:00
2023-01-18 13:05:25 +01:00
2022-11-15 10:46:34 +01:00
2023-05-03 08:24:32 +02:00
2022-11-17 21:43:34 -08:00
2022-03-20 00:29:47 +01:00
2022-03-20 00:29:47 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:53:17 +01:00
2023-03-01 17:23:23 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2023-05-03 08:24:32 +02:00
2023-03-22 21:48:59 +01:00
2022-11-15 10:46:34 +01:00
2023-03-08 12:25:59 +01:00
2022-11-15 10:46:34 +01:00
2023-05-03 08:24:32 +02:00
2022-11-15 10:46:34 +01:00
2023-01-11 19:18:04 +01:00
2022-11-15 10:46:34 +01:00
2023-03-01 17:23:23 +01:00
2022-11-15 10:46:34 +01:00
2023-03-22 21:48:59 +01:00
2022-03-20 00:29:46 +01:00
2022-03-20 00:29:46 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-07-11 16:40:37 +02:00
2022-06-27 19:03:37 +02:00
2021-12-24 16:58:17 +01:00
2021-05-29 01:04:27 +02:00
2022-11-28 13:17:11 +01:00
2021-05-29 01:04:27 +02:00
2023-01-23 21:38:33 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:46:34 +01:00
2023-03-08 14:25:40 +01:00
2022-09-07 16:46:03 +02:00
2019-06-19 17:09:55 +02:00
2021-06-01 23:53:51 +02:00
2021-08-17 00:45:07 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2018-02-14 21:05:38 +01:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2022-11-18 15:21:00 +01:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:25:15 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-01-22 08:33:37 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2023-03-17 15:16:33 +01:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2023-05-25 12:16:27 +01:00
2023-02-22 21:25:23 -08:00
2021-05-29 01:04:52 +02:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-12-01 09:45:29 +01:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 11:28:45 +02:00
2019-06-25 01:32:59 +02:00
2019-09-13 12:32:48 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2022-09-07 16:46:03 +02:00
2019-06-19 17:09:55 +02:00
2022-01-22 08:33:37 +02:00
2023-03-22 21:48:59 +01:00
2017-11-02 11:10:55 +01:00
2022-11-17 21:43:34 -08:00
2021-05-03 23:02:44 +02:00
2019-08-13 12:14:26 +02:00
2022-02-13 23:55:48 +01:00
2019-06-19 17:09:55 +02:00
2022-10-11 17:42:58 -06:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2019-06-22 08:59:24 -04:00
2023-03-22 21:48:59 +01:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2022-07-21 00:56:00 +02:00
2021-03-31 22:34:10 +02:00
2019-05-21 10:50:45 +02:00