P Praneesh dd21d1844a
wifi: cfg80211: Fragment per-link station stats in nl80211_dump_station() ...
In MLO scenarios, stations may have multiple links, each with distinct
statistics. When userspace tools like iw or hostapd request station dumps,
attempting to pack all per-link stats into a single netlink message can
easily exceed the default 4KB buffer limit, especially when more than two
links are active. This results in -EMSGSIZE errors and incomplete data
delivery.
To address this, fragment per-link station statistics across multiple
netlink messages to ensure reliable delivery of complete MLO station
information. Extend the stateful context with a two-phase dump mechanism:
phase 0 (AGGREGATED) sends combined MLO-level statistics and phase 1
(PER_LINK) sends individual per-link statistics for each active link.
The dump loop is structured to produce exactly one netlink message per
iteration, with a common header (ifindex, wdev, mac, generation) built
once and phase-specific payload added via a switch statement. This keeps
header construction in one place and makes the EMSGSIZE bail-out uniform.
Add a new request flag attribute, NL80211_ATTR_STA_DUMP_LINK_STATS
(NLA_FLAG), for NL80211_CMD_GET_STATION dump. Userspace can set this
flag to request per-link station statistics for MLO stations.
Extract this flag during the first dump invocation by passing an attrbuf
to nl80211_prepare_wdev_dump(); use __free(kfree) to avoid scattered
manual kfree() calls. Cache the boolean in the dump context to avoid
repeated parsing on subsequent invocations.
Per-link messages carry a single NL80211_ATTR_MLO_LINKS nest with the
link ID, link-specific MAC, and per-link NL80211_ATTR_STA_INFO payload.
The link-specific validity (is_valid_ether_addr) and null pointer guard
are checked in nl80211_put_link_station_payload() before any message
construction begins.
Also fix all nla_nest_start_noflag() calls in nl80211_fill_link_station()
for nested attribute types (STA_INFO, BSS_PARAM, TID_STATS, per-tid) to
use nla_nest_start() so the NLA_F_NESTED flag is set correctly.
Propagate the actual return value from nl80211_put_sta_info_common() in
the AGGREGATED phase rather than returning skb->len. Returning skb->len
signals netlink to re-invoke the dump with the same sta_idx, causing an
infinite loop when the aggregated payload is too large to fit; returning
the real error code (-EMSGSIZE or otherwise) terminates the dump cleanly.
Backward compatibility is seamlessly preserved for non-MLO stations.
Signed-off-by: P Praneesh <praneesh.p@oss.qualcomm.com >
Link: https://patch.msgid.link/20260614051739.3979947-5-praneesh.p@oss.qualcomm.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com >
2026-07-06 16:51:44 +02:00
2025-12-29 11:58:52 +01:00
2025-11-26 11:20:43 +01:00
2025-03-08 08:57:18 +09:00
2024-04-15 13:42:38 +02:00
2022-11-17 22:49:39 +01:00
2026-05-31 11:01:50 +01:00
2026-05-26 10:42:01 -06:00
2026-01-06 10:14:13 +01:00
2022-06-28 21:26:05 +02:00
2026-06-21 00:18:27 +02:00
2022-06-28 21:26:05 +02:00
2023-08-22 15:13:20 +02:00
2022-06-28 21:26:05 +02:00
2025-11-28 00:07:19 +00:00
2026-03-29 21:25:09 -04:00
2025-11-11 11:20:15 +08:00
2024-09-11 11:23:56 +02:00
2024-07-29 01:19:51 +01:00
2024-02-19 10:58:24 +00:00
2026-03-30 16:55:36 +02:00
2025-11-26 15:09:24 +01:00
2023-06-20 14:28:17 -06:00
2025-08-29 11:04:02 +02:00
2022-12-22 18:18:37 -08:00
2026-06-16 08:53:53 -07:00
2026-03-05 22:16:08 -05:00
2023-05-30 16:42:00 -07:00
2024-08-30 08:22:36 +02:00
2024-02-16 12:42:59 +11:00
2026-06-05 09:12:08 +02:00
2025-02-22 11:36:22 +01:00
2025-07-08 10:23:13 -04:00
2025-02-10 09:54:19 -07:00
2024-09-11 10:45:28 -06:00
2025-11-03 08:30:56 -07:00
2026-01-21 07:47:44 -07:00
2026-06-14 17:24:25 -07:00
2026-03-19 11:38:24 -06:00
2026-04-20 17:52:48 -07:00
2026-04-07 18:56:01 +02:00
2026-06-08 15:53:29 +02:00
2025-02-19 11:10:54 +01:00
2025-07-04 19:21:53 -05:00
2026-05-19 17:53:04 +02:00
2026-05-19 17:53:05 +02:00
2023-07-14 08:43:49 -10:00
2024-05-24 10:36:55 +01:00
2026-01-16 16:42:15 +01:00
2022-06-28 21:26:05 +02:00
2026-03-18 09:59:57 +00:00
2025-06-12 14:00:18 +02:00
2025-02-05 13:22:04 +09:00
2024-10-05 13:22:04 +08:00
2024-04-30 08:48:10 -07:00
2022-06-28 21:26:05 +02:00
2023-01-20 09:33:22 +00:00
2026-01-09 21:44:46 +01:00
2026-06-13 16:16:58 -07:00
2023-07-20 17:24:57 -05:00
2024-06-11 12:57:49 -05:00
2023-03-06 15:49:07 -06:00
2025-05-04 11:35:06 +02:00
2022-06-28 21:26:05 +02:00
2026-03-03 08:55:39 +01:00
2024-06-05 14:52:15 +05:30
2026-06-13 13:24:31 -07:00
2026-05-08 19:23:23 -06:00
2026-05-13 07:53:43 -06:00
2026-05-13 07:53:43 -06:00
2022-08-29 15:32:13 +02:00
2022-06-03 20:09:27 +08:00
2023-08-23 14:17:42 -07:00
2026-01-29 02:38:40 -07:00
2025-03-25 12:48:05 -04:00
2026-03-18 20:01:10 -07:00
2025-06-25 15:24:13 -07:00
2026-06-11 15:47:56 -07:00
2023-06-15 14:55:15 +02:00
2024-02-14 11:01:01 +00:00
2024-09-18 07:40:56 +09:00
2026-01-18 11:22:53 -05:00
2025-02-12 02:29:30 +00:00
2025-06-23 12:45:13 +02:00
2025-02-05 17:21:07 +01:00
2025-10-28 22:59:19 +01:00
2025-12-05 13:57:39 +01:00
2025-04-17 19:04:50 -07:00
2024-12-22 11:29:50 +01:00
2025-03-04 09:47:36 -07:00
2025-11-25 19:20:42 -08:00
2026-05-15 17:49:23 +02:00
2025-04-08 19:32:11 -07:00
2023-08-09 15:43:27 +09:30
2026-02-27 07:28:08 +01:00
2025-09-05 09:11:28 +02:00
2026-06-03 11:38:51 +02:00
2022-08-10 13:49:50 +01:00
2025-11-24 17:52:11 +01:00
2025-11-24 17:52:11 +01:00
2024-02-15 08:44:57 +01:00
2023-10-27 09:21:13 +02:00
2024-05-07 01:35:57 +02:00
2025-11-25 19:20:42 -08:00
2023-10-27 18:04:30 +08:00
2022-09-20 11:53:32 +01:00
2025-09-17 11:37:23 +02:00
2023-03-10 21:05:16 +01:00
2026-01-16 15:00:54 -07:00
2025-11-29 21:39:58 +09:00
2025-09-24 07:50:09 -07:00
2024-05-06 11:13:56 +02:00
2025-12-23 12:29:14 +05:30
2025-04-17 19:04:50 -07:00
2025-04-17 19:04:50 -07:00
2026-01-14 14:43:18 -08:00
2025-04-17 19:04:50 -07:00
2025-04-17 19:04:50 -07:00
2026-05-14 12:42:11 +02:00
2026-06-08 19:13:53 -07:00
2025-04-17 19:04:50 -07:00
2025-04-17 19:04:50 -07:00
2026-06-10 07:53:26 -07:00
2022-08-18 20:37:35 -07:00
2025-04-17 19:04:50 -07:00
2025-04-17 19:04:50 -07:00
2026-02-26 11:41:00 +01:00
2025-04-17 19:04:50 -07:00
2025-11-25 19:20:42 -08:00
2025-07-08 18:07:26 +02:00
2024-04-01 10:49:28 +01:00
2025-04-17 19:04:50 -07:00
2025-07-10 14:48:29 +02:00
2022-06-28 21:26:05 +02:00
2025-06-10 14:41:14 -07:00
2024-09-04 16:40:33 -07:00
2024-12-05 10:01:09 +01:00
2026-03-06 16:32:26 -08:00
2024-03-06 13:13:00 +01:00
2026-03-29 22:02:11 +02:00
2025-09-15 14:32:54 +02:00
2026-04-28 16:08:56 -06:00
2024-02-28 11:19:41 +00:00
2024-08-22 10:45:12 +02:00
2023-01-06 19:22:53 -08:00
2026-06-12 10:10:34 -03:00
2023-08-15 10:06:49 -06:00
2025-04-17 19:04:50 -07:00
2022-06-28 21:26:05 +02:00
2024-12-05 10:01:09 +01:00
2022-10-17 09:51:26 -05:00
2024-12-05 10:01:28 +01:00
2025-07-25 13:06:19 -07:00
2022-06-28 21:26:05 +02:00
2025-11-06 14:19:20 +02:00
2025-09-09 15:58:56 +02:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2024-06-01 07:28:21 +02:00
2024-09-01 20:26:05 -07:00
2025-09-13 17:32:43 -07:00
2026-03-12 15:07:51 +01:00
2026-05-11 15:55:57 -04:00
2025-12-16 13:23:17 -05:00
2026-06-09 17:30:57 +02:00
2022-09-20 09:13:38 +02:00
2026-06-14 20:17:19 +02:00
2024-09-12 20:28:46 -07:00
2022-05-25 09:51:36 -07:00
2026-06-11 15:49:51 +03:00
2026-05-26 17:26:57 -07:00
2022-07-08 10:46:53 -07:00
2025-11-25 19:20:42 -08:00
2024-08-19 22:36:26 -04:00
2022-08-29 10:44:08 +02:00
2026-01-12 16:52:09 +01:00
2026-03-04 11:22:05 +01:00
2025-07-08 12:39:24 +02:00
2026-05-05 14:40:39 +02:00
2025-11-14 15:48:49 +01:00
2023-05-25 16:21:22 +02:00
2023-03-23 17:25:46 +01:00
2023-12-15 17:01:30 +01:00
2023-01-07 11:29:29 +01:00
2023-01-18 17:12:37 -08:00
2026-01-26 20:02:32 -08:00
2026-04-13 14:36:22 -07:00
2022-06-28 21:26:05 +02:00
2024-07-19 20:22:12 +02:00
2026-03-24 21:42:37 +00:00
2026-03-12 13:33:54 +01:00
2026-02-06 20:35:06 -08:00
2025-12-08 23:54:02 -08:00
2026-04-14 04:44:31 +00:00
2024-09-06 08:31:40 -06:00
2022-06-28 21:26:05 +02:00
2025-06-30 18:14:23 -07:00
2025-06-25 15:35:20 -07:00
2025-11-25 19:20:42 -08:00
2025-04-17 19:04:50 -07:00
2025-07-25 13:06:19 -07:00
2026-06-15 12:58:18 -07:00
2026-02-17 15:04:20 +01:00
2026-01-17 15:24:05 -08:00
2026-01-17 15:24:05 -08:00
2022-09-07 16:46:03 +02:00
2025-04-17 19:04:50 -07:00
2023-10-20 11:43:35 +01:00
2024-08-12 17:50:34 -07:00
2026-02-27 19:21:56 -08:00
2025-01-21 15:30:01 -05:00
2026-01-26 10:10:58 -05:00
2026-06-09 16:32:59 -04:00
2025-12-22 15:45:29 -08:00
2025-12-22 15:45:29 -08:00
2025-11-25 10:34:55 +01:00
2026-07-06 16:51:44 +02:00
2023-09-27 09:40:02 +02:00
2025-11-03 17:41:18 +01:00
2023-11-28 19:05:16 +00:00
2025-01-08 13:18:11 +01:00
2026-05-21 15:33:47 +02:00
2026-03-04 17:52:46 -08:00
2026-03-17 11:09:05 +01:00
2024-04-25 12:37:12 -07:00
2023-03-23 12:22:19 +09:00
2026-06-17 12:24:50 -07:00
2025-12-23 16:05:56 -06:00
2026-01-29 17:42:29 -06:00
2026-02-10 12:00:46 -08:00
2025-08-20 15:30:36 +02:00
2026-03-23 16:29:15 +01:00
2025-05-15 11:44:29 -07:00
2026-05-14 11:41:30 +02:00
2023-06-07 14:26:09 -06:00
2025-01-08 13:18:09 +01:00
2026-05-19 09:32:27 -07:00
2025-12-17 07:35:22 -07:00
2026-04-04 18:40:58 -06:00
2024-07-05 17:45:47 -07:00
2024-10-24 16:30:33 -07:00
2023-07-20 22:14:21 +12:00
2026-03-14 14:03:19 +09:00
2025-09-17 12:17:05 +02:00
2026-06-12 18:31:32 -07:00
2025-09-25 11:00:59 -07:00
2025-05-11 17:48:15 -07:00
2025-07-07 08:39:33 +02:00
2023-08-09 09:15:39 +02:00
2024-07-19 20:22:48 +02:00
2023-12-20 19:26:31 -05:00
2026-05-21 07:41:32 +02:00
2022-06-28 21:26:05 +02:00
2023-01-06 19:28:01 -08:00
2023-07-15 11:35:02 -07:00
2026-05-01 21:32:20 +02:00
2026-05-12 18:30:26 -07:00
2025-04-14 17:36:41 -07:00
2026-04-14 19:59:25 -07:00
2023-03-09 11:31:44 +01:00
2023-07-17 16:08:08 -07:00
2024-12-18 17:00:29 -08:00
2026-03-31 07:04:00 -06:00
2026-03-26 18:45:29 -07:00
2022-09-20 12:33:22 +02:00
2022-06-28 21:26:05 +02:00
2023-10-10 08:51:10 +02:00
2023-09-18 11:14:42 +02:00
2024-01-27 18:15:24 -08:00
2024-09-05 20:11:43 +02:00
2024-07-16 11:44:00 -04:00
2026-01-26 19:07:10 -08:00
2023-12-26 20:24:33 +00:00
2024-08-20 11:38:23 +02:00
2025-07-14 18:41:42 -07:00
2022-06-01 16:48:05 -07:00
2025-05-07 14:25:30 -07:00
2026-01-17 11:00:28 -08:00
2022-06-28 21:26:05 +02:00
2026-06-01 11:08:18 -04:00
2022-11-09 14:06:51 +01:00
2023-12-02 01:17:48 +02:00
2026-02-12 11:32:37 -08:00
2023-03-24 16:59:09 -04:00
2026-02-08 00:13:32 -08:00
2024-07-01 09:44:27 +01:00
2026-02-03 15:13:25 +01:00
2022-11-17 11:04:23 -08:00
2026-05-20 08:49:09 +02:00
2025-02-11 20:53:14 +01:00
2023-12-04 10:37:46 +01:00
2025-06-19 14:28:22 +02:00
2025-05-21 13:41:03 +02:00
2026-06-12 16:43:10 -07:00
2023-06-15 13:41:53 +02:00
2026-04-17 09:43:12 -07:00
2022-06-27 16:25:41 +02:00
2026-01-17 15:24:05 -08:00
2024-09-30 09:20:59 +01:00
2026-04-09 19:08:35 -06:00
2026-03-13 18:57:45 -07:00
2024-09-11 20:44:32 -07:00
2026-03-21 10:42:09 +01:00
2022-06-28 21:26:05 +02:00
2022-08-31 09:07:53 +02:00
2024-03-18 10:13:03 -04:00
2023-12-29 11:58:24 -08:00
2026-06-01 21:49:14 -07:00
2023-03-23 17:25:46 +01:00
2025-03-03 18:23:36 +01:00
2022-12-07 17:58:46 +01:00
2026-05-04 08:35:14 +02:00
2025-09-09 15:58:44 +02:00
2024-04-29 14:56:36 +02:00
2024-04-29 14:56:37 +02:00
2026-01-16 15:00:54 -07:00
2024-09-10 02:51:48 -04:00
2026-02-09 12:21:32 -05:00
2024-01-27 18:08:54 -08:00
2022-07-11 09:54:37 +02:00
2026-03-19 12:32:08 -06:00
2025-07-08 18:05:23 +02:00
2025-08-26 03:38:19 -04:00
2026-01-21 14:43:09 +01:00
2022-06-28 21:26:05 +02:00
2024-09-10 02:51:48 -04:00
2023-04-04 11:01:57 -04:00
2024-05-14 10:54:49 -04:00
2026-06-10 02:17:00 -04:00
2023-12-19 11:51:31 -07:00
2026-06-10 02:14:02 -04:00
2024-10-05 13:22:04 +08:00
2026-05-20 17:59:21 +03:00
2025-09-22 09:29:28 +01:00
2024-05-22 08:31:15 -04:00
2025-11-04 17:14:07 -08:00
2025-11-30 18:02:43 -05:00
2024-01-10 13:01:37 -05:00
2025-12-26 15:00:00 -05:00
2025-05-27 10:27:54 -04:00
2025-02-14 12:58:02 +01:00
2025-09-22 09:29:29 +01:00
2025-06-24 17:12:59 -07:00
2026-02-02 18:06:00 -08:00
2025-11-27 14:24:44 -08:00
2025-08-01 10:42:22 +02:00
2026-06-08 11:53:18 -07:00
2025-12-02 04:12:49 +01:00
2023-05-28 19:07:48 -06:00
2025-12-24 13:52:50 +01:00
2026-06-04 12:22:47 +02:00
2024-06-04 08:59:58 +02:00
dd21d1844a