Ben Hutchings e226930835
r6040: Fix multicast filter some more ...
This code has been broken forever, but in several different and
creative ways.
So far as I can work out, the R6040 MAC filter has 4 exact-match
entries, the first of which the driver uses for its assigned unicast
address, plus a 64-entry hash-based filter for multicast addresses
(maybe unicast as well?).
The original version of this code would write the first 4 multicast
addresses as exact-match entries from offset 1 (bug #1 : there is no
entry 4 so this could write to some PHY registers). It would fill the
remainder of the exact-match entries with the broadcast address (bug #2 :
this would overwrite the last used entry). If more than 4 multicast
addresses were configured, it would set up the hash table, write some
random crap to the MAC control register (bug #3 ) and finally walk off
the end of the list when filling the exact-match entries (bug #4 ).
All of this seems to be pointless, since it sets the promiscuous bit
when the interface is made promiscuous or if >4 multicast addresses
are enabled, and never clears it (bug #5 , masking bug #2 ).
The recent(ish) changes to the multicast list fixed bug #4 , but
completely removed the limit on iteration over the exact-match entries
(bug #6 ).
Bug #4 was reported as
<https://bugzilla.kernel.org/show_bug.cgi?id=15355 > and more recently
as <http://bugs.debian.org/600155 >. Florian Fainelli attempted to fix
these in commit 3bcf8229a8#4 having been fixed in mainline at
that point.
That commit fixes the most important current bug #6 .
Signed-off-by: Ben Hutchings <ben@decadent.org.uk >
Cc: stable@kernel.org [2.6.35 only]
Signed-off-by: David S. Miller <davem@davemloft.net >
2010-10-19 06:40:03 -07:00
2010-06-16 18:05:05 +02:00
2010-07-18 15:07:15 -07:00
2010-08-11 09:17:27 -07:00
2010-06-01 00:28:12 -07:00
2010-05-14 00:19:28 -07:00
2010-09-22 13:52:45 -07:00
2010-09-03 09:52:47 -07:00
2010-08-18 23:42:36 -07:00
2010-10-05 20:06:01 -07:00
2010-08-24 12:21:13 -07:00
2010-08-06 09:25:50 -06:00
2010-06-03 03:18:20 -07:00
2010-07-14 13:41:53 -07:00
2010-09-16 21:55:00 -07:00
2010-08-02 16:26:44 -07:00
2010-08-04 16:18:02 -07:00
2010-08-08 20:02:45 -07:00
2010-09-22 20:41:21 -07:00
2010-10-13 14:24:59 -07:00
2010-08-04 16:18:04 -07:00
2010-08-06 09:25:50 -06:00
2010-05-28 01:57:18 -07:00
2010-09-26 18:54:32 -07:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-08-06 18:13:19 +01:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-05-10 05:01:31 -07:00
2010-07-15 19:05:17 -07:00
2010-08-11 23:04:32 +09:30
2010-09-21 13:04:04 -07:00
2010-07-18 19:15:25 -07:00
2010-09-15 17:57:22 +02:00
2010-09-14 14:31:03 -07:00
2010-09-21 13:03:24 -07:00
2010-08-26 14:09:14 -07:00
2010-07-08 23:12:29 -07:00
2010-05-17 22:47:34 -07:00
2010-09-07 13:57:14 -07:00
2010-05-14 00:19:28 -07:00
2010-09-27 15:40:29 -07:00
2010-09-16 21:54:59 -07:00
2010-07-25 17:06:52 -07:00
2010-07-30 23:27:57 -07:00
2010-08-13 10:38:12 -07:00
2010-10-11 11:05:43 -07:00
2010-10-08 10:36:51 -07:00
2010-09-27 11:07:00 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-28 01:57:18 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-06-16 18:05:05 +02:00
2010-06-03 03:18:23 -07:00
2010-05-14 00:19:28 -07:00
2010-06-11 13:32:31 -07:00
2010-06-11 13:32:31 -07:00
2010-07-19 15:27:13 -07:00
2010-05-18 23:01:55 -07:00
2010-07-11 18:15:08 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-18 23:01:55 -07:00
2010-07-11 18:15:08 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-08-05 08:53:20 -07:00
2010-07-08 23:42:40 -07:00
2010-10-11 15:45:35 -07:00
2010-07-18 19:15:25 -07:00
2010-06-15 15:04:10 -07:00
2010-06-15 15:04:10 -07:00
2010-06-02 17:50:38 +10:00
2010-07-19 20:30:07 -07:00
2010-07-19 20:30:06 -07:00
2010-07-14 13:36:18 -07:00
2010-07-14 12:18:31 -07:00
2010-06-25 20:37:21 -07:00
2010-07-27 20:35:39 -07:00
2010-06-25 20:37:19 -07:00
2010-07-18 19:15:25 -07:00
2010-07-19 13:32:57 -07:00
2010-07-14 13:40:36 -07:00
2010-08-04 16:18:03 -07:00
2010-05-10 05:01:31 -07:00
2010-05-10 05:01:31 -07:00
2010-07-26 19:08:14 +01:00
2010-07-12 20:21:40 -07:00
2010-05-14 00:19:28 -07:00
2010-06-03 03:18:23 -07:00
2010-07-30 23:27:58 -07:00
2010-08-08 20:02:45 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:14 -07:00
2010-09-16 21:54:59 -07:00
2010-05-14 00:19:28 -07:00
2010-07-14 17:57:19 -07:00
2010-07-26 18:45:05 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:13 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-10-13 09:56:31 -07:00
2010-05-24 00:36:13 -07:00
2010-07-25 21:54:28 -07:00
2010-08-06 09:25:50 -06:00
2010-06-03 03:18:23 -07:00
2010-10-18 01:55:12 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-08 01:20:06 -06:00
2010-08-06 09:25:50 -06:00
2010-07-05 19:41:15 -07:00
2010-08-04 15:31:02 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-17 21:37:41 +02:00
2010-08-19 00:09:48 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:12 -07:00
2010-07-12 20:21:44 -07:00
2010-05-17 22:47:34 -07:00
2010-10-03 21:46:24 -07:00
2010-06-02 06:12:19 -07:00
2010-07-27 22:24:37 -07:00
2010-09-08 21:47:13 -07:00
2010-05-05 21:27:44 -07:00
2010-08-04 15:31:02 -07:00
2010-07-05 19:41:16 -07:00
2010-05-14 00:19:28 -07:00
2010-06-21 13:50:18 -07:00
2010-09-01 08:55:23 -06:00
2010-09-01 08:55:23 -06:00
2010-05-26 20:44:30 -07:00
2010-05-14 00:19:28 -07:00
2010-07-07 14:58:56 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:18 -07:00
2010-06-03 03:18:20 -07:00
2010-07-18 19:15:25 -07:00
2010-06-02 17:50:38 +10:00
2010-05-10 05:01:31 -07:00
2010-07-12 20:21:44 -07:00
2010-07-27 21:02:42 -07:00
2010-07-27 21:01:35 -07:00
2010-08-18 23:30:42 -07:00
2010-05-14 00:19:28 -07:00
2010-06-21 13:40:25 -07:00
2010-07-23 13:05:12 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-07-05 19:41:17 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 20:08:05 -07:00
2010-05-06 00:47:21 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:19 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-09-08 23:49:04 -07:00
2010-06-28 12:41:33 -07:00
2010-07-05 19:41:18 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-08-04 21:53:17 -07:00
2010-09-13 12:44:11 -07:00
2010-08-04 21:53:17 -07:00
2010-08-04 21:53:17 -07:00
2010-05-10 05:01:31 -07:00
2010-05-20 21:04:44 -07:00
2010-06-03 03:18:23 -07:00
2010-09-01 14:29:34 -07:00
2010-07-26 13:15:21 -07:00
2010-10-19 06:40:03 -07:00
2010-10-09 09:16:13 -07:00
2010-09-26 18:54:33 -07:00
2010-05-10 05:01:31 -07:00
2010-07-15 20:46:22 -07:00
2010-07-23 13:05:13 -07:00
2010-07-27 21:01:35 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-07-18 19:15:25 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-09-26 18:54:34 -07:00
2010-08-19 00:39:45 -07:00
2010-05-14 00:19:28 -07:00
2010-10-05 15:11:40 -07:00
2010-05-15 23:29:31 -07:00
2010-09-02 09:39:09 -07:00
2010-06-03 03:18:23 -07:00
2010-05-14 00:19:28 -07:00
2010-05-17 22:47:34 -07:00
2010-05-10 05:01:31 -07:00
2010-07-26 09:06:04 -04:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-09-26 18:50:05 -07:00
2010-07-18 19:15:25 -07:00
2010-05-10 05:01:31 -07:00
2010-07-14 12:17:35 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:15 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:11 -07:00
2010-05-10 05:01:31 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-05-10 05:01:31 -07:00
2010-07-18 19:15:25 -07:00
2010-06-03 03:28:23 -07:00
2010-06-03 03:18:23 -07:00
2010-10-11 16:06:24 -07:00
2010-10-11 16:06:24 -07:00
2010-05-10 05:01:31 -07:00
2010-07-30 22:06:41 -07:00
2010-06-03 03:18:23 -07:00
2010-06-03 03:18:23 -07:00
2010-08-06 09:25:50 -06:00
2010-06-03 03:18:23 -07:00
2010-05-06 00:53:53 -07:00
2010-05-10 05:01:31 -07:00
2010-09-07 13:57:24 -07:00
2010-06-03 03:18:23 -07:00
2010-08-04 21:53:17 -07:00
2010-07-14 17:53:18 -07:00
2010-05-31 00:27:44 -07:00
2010-08-06 09:25:50 -06:00
2010-07-12 20:21:45 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-18 23:01:55 -07:00
Ben Hutchings
e226930835