Chenguang Zhao
0e2909c6be
net/mlx5: Fix variable not being completed when function returns
When cmd_alloc_index(), fails cmd_work_handler() needs
to complete ent->slotted before returning early.
Otherwise the task which issued the command may hang:
mlx5_core 0000:01:00.0: cmd_work_handler:877:(pid 3880418): failed to allocate command entry
INFO: task kworker/13:2:4055883 blocked for more than 120 seconds.
Not tainted 4.19.90-25.44.v2101.ky10.aarch64 #1
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kworker/13:2 D 0 4055883 2 0x00000228
Workqueue: events mlx5e_tx_dim_work [mlx5_core]
Call trace:
__switch_to+0xe8/0x150
__schedule+0x2a8/0x9b8
schedule+0x2c/0x88
schedule_timeout+0x204/0x478
wait_for_common+0x154/0x250
wait_for_completion+0x28/0x38
cmd_exec+0x7a0/0xa00 [mlx5_core]
mlx5_cmd_exec+0x54/0x80 [mlx5_core]
mlx5_core_modify_cq+0x6c/0x80 [mlx5_core]
mlx5_core_modify_cq_moderation+0xa0/0xb8 [mlx5_core]
mlx5e_tx_dim_work+0x54/0x68 [mlx5_core]
process_one_work+0x1b0/0x448
worker_thread+0x54/0x468
kthread+0x134/0x138
ret_from_fork+0x10/0x18
Fixes: 485d65e135 ("net/mlx5: Add a timeout to acquire the command queue semaphore")
Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Acked-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250108030009.68520-1-zhaochenguang@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-01-09 08:28:23 -08:00
..
2024-12-20 07:13:45 +10:00
2024-11-04 17:53:09 +09:00
2024-12-18 20:23:59 +01:00
2024-11-12 16:41:45 +00:00
2024-11-29 11:58:27 -08:00
2024-12-09 09:06:58 +09:00
2024-12-01 15:12:43 -08:00
2024-12-20 07:13:45 +10:00
2024-12-08 11:38:56 -08:00
2024-12-01 15:12:43 -08:00
2024-12-28 11:02:35 -08:00
2025-01-08 11:14:03 -05:00
2024-11-29 11:58:27 -08:00
2024-12-01 15:12:43 -08:00
2024-12-03 08:22:25 -08:00
2024-12-01 15:12:43 -08:00
2024-12-10 18:21:40 -08:00
2024-12-09 18:42:42 +00:00
2024-11-05 14:01:07 +01:00
2024-12-02 11:34:44 -08:00
2024-12-10 10:17:43 -06:00
2024-12-01 15:12:43 -08:00
2024-12-10 13:40:25 +08:00
2024-12-10 14:50:34 -07:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-26 10:43:25 -08:00
2024-12-20 07:13:45 +10:00
2024-11-03 08:39:07 -08:00
2024-12-11 21:47:33 +01:00
2024-12-01 15:12:43 -08:00
2024-11-25 17:12:54 -08:00
2024-12-21 15:45:06 -08:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-10 11:38:57 +01:00
2025-01-03 10:57:31 +10:00
2024-11-05 05:33:46 +01:00
2024-12-05 10:06:47 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-09 18:44:15 +00:00
2024-12-16 15:58:25 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-26 01:54:47 +01:00
2024-12-01 15:12:43 -08:00
2024-11-11 15:48:50 +01:00
2024-12-08 11:26:13 -08:00
2025-01-03 11:09:35 -08:00
2024-11-25 10:31:39 -08:00
2024-11-05 01:32:05 +02:00
2024-12-13 15:54:27 +01:00
2024-12-13 18:15:29 +01:00
2024-11-09 09:14:12 -08:00
2024-12-02 11:34:44 -08:00
2024-12-20 07:13:45 +10:00
2024-11-30 09:03:16 -08:00
2024-12-02 11:34:44 -08:00
2024-12-10 09:15:33 -07:00
2024-12-21 10:56:34 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-11-20 21:38:24 -05:00
2024-12-02 11:34:44 -08:00
2024-12-02 11:34:44 -08:00
2024-12-19 14:42:10 +01:00
2024-12-05 11:15:00 +01:00
2025-01-09 08:28:23 -08:00
2024-10-30 16:07:38 -05:00
2024-12-02 11:34:44 -08:00
2024-12-18 07:22:30 -07:00
2024-12-01 15:12:43 -08:00
2024-12-22 08:40:23 -08:00
2024-11-27 14:40:33 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-29 10:03:01 -08:00
2024-12-01 15:12:43 -08:00
2024-12-02 11:34:44 -08:00
2024-12-02 11:34:44 -08:00
2024-12-24 20:38:53 +05:30
2025-01-03 10:57:57 -08:00
2024-12-30 11:20:42 -08:00
2024-12-19 15:47:02 +01:00
2024-12-19 00:35:30 +01:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-11-15 00:32:29 +11:00
2024-12-06 17:38:11 -08:00
2024-12-19 08:50:05 -08:00
2024-12-19 11:15:24 +00:00
2024-11-15 20:36:27 -08:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-02 11:34:44 -08:00
2024-11-29 11:43:29 -08:00
2024-12-01 15:12:43 -08:00
2024-12-04 13:22:59 -05:00
2024-11-30 14:45:29 -08:00
2024-12-01 15:12:43 -08:00
2024-11-21 08:28:08 -08:00
2024-12-02 11:34:44 -08:00
2024-12-18 16:02:08 +00:00
2024-12-01 15:12:43 -08:00
2024-12-21 11:30:13 -08:00
2024-12-02 12:36:18 -05:00
2024-11-12 15:48:08 +01:00
2024-12-01 15:12:43 -08:00
2024-12-18 14:51:31 +01:00
2024-12-16 09:59:38 +02:00
2024-12-14 09:31:19 -08:00
2024-12-09 21:49:08 -05:00
2024-12-01 15:12:43 -08:00
2024-12-17 11:59:09 +01:00
2024-11-12 18:05:05 -05:00
2024-12-11 13:48:25 -08:00
2024-11-11 10:56:27 -08:00
2024-12-20 07:13:45 +10:00
2024-12-29 10:18:44 +01:00
2024-12-10 11:22:21 +01:00
2024-12-01 15:12:43 -08:00
2024-12-05 10:03:43 -08:00
2024-12-02 11:34:44 -08:00