Jesper Dangaard Brouer 96c5508e30 xdp: implement xdp_redirect_map for generic XDP ...

Using bpf_redirect_map is allowed for generic XDP programs, but the
appropriate map lookup was never performed in xdp_do_generic_redirect().

Instead the map-index is directly used as the ifindex.  For the
xdp_redirect_map sample in SKB-mode '-S', this resulted in trying
sending on ifindex 0 which isn't valid, resulting in getting SKB
packets dropped.  Thus, the reported performance numbers are wrong in
commit 24251c2647 ("samples/bpf: add option for native and skb mode
for redirect apps") for the 'xdp_redirect_map -S' case.

Before commit 109980b894 ("bpf: don't select potentially stale
ri->map from buggy xdp progs") it could crash the kernel.  Like this
commit also check that the map_owner owner is correct before
dereferencing the map pointer.  But make sure that this API misusage
can be caught by a tracepoint. Thus, allowing userspace via
tracepoints to detect misbehaving bpf_progs.

Fixes: 6103aa96ec ("net: implement XDP_REDIRECT for xdp generic")
Fixes: 24251c2647 ("samples/bpf: add option for native and skb mode for redirect apps")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2017-09-11 14:33:00 -07:00

..

events

xdp: implement xdp_redirect_map for generic XDP

2017-09-11 14:33:00 -07:00

define_trace.h

tracing: Introduce TRACE_EVENT_FN_COND macro

2015-12-23 14:27:21 -05:00

perf.h

tracing: Use outer () on __get_str() definition

2016-07-15 15:50:58 -04:00

syscall.h

tracing: Rename ftrace_event_{call,class} to trace_event_{call,class}

2015-05-13 14:06:10 -04:00

trace_events.h

tracing: define TRACE_DEFINE_SIZEOF() macro to map sizeof's to their values

2017-06-13 17:10:57 -04:00