Amir Goldstein 2c3ef4f89c
ovl: initialize ovl_copy_up_ctx.destname inside ovl_do_copy_up() ...
The ->destname member of struct ovl_copy_up_ctx is initialized inside
ovl_copy_up_one() to ->d_name of the overlayfs dentry being copied up
and then it may be overridden by index name inside ovl_do_copy_up().
ovl_inode_lock() in ovl_copy_up_start() and ovl_copy_up() in ovl_rename()
effectively stabilze ->d_name of the overlayfs dentry being copied up,
but ovl_inode_lock() is not held when ->d_name is being read.
It is not a correctness bug, because if ovl_do_copy_up() races with
ovl_rename() and ctx.destname is freed, we will not end up calling
ovl_do_copy_up() with the dead name reference.
The code becomes much easier to understand and to document if the
initialization of c->destname is always done inside ovl_do_copy_up(),
either to the index entry name, or to the overlay dentry ->d_name.
Signed-off-by: Amir Goldstein <amir73il@gmail.com >
2023-11-20 16:01:45 +02:00
2023-11-04 09:20:04 -10:00
2023-10-18 13:26:18 +02:00
2023-11-07 12:11:26 -08:00
2023-11-01 15:28:33 -10:00
2023-10-30 09:47:13 -10:00
2023-11-16 16:57:19 -05:00
2023-11-07 12:11:26 -08:00
2023-10-18 13:26:19 +02:00
2023-11-13 09:09:12 -08:00
2023-08-29 14:25:26 -07:00
2023-11-10 09:52:56 -08:00
2023-10-18 13:26:19 +02:00
2023-10-18 13:26:19 +02:00
2023-10-30 09:47:13 -10:00
2023-11-02 16:15:30 -10:00
2023-11-03 15:15:47 -10:00
2023-10-18 13:26:20 +02:00
2023-10-12 15:21:00 -05:00
2023-10-09 16:24:17 +02:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-03 22:24:11 +09:00
2023-10-28 16:16:19 +02:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-01-30 12:51:54 +00:00
2023-11-07 12:11:26 -08:00
2023-11-07 11:54:17 -08:00
2023-10-30 09:47:13 -10:00
2023-10-30 09:47:13 -10:00
2023-10-18 14:08:22 +02:00
2023-10-18 14:08:22 +02:00
2023-11-07 12:11:26 -08:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:22 +02:00
2023-11-02 19:38:47 -10:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-03 15:15:47 -10:00
2023-10-16 12:44:04 -04:00
2023-10-18 14:08:23 +02:00
2023-09-18 12:03:46 -07:00
2023-11-08 13:39:16 -08:00
2023-04-13 13:13:52 -07:00
2023-11-18 11:23:32 -08:00
2023-11-02 19:38:47 -10:00
2023-08-31 12:07:34 -05:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:08:25 +02:00
2023-10-18 14:08:25 +02:00
2023-10-30 09:47:13 -10:00
2023-11-20 16:01:45 +02:00
2023-11-02 20:53:31 -10:00
2023-10-30 19:26:39 -10:00
2023-10-18 14:08:26 +02:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-30 09:47:13 -10:00
2023-11-14 11:39:35 -06:00
2023-11-07 12:11:26 -08:00
2023-10-05 13:42:11 +02:00
2023-10-18 14:08:28 +02:00
2023-11-03 07:41:18 -10:00
2023-11-05 08:28:32 -10:00
2023-11-02 08:19:51 -10:00
2023-11-07 12:11:26 -08:00
2023-04-13 13:13:54 -07:00
2023-10-18 14:08:29 +02:00
2023-08-20 10:33:43 -07:00
2023-11-13 09:11:41 +05:30
2023-10-18 14:08:29 +02:00
2023-09-20 14:22:01 +02:00
2023-10-18 14:43:23 -07:00
2023-10-18 13:26:15 +02:00
2023-10-18 13:26:15 +02:00
2023-10-30 19:28:19 -10:00
2022-03-03 20:38:56 -08:00
2023-10-03 19:48:44 -07:00
2022-04-22 10:57:18 -07:00
2023-10-30 19:28:19 -10:00
2023-11-02 20:53:31 -10:00
2023-11-02 20:53:31 -10:00
2022-03-03 20:38:56 -08:00
2023-06-26 09:50:21 -07:00
2023-05-17 09:16:59 +02:00
2023-10-04 10:32:20 -07:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:43:23 -07:00
2023-08-18 10:12:11 -07:00
2023-07-11 11:41:34 +02:00
2023-10-18 14:43:23 -07:00
2023-10-04 10:32:20 -07:00
2023-10-18 14:43:23 -07:00
2023-10-24 17:57:45 +02:00
2023-11-02 20:53:31 -10:00
2023-10-25 22:17:04 +02:00
2023-10-12 18:53:36 +03:00
2022-12-01 10:46:54 -05:00
2023-08-21 13:46:25 -07:00
2023-10-30 09:14:19 -10:00
2023-09-22 14:09:06 +02:00
2023-10-19 11:02:47 +02:00
2023-11-02 20:53:31 -10:00
2023-10-19 11:03:15 +02:00
2023-08-28 11:04:18 -07:00
2023-11-01 15:28:33 -10:00
2023-08-23 14:17:43 -07:00
2023-08-19 12:12:12 +02:00
2023-11-07 12:11:26 -08:00
2023-11-02 20:53:31 -10:00
2023-10-22 17:08:07 -04:00
2023-10-04 10:32:25 -07:00
2023-11-03 23:28:33 +01:00
2022-07-05 16:18:21 -04:00
2023-10-25 16:47:10 -07:00
2023-10-30 09:14:19 -10:00
2023-11-02 20:53:31 -10:00
2023-10-18 13:26:15 +02:00
2023-10-19 11:03:15 +02:00
2023-11-02 20:53:31 -10:00
2023-05-19 04:30:22 +02:00
2023-05-19 04:30:22 +02:00
2023-07-13 10:28:04 +02:00
2023-05-24 08:42:16 -06:00
2023-08-15 08:32:45 +02:00
2023-08-06 15:08:35 +02:00
2023-05-24 11:03:59 +02:00
2022-11-25 13:01:55 -05:00
2023-08-29 14:25:26 -07:00
2023-10-18 13:26:15 +02:00
2023-10-18 13:26:15 +02:00
2023-05-17 15:20:17 +02:00
2023-11-07 11:46:31 -08:00
2022-04-26 13:36:25 -07:00
2023-05-23 21:43:26 -07:00
2023-11-02 20:53:31 -10:00
2023-02-20 11:53:11 -08:00
2023-10-09 16:24:16 +02:00
2c3ef4f89c