Files
linux/drivers/scsi
Kees Cook c3408c4ae0 scsi: qla2xxx: Avoid possible run-time warning with long model_num
The prior strlcpy() replacement of strncpy() here (which was
later replaced with strscpy()) expected pinfo->model_num (and
pinfo->model_description) to be NUL-terminated, but it is possible
it was not, as the code pattern here shows vha->hw->model_number (and
vha->hw->model_desc) being exactly 1 character larger, and the replaced
strncpy() was copying only up to the size of the source character
array. Replace this with memtostr(), which is the unambiguous way to
convert a maybe not-NUL-terminated character array into a NUL-terminated
string.

Fixes: 527e9b704c ("scsi: qla2xxx: Use memcpy() and strlcpy() instead of strcpy() and strncpy()")
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240410023155.2100422-5-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
2024-04-25 10:41:47 -07:00
..
2023-10-13 14:15:54 -04:00
2023-05-31 19:59:26 -04:00
2024-03-10 18:15:48 -04:00
2023-05-26 13:52:19 -07:00
2023-04-18 23:01:23 -04:00
2022-02-22 21:11:02 -05:00
2022-05-08 14:28:18 -04:00
2024-03-25 15:41:07 -04:00
2024-03-10 18:15:49 -04:00
2023-05-31 11:36:40 -04:00