Files
linux/drivers/char
Alan Cox 42fd552e86 fix serial buffer memory leak
Patch c5c34d4862 (tty: flush flip buffer on
ldisc input queue flush) introduces a race condition which can lead to memory
leaks.

The problem can be triggered when tcflush() is called when data are being
pushed to the line discipline driver by flush_to_ldisc().

flush_to_ldisc() releases tty->buf.lock when calling the line discipline
receive_buf function. At that poing tty_buffer_flush() kicks in and sets both
tty->buf.head and tty->buf.tail to NULL. When flush_to_ldisc() finishes, it
restores tty->buf.head but doesn't touch tty->buf.tail. This corrups the
buffer queue, and the next call to tty_buffer_request_room() will allocate a
new buffer and overwrite tty->buf.head. The previous buffer is then lost
forever without being released.

(Thanks to Laurent for the above text, for finding, disgnosing and reporting
the bug)

- Use tty->flags bits for the flush status.

- Wait for the flag to clear again before returning

- Fix the doc error noted

- Fix flush of empty queue leaving stale flushpending

[akpm@linux-foundation.org: cleanup]
Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: Paul Fulghum <paulkf@microgate.com>
Cc: Laurent Pinchart <laurentp@cse-semaphore.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-08-11 15:47:41 -07:00
..
2007-07-29 17:09:29 -07:00
2007-07-31 15:39:44 -07:00
2007-07-31 15:39:41 -07:00
…
…
2007-07-16 09:05:46 -07:00
…
…
…
2007-05-08 11:15:09 -07:00
…
2007-05-08 11:15:13 -07:00
…
2007-05-21 09:18:19 -07:00
2007-07-26 11:35:17 -07:00
2007-07-17 10:23:10 -07:00
2007-07-26 11:35:19 -07:00
2007-07-16 09:05:46 -07:00
2007-03-17 01:03:26 +00:00
2007-02-20 17:11:55 +00:00
2007-07-19 10:04:43 -07:00
2007-07-19 10:04:43 -07:00
2007-07-29 17:09:29 -07:00
2007-07-17 10:23:10 -07:00
2007-07-29 17:09:29 -07:00
2007-07-16 09:05:47 -07:00
2007-02-12 09:48:30 -08:00
2007-07-21 17:49:16 -07:00
2007-07-17 10:23:10 -07:00
…
…
…
2007-07-16 09:05:46 -07:00
…
…
2007-07-16 09:05:46 -07:00
2007-07-10 17:51:13 -07:00
2006-12-08 08:28:59 -08:00
…
2007-05-08 11:15:05 -07:00
2007-07-16 09:05:47 -07:00
2007-08-11 15:47:41 -07:00
2006-12-20 16:37:48 +11:00