Files
linux/drivers
Anton Vorontsov cd1f55a5b4 gianfar: Revive VLAN support
commit 77ecaf2d5a ("gianfar: Fix VLAN
HW feature related frame/buffer size calculation") wrongly removed
priv->vlgrp assignment, and now priv->vlgrp is always NULL.

This patch fixes the issue, plus fixes following sparse warning
introduced by the same commit:
gianfar.c:1406:13: warning: context imbalance in 'gfar_vlan_rx_register' - wrong count at exit

gfar_vlan_rx_register() checks for "if (old_grp == grp)" and tries
to return w/o dropping the lock.

According to net/8021q/vlan.c VLAN core issues rx_register() callback:
1. In register_vlan_dev() only on a newly created group;
2. In unregister_vlan_dev() only if the group becomes empty.

Thus the check in the gianfar driver isn't needed.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-01-26 14:33:23 -08:00
..
2009-01-16 14:45:34 -05:00
2009-01-08 16:29:41 +00:00
2009-01-16 16:15:16 +11:00
2009-01-14 19:19:04 +01:00
2009-01-11 01:34:25 +01:00
2009-01-26 12:24:38 -08:00
2009-01-15 16:39:40 -08:00
2009-01-16 14:45:34 -05:00
2009-01-09 12:37:15 -08:00
2009-01-26 14:33:23 -08:00
2009-01-16 14:45:34 -05:00
2009-01-09 03:39:43 -05:00