Files
linux/include/linux
Lukas Czerner cbfecb927f fs: record I_DIRTY_TIME even if inode already has I_DIRTY_INODE
Currently the I_DIRTY_TIME will never get set if the inode already has
I_DIRTY_INODE with assumption that it supersedes I_DIRTY_TIME.  That's
true, however ext4 will only update the on-disk inode in
->dirty_inode(), not on actual writeback. As a result if the inode
already has I_DIRTY_INODE state by the time we get to
__mark_inode_dirty() only with I_DIRTY_TIME, the time was already filled
into on-disk inode and will not get updated until the next I_DIRTY_INODE
update, which might never come if we crash or get a power failure.

The problem can be reproduced on ext4 by running xfstest generic/622
with -o iversion mount option.

Fix it by allowing I_DIRTY_TIME to be set even if the inode already has
I_DIRTY_INODE. Also make sure that the case is properly handled in
writeback_single_inode() as well. Additionally changes in
xfs_fs_dirty_inode() was made to accommodate for I_DIRTY_TIME in flag.

Thanks Jan Kara for suggestions on how to make this work properly.

Cc: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: stable@kernel.org
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220825100657.44217-1-lczerner@redhat.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2022-09-29 23:02:00 -04:00
..
2022-04-20 12:59:50 +05:30
2022-05-22 20:44:29 +01:00
2022-06-30 13:40:35 +01:00
2022-07-05 20:25:39 +02:00
2022-07-14 12:14:30 -06:00
2022-06-29 13:21:51 -07:00
2022-06-28 10:37:25 -03:00
2022-07-01 14:53:01 +02:00
2022-06-03 06:52:57 -07:00
2022-08-31 14:57:28 +01:00
2022-06-09 21:53:09 -07:00
2022-06-09 21:53:12 -07:00
2022-06-09 21:53:09 -07:00
2022-06-27 06:29:12 -06:00
2022-06-29 17:42:28 -07:00
2022-07-17 17:31:38 -07:00
2022-05-02 14:06:20 -06:00
2022-05-03 16:09:03 -04:00
2022-06-19 10:38:26 +01:00
2022-07-27 14:04:52 +02:00
2022-08-28 14:02:44 -07:00
2022-04-28 23:16:14 -07:00
2022-07-29 18:07:19 -07:00
2022-08-02 12:34:04 -04:00
2022-04-28 16:31:10 +02:00
2022-05-17 13:32:46 -04:00
2022-08-09 14:11:34 -04:00
2022-07-29 20:16:58 -04:00
2022-07-01 16:38:35 -06:00
2022-05-22 21:03:01 +01:00
2022-06-27 14:41:31 +02:00
2022-05-08 01:33:08 -07:00
2022-08-08 22:37:24 -04:00
2022-08-11 04:31:14 -04:00
2022-06-13 09:54:52 -07:00
2022-07-10 21:17:30 -04:00