mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-06-06 14:10:29 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
cb57c75098c1c449a007ba301f9073f96febaaa9
linux/drivers
History
Mirsad Todorovac cb57c75098 drm/xe: fix the ERR_PTR() returned on failure to allocate tiny pt 
Running coccinelle spatch gave the following warning:

./drivers/gpu/drm/xe/tests/xe_migrate.c:226:5-11: inconsistent IS_ERR
and PTR_ERR on line 228.

The code reports PTR_ERR(pt) when IS_ERR(tiny) is checked:

→ 211  pt = xe_bo_create_pin_map(xe, tile, m->q->vm, XE_PAGE_SIZE,
  212                            ttm_bo_type_kernel,
  213                            XE_BO_FLAG_VRAM_IF_DGFX(tile) |
  214                            XE_BO_FLAG_PINNED);
  215  if (IS_ERR(pt)) {
  216          KUNIT_FAIL(test, "Failed to allocate fake pt: %li\n",
  217                     PTR_ERR(pt));
  218          goto free_big;
  219  }
  220
  221  tiny = xe_bo_create_pin_map(xe, tile, m->q->vm,
→ 222                              2 * SZ_4K,
  223                              ttm_bo_type_kernel,
  224                              XE_BO_FLAG_VRAM_IF_DGFX(tile) |
  225                              XE_BO_FLAG_PINNED);
→ 226  if (IS_ERR(tiny)) {
→ 227          KUNIT_FAIL(test, "Failed to allocate fake pt: %li\n",
→ 228                     PTR_ERR(pt));
  229          goto free_pt;
  230  }

Now, the IS_ERR(tiny) and the corresponding PTR_ERR(pt) do not match.

Returning PTR_ERR(tiny), as the last failed function call, seems logical.

Fixes: dd08ebf6c3 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241121212057.1526634-2-mtodorovac69@gmail.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2024-12-09 11:47:17 -05:00
..
accel
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
accessibility
speakup: use SPKDIR=$(src) to specify the source directory
2024-11-04 17:53:09 +09:00
acpi
Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2024-12-06 13:47:55 -08:00
amba
ARM: 9415/1: amba: Add dev_is_amba() function and export it for modules
2024-11-12 16:41:45 +00:00
android
Merge tag 'char-misc-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2024-11-29 11:58:27 -08:00
ata
Merge tag 'pci-v6.13-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci
2024-11-26 18:05:44 -08:00
atm
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
auxdisplay
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
base
Merge tag 'x86_urgent_for_v6.13_rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2024-12-08 11:38:56 -08:00
bcma
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
block
virtio-blk: don't keep queue frozen during system suspend
2024-12-05 10:00:20 -07:00
bluetooth
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
bus
Merge tag 'char-misc-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2024-11-29 11:58:27 -08:00
cache
…
cdrom
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
cdx
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
char
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
clk
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
clocksource
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
comedi
comedi: Flush partial mappings in error case
2024-11-05 14:01:07 +01:00
connector
…
counter
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
cpufreq
Merge tag 'powerpc-6.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2024-11-23 10:44:31 -08:00
cpuidle
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
crypto
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
cxl
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
dax
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
dca
…
devfreq
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
dio
…
dma
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
dma-buf
Merge tag 'drm-fixes-2024-12-07' of https://gitlab.freedesktop.org/drm/kernel
2024-12-06 11:52:15 -08:00
dpll
dpll: add clock quality level attribute and op
2024-11-03 08:39:07 -08:00
edac
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
eisa
…
extcon
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
firewire
Merge tag 'firewire-updates-6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394
2024-11-25 17:12:54 -08:00
firmware
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
fpga
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
fsi
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
gnss
…
gpio
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
gpu
drm/xe: fix the ERR_PTR() returned on failure to allocate tiny pt
2024-12-09 11:47:17 -05:00
greybus
greybus: Fix a typo
2024-11-05 05:33:46 +01:00
hid
Merge tag 'hid-for-linus-2024120501' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2024-12-05 10:06:47 -08:00
hsi
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
hte
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
hv
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
hwmon
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
hwspinlock
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
hwtracing
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
i2c
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
i3c
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
idle
intel_idle: add Granite Rapids Xeon D support
2024-11-11 15:48:50 +01:00
iio
Merge tag 'mm-hotfixes-stable-2024-12-07-22-39' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-12-08 11:26:13 -08:00
infiniband
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
input
Merge tag 'input-for-v6.13-rc0' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2024-11-25 10:31:39 -08:00
interconnect
Merge branch 'icc-sar2130p' into icc-next
2024-11-05 01:32:05 +02:00
iommu
Merge tag 'for-linus-iommufd' of git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd
2024-12-05 15:02:20 -08:00
ipack
…
irqchip
Merge tag 'irq_urgent_for_v6.13_rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2024-12-08 11:54:04 -08:00
isdn
mISDN: Fix typos
2024-11-09 09:14:12 -08:00
leds
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
macintosh
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
mailbox
Merge tag 'tty-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
2024-11-30 09:03:16 -08:00
mcb
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
md
bcache: revert replacing IS_ERR_OR_NULL with IS_ERR again
2024-12-03 15:06:27 -07:00
media
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
memory
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
memstick
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
message
scsi: message: fusion: Constify struct pci_device_id
2024-11-20 21:38:24 -05:00
mfd
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
misc
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
mmc
mmc: core: Further prevent card detect during shutdown
2024-12-02 15:37:16 +01:00
most
…
mtd
Merge tag 'ubifs-for-linus-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
2024-11-30 10:32:47 -08:00
mux
…
net
Merge tag 'net-6.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-12-05 10:25:06 -08:00
nfc
…
ntb
ntb: idt: Replace deprecated PCI functions
2024-10-30 16:07:38 -05:00
nubus
…
nvdimm
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
nvme
Merge tag 'nvme-6.13-2024-12-05' of git://git.infradead.org/nvme into block-6.13
2024-12-05 10:14:36 -07:00
nvmem
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
of
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
opp
Merge tag 'pm-6.13-rc1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2024-11-27 14:40:33 -08:00
parisc
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
parport
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
pci
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
pcmcia
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
peci
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
perf
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
phy
Merge tag 'driver-core-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
2024-11-29 11:43:29 -08:00
pinctrl
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
platform
Merge tag 'platform-drivers-x86-v6.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
2024-12-04 10:28:30 -08:00
pmdomain
Merge tag 'pmdomain-v6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm
2024-12-06 11:24:00 -08:00
pnp
…
power
Merge tag 'for-v6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply
2024-11-28 09:28:09 -08:00
powercap
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
pps
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
ps3
ps3: Correct some typos in comments
2024-11-15 00:32:29 +11:00
ptp
Merge tag 'net-6.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-12-05 10:25:06 -08:00
pwm
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
rapidio
…
ras
…
regulator
Merge tag 'regulator-fix-v6.13-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
2024-11-28 09:40:53 -08:00
remoteproc
remoteproc: qcom: wcss: Remove double assignment in q6v5_wcss_probe()
2024-11-15 20:36:27 -08:00
reset
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
rpmsg
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
rtc
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
s390
Merge tag 'driver-core-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
2024-11-29 11:43:29 -08:00
sbus
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
scsi
scsi: scsi_debug: Fix hrtimer support for ndelay
2024-12-04 13:22:59 -05:00
sh
Merge tag 'sh-for-v6.13-tag1' of git://git.kernel.org/pub/scm/linux/kernel/git/glaubitz/sh-linux
2024-11-30 14:45:29 -08:00
siox
…
slimbus
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
soc
Merge tag 'net-next-6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2024-11-21 08:28:08 -08:00
soundwire
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
spi
Merge tag 'spi-fix-v6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
2024-12-06 11:36:48 -08:00
spmi
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
ssb
…
staging
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
target
Merge branch '6.13/scsi-queue' into 6.13/scsi-fixes
2024-12-02 12:36:18 -05:00
tc
TC: Fix the wrong format specifier
2024-11-12 15:48:08 +01:00
tee
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
thermal
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
thunderbolt
Merge tag 'usb-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
2024-11-29 11:19:31 -08:00
tty
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
ufs
scsi: ufs: core: Add missing post notify for power mode change
2024-12-04 13:22:59 -05:00
uio
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
usb
module: Convert default symbol namespace to string literal
2024-12-03 08:22:25 -08:00
vdpa
vdpa/mlx5: Fix suboptimal range on iotlb iteration
2024-11-12 18:05:05 -05:00
vfio
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
vhost
mm: page_frag: avoid caller accessing 'page_frag_cache' directly
2024-11-11 10:56:27 -08:00
video
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
virt
Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2024-12-06 13:47:55 -08:00
virtio
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
w1
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
watchdog
Merge tag 'linux-watchdog-6.13-rc1' of git://www.linux-watchdog.org/linux-watchdog
2024-12-05 10:03:43 -08:00
xen
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
zorro
…
Kconfig
…
Makefile
…