Daniel Borkmann b553a6ec57
bpf: Simplify __bpf_arch_text_poke poke type handling ...
Given that we have BPF_MOD_NOP_TO_{CALL,JUMP}, BPF_MOD_{CALL,JUMP}_TO_NOP
and BPF_MOD_{CALL,JUMP}_TO_{CALL,JUMP} poke types and that we also pass in
old_addr as well as new_addr, it's a bit redundant and unnecessarily
complicates __bpf_arch_text_poke() itself since we can derive the same from
the *_addr that were passed in. Hence simplify and use BPF_MOD_{CALL,JUMP}
as types which also allows to clean up call-sites.
In addition to that, __bpf_arch_text_poke() currently verifies that text
matches expected old_insn before we invoke text_poke_bp(). Also add a check
on new_insn and skip rewrite if it already matches. Reason why this is rather
useful is that it avoids making any special casing in prog_array_map_poke_run()
when old and new prog were NULL and has the benefit that also for this case
we perform a check on text whether it really matches our expectations.
Suggested-by: Andrii Nakryiko <andriin@fb.com >
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net >
Signed-off-by: Alexei Starovoitov <ast@kernel.org >
Link: https://lore.kernel.org/bpf/fcb00a2b0b288d6c73de4ef58116a821c8fe8f2f.1574555798.git.daniel@iogearbox.net
2019-11-24 17:12:11 -08:00
2019-11-24 17:12:11 -08:00
2019-11-15 08:44:08 -08:00
2018-10-24 20:55:56 -04:00
2019-09-25 17:51:40 -07:00
2019-10-05 10:24:17 +02:00
2019-11-20 18:11:23 -08:00
2019-09-15 21:37:13 +02:00
2019-11-05 00:48:26 +01:00
2019-08-19 13:03:37 +02:00
2019-09-25 10:22:37 +02:00
2019-11-20 10:46:42 +01:00
2019-09-16 12:54:25 +02:00
2019-09-16 17:25:49 -07:00
2019-11-15 11:02:18 +01:00
2019-11-12 08:13:44 +01:00
2019-11-02 15:29:58 -07:00
2019-04-29 16:48:03 +02:00
2019-04-04 21:04:13 -04:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:26:37 -07:00
2019-04-26 13:51:03 -04:00
2019-11-10 11:56:55 -05:00
2019-07-08 18:55:42 -07:00
2019-07-08 18:55:42 -07:00
2019-07-08 18:55:42 -07:00
2019-11-23 09:56:02 -08:00
2019-06-05 17:37:17 +02:00
2018-10-31 08:54:14 -07:00
2019-01-25 11:22:43 -08:00
2019-06-19 17:09:55 +02:00
2019-07-30 18:34:15 +02:00
2019-05-21 10:50:45 +02:00
2019-06-05 17:36:37 +02:00
2019-11-04 12:22:02 +01:00
2019-06-19 17:09:06 +02:00
2019-05-21 10:50:45 +02:00
2019-07-25 08:36:29 -07:00
2019-05-21 11:52:39 +02:00
2018-05-16 07:23:35 +02:00
2019-09-25 17:51:39 -07:00
2018-05-16 07:23:35 +02:00
2019-09-25 17:42:29 +02:00
2019-10-17 16:44:36 +02:00
2019-06-03 15:49:06 +02:00
2019-11-20 11:48:50 +01:00
2019-10-06 09:11:37 -06:00
2019-08-01 17:43:16 +02:00
2019-10-17 09:08:19 +09:00
2017-12-14 16:00:49 -08:00
2019-05-21 10:50:45 +02:00
2019-07-12 11:05:40 -07:00
2019-05-21 10:50:45 +02:00
2019-08-29 15:10:10 +01:00
2019-08-27 16:19:56 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-07-22 18:05:11 +02:00
2019-03-07 18:32:02 -08:00
2019-09-25 17:51:40 -07:00
2019-09-06 23:58:44 +02:00
2019-09-28 08:14:15 -07:00
2017-11-02 11:10:55 +01:00
2019-08-19 21:54:15 -07:00
2019-05-24 20:16:01 +02:00
2017-09-08 18:26:51 -07:00
2019-09-20 11:19:48 -07:00
2019-05-30 11:26:39 -07:00
2019-10-16 09:20:58 -07:00
2019-06-05 17:37:17 +02:00
2019-09-27 19:37:27 -07:00
2019-08-05 18:39:56 -04:00
2019-08-05 18:39:56 -04:00
2019-05-24 17:27:11 +02:00
2019-09-28 08:14:15 -07:00
2019-05-21 10:50:45 +02:00
2019-06-05 17:37:17 +02:00
2019-09-13 21:15:41 +10:00
2019-10-07 15:47:19 -07:00
2019-08-19 21:54:16 -07:00
2019-07-18 17:08:07 -07:00
2019-07-16 19:23:24 -07:00
2019-05-21 10:50:45 +02:00
2019-07-16 19:23:24 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-03-12 13:27:20 -07:00
2019-09-24 15:54:09 -07:00
2019-05-27 09:36:28 -05:00
2019-05-29 09:31:44 -05:00
2019-10-11 08:39:57 -07:00
2019-07-20 11:27:16 +02:00
2019-05-21 10:50:45 +02:00
2017-11-02 11:10:55 +01:00
2019-07-08 11:01:13 -07:00
2018-12-05 19:31:44 -08:00
2019-11-04 21:19:25 +01:00
2019-10-17 12:47:12 +02:00
2019-06-21 01:54:53 +02:00
2019-09-17 12:35:15 -07:00
2019-01-04 13:13:47 -08:00
2019-10-14 21:43:54 +02:00
2017-12-17 13:57:15 +01:00
2019-05-30 11:26:37 -07:00
2019-05-21 11:52:39 +02:00
2019-08-01 14:30:22 -07:00
2019-07-18 11:51:00 -07:00
2019-05-30 11:26:37 -07:00
2019-07-18 17:08:07 -07:00
2018-04-02 20:15:59 +02:00
2018-04-02 20:15:30 +02:00
2019-05-21 10:50:45 +02:00
2019-06-23 14:26:26 +02:00
2019-07-08 19:36:47 -07:00
2019-05-21 10:50:45 +02:00
2019-07-08 19:36:47 -07:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:17 +02:00
2019-04-19 09:46:05 -07:00
2019-08-01 20:51:20 +02:00
2019-04-16 16:55:15 +02:00
2019-09-13 21:15:40 +10:00
b553a6ec57