Ido Schimmel
ad4a3ca6a8
ipv4: ip_tunnel: Fix suspicious RCU usage warning in ip_tunnel_init_flow()
...
There are code paths from which the function is called without holding
the RCU read lock, resulting in a suspicious RCU usage warning [1].
Fix by using l3mdev_master_upper_ifindex_by_index() which will acquire
the RCU read lock before calling
l3mdev_master_upper_ifindex_by_index_rcu().
[1]
WARNING: suspicious RCU usage
6.12.0-rc3-custom-gac8f72681cf2 #141 Not tainted
-----------------------------
net/core/dev.c:876 RCU-list traversed in non-reader section!!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by ip/361:
#0 : ffffffff86fc7cb0 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x377/0xf60
stack backtrace:
CPU: 3 UID: 0 PID: 361 Comm: ip Not tainted 6.12.0-rc3-custom-gac8f72681cf2 #141
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
<TASK>
dump_stack_lvl+0xba/0x110
lockdep_rcu_suspicious.cold+0x4f/0xd6
dev_get_by_index_rcu+0x1d3/0x210
l3mdev_master_upper_ifindex_by_index_rcu+0x2b/0xf0
ip_tunnel_bind_dev+0x72f/0xa00
ip_tunnel_newlink+0x368/0x7a0
ipgre_newlink+0x14c/0x170
__rtnl_newlink+0x1173/0x19c0
rtnl_newlink+0x6c/0xa0
rtnetlink_rcv_msg+0x3cc/0xf60
netlink_rcv_skb+0x171/0x450
netlink_unicast+0x539/0x7f0
netlink_sendmsg+0x8c1/0xd80
____sys_sendmsg+0x8f9/0xc20
___sys_sendmsg+0x197/0x1e0
__sys_sendmsg+0x122/0x1f0
do_syscall_64+0xbb/0x1d0
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Fixes: db53cd3d88 ("net: Handle l3mdev in ip_tunnel_init_flow")
Signed-off-by: Ido Schimmel <idosch@nvidia.com >
Reviewed-by: David Ahern <dsahern@kernel.org >
Link: https://patch.msgid.link/20241022063822.462057-1-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2024-10-29 11:12:25 -07:00
..
2024-05-01 18:07:37 +01:00
2024-10-23 10:20:29 -04:00
2024-08-26 09:37:23 -07:00
2024-08-26 09:37:22 -07:00
2024-09-09 13:15:37 -07:00
2024-09-05 20:37:20 -07:00
2024-10-02 17:23:23 -04:00
2024-09-24 09:58:16 +02:00
2024-08-26 09:37:23 -07:00
2024-09-11 20:44:31 -07:00
2023-06-15 22:33:26 -07:00
2024-08-26 09:37:23 -07:00
2024-01-02 12:41:16 +00:00
2020-02-28 14:51:30 +01:00
2024-02-02 10:57:55 -08:00
2024-08-26 09:37:23 -07:00
2023-12-24 15:22:50 +00:00
2024-06-25 11:10:18 +02:00
2024-08-15 17:18:52 -07:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2024-05-14 10:53:19 -07:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2024-08-26 09:37:22 -07:00
2024-08-26 09:37:22 -07:00
2024-02-06 13:17:54 +01:00
2024-08-27 13:11:37 -07:00
2021-03-26 17:43:55 +01:00
2024-08-29 11:49:10 -07:00
2024-10-02 17:23:23 -04:00
2022-11-16 11:31:47 +02:00
2024-10-08 21:24:00 +02:00
2024-03-06 21:01:26 +01:00
2023-01-27 11:19:46 +00:00
2024-10-02 17:23:23 -04:00
2020-03-27 19:40:38 -07:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2023-07-14 20:39:29 -07:00
2022-07-24 18:39:17 -06:00
2023-07-27 17:17:32 -07:00
2022-07-22 12:53:22 +01:00
2023-01-20 09:33:22 +00:00
2024-06-05 10:24:57 +01:00
2024-08-26 09:37:23 -07:00
2023-08-14 08:01:06 +01:00
2023-10-24 13:08:14 -07:00
2024-08-16 09:59:32 +01:00
2024-05-08 10:35:09 +01:00
2019-12-16 16:09:44 -08:00
2024-08-26 09:37:23 -07:00
2024-08-20 15:22:17 -07:00
2024-05-29 17:34:49 -07:00
2024-08-26 09:37:23 -07:00
2024-03-05 19:21:17 -08:00
2024-08-26 09:37:23 -07:00
2022-07-22 12:53:22 +01:00
2024-04-01 21:27:08 -07:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2019-12-24 22:37:30 -08:00
2024-01-03 16:42:48 -08:00
2022-07-28 22:21:54 -07:00
2024-07-15 09:14:39 -07:00
2024-06-12 17:56:00 -07:00
2023-11-02 09:31:02 +01:00
2023-04-12 16:40:39 -07:00
2022-12-01 15:09:10 +01:00
2023-08-08 15:58:23 -07:00
2022-07-22 12:53:22 +01:00
2021-10-18 12:54:41 +01:00
2024-10-15 17:52:58 -07:00
2022-10-31 10:43:04 +00:00
2024-04-01 10:49:28 +01:00
2024-05-14 10:49:50 -07:00
2023-06-10 00:11:41 -07:00
2024-05-07 01:35:55 +02:00
2022-07-22 12:53:22 +01:00
2023-07-28 14:07:59 -07:00
2024-04-30 18:46:52 -07:00
2024-08-26 09:37:23 -07:00
2021-06-28 14:29:45 -07:00
2024-05-08 10:35:09 +01:00
2024-10-25 10:44:41 +01:00
2023-11-20 11:43:03 +01:00
2024-02-26 18:40:34 -08:00
2022-07-22 12:53:22 +01:00
2024-08-05 16:27:26 -07:00
2024-05-13 18:19:09 -06:00
2024-06-25 11:37:45 +02:00
2022-02-07 20:12:45 -08:00
2021-10-15 11:33:08 +01:00
2024-05-23 14:14:23 -07:00
2024-08-05 16:22:45 -07:00
2024-08-05 16:22:45 -07:00
2024-08-28 17:08:16 -07:00
2024-02-28 11:19:41 +00:00
2021-11-16 13:16:54 +00:00
2024-04-29 13:32:01 +01:00
2024-07-14 07:34:16 -07:00
2024-04-01 10:49:28 +01:00
2024-09-04 16:40:33 -07:00
2024-10-29 11:12:25 -07:00
2023-04-22 01:39:41 +02:00
2024-08-31 17:44:51 +01:00
2022-09-29 07:18:00 +02:00
2022-07-22 12:53:22 +01:00
2022-10-31 20:14:27 -07:00
2024-08-05 16:27:26 -07:00
2024-08-26 09:37:22 -07:00
2024-09-03 11:49:27 +02:00
2024-08-19 18:36:12 -07:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2024-08-27 10:28:49 +02:00
2023-08-04 15:33:17 -07:00
2023-08-04 15:33:17 -07:00
2024-07-15 08:51:01 -07:00
2023-07-20 10:46:28 +02:00
2021-10-13 09:40:46 -07:00
2024-08-26 09:37:23 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2024-07-15 08:51:19 -07:00
2021-11-07 19:25:29 +00:00
2023-08-18 16:05:26 +02:00
2024-10-02 17:23:23 -04:00
2024-10-02 17:23:23 -04:00
2024-04-25 08:20:54 -07:00
2024-10-10 15:39:35 +02:00
2021-10-29 13:23:51 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2022-07-22 12:53:22 +01:00
2020-05-29 21:20:20 -07:00
2024-09-11 15:57:50 -07:00
2022-11-18 12:14:55 +00:00
2022-07-22 12:53:22 +01:00
2024-08-12 17:23:57 -07:00
2024-07-24 20:59:29 +02:00
2022-05-11 12:43:10 +01:00
2024-08-03 22:38:44 +01:00
2021-12-10 06:38:26 -08:00
2024-06-01 15:11:52 -07:00
2024-09-12 21:00:26 -07:00
2022-07-22 12:53:22 +01:00
2023-11-20 10:15:16 -08:00
2024-08-26 09:37:22 -07:00
2024-08-26 09:37:23 -07:00
2024-09-11 20:44:31 -07:00
2022-07-22 12:53:22 +01:00
2024-08-12 17:50:34 -07:00
2024-08-30 22:30:55 +02:00
2023-07-14 20:39:29 -07:00
2023-08-04 15:33:50 -07:00
2024-04-01 10:49:28 +01:00
2023-07-14 20:39:30 -07:00
2023-06-02 09:55:22 +01:00
2024-08-26 09:37:23 -07:00
2024-02-02 10:57:55 -08:00
2022-07-22 12:53:22 +01:00
2024-04-30 18:46:52 -07:00
2024-03-07 21:12:43 -08:00
2024-07-11 18:11:31 -07:00
2022-07-22 12:53:22 +01:00
2023-04-06 12:01:20 -07:00
2023-03-17 08:56:37 +00:00
2024-08-26 09:37:23 -07:00
2024-08-26 09:37:23 -07:00
2024-06-06 15:18:04 +02:00
2022-08-01 11:59:23 -07:00
2024-08-31 17:44:51 +01:00
2023-06-19 11:32:58 -07:00
2024-04-01 11:28:32 +01:00
2023-07-14 20:39:30 -07:00
2024-08-07 10:24:46 +01:00
2024-10-10 15:39:35 +02:00
2024-10-08 15:38:56 -07:00
2024-05-10 18:52:45 -07:00
2022-07-22 12:53:22 +01:00
2024-05-30 18:29:38 -07:00
2024-06-24 16:41:23 -07:00
2024-05-30 18:29:38 -07:00
2021-04-28 14:06:45 -07:00
2024-04-30 13:24:48 +02:00
2024-08-02 17:16:59 -07:00
2024-10-18 16:27:14 -07:00
2023-10-04 11:49:20 -07:00
2022-07-22 12:53:22 +01:00
2022-07-18 11:24:10 +01:00
2024-02-16 09:36:37 +00:00
2024-02-14 10:49:37 +01:00
2024-06-12 06:39:04 +01:00
2023-12-04 14:45:26 -08:00
2024-09-23 11:43:09 +01:00
2024-07-08 14:07:31 -07:00
2024-05-09 20:25:55 -07:00
2023-07-28 14:07:59 -07:00
2024-04-25 12:41:37 -07:00
2023-08-01 15:06:27 -07:00
2022-12-12 15:04:39 -08:00
2022-07-22 12:53:22 +01:00
2024-04-01 10:49:28 +01:00
2024-08-26 09:37:23 -07:00
2023-09-14 16:16:36 +02:00
2023-11-16 22:33:31 +00:00
2024-08-26 09:37:23 -07:00
2022-07-22 12:53:22 +01:00
2024-05-08 08:51:20 +02:00
2024-07-02 15:26:57 +02:00
2023-12-14 16:38:59 +01:00
2024-09-23 07:02:07 +02:00
2024-05-08 08:51:20 +02:00