Files
linux/include/linux
Hans de Goede d143908f80 platform/x86: apple-gmux: Add apple_gmux_detect() helper
Add a new (static inline) apple_gmux_detect() helper to apple-gmux.h
which can be used for gmux detection instead of apple_gmux_present().

The latter is not really reliable since an ACPI device with a HID
of APP000B is present on some devices without a gmux at all, as well
as on devices with a newer (unsupported) MMIO based gmux model.

This causes apple_gmux_present() to return false-positives on
a number of different Apple laptop models.

This new helper uses the same probing as the actual apple-gmux
driver, so that it does not return false positives.

To avoid code duplication the gmux_probe() function of the actual
driver is also moved over to using the new apple_gmux_detect() helper.

This avoids false positives (vs _HID + IO region detection) on:

MacBookPro5,4
https://pastebin.com/8Xjq7RhS

MacBookPro8,1
https://linux-hardware.org/?probe=e513cfbadb&log=dmesg

MacBookPro9,2
https://bugzilla.kernel.org/attachment.cgi?id=278961

MacBookPro10,2
https://lkml.org/lkml/2014/9/22/657

MacBookPro11,2
https://forums.fedora-fr.org/viewtopic.php?id=70142

MacBookPro11,4
https://raw.githubusercontent.com/im-0/investigate-card-reader-suspend-problem-on-mbp11.4/master/test-16/dmesg

Fixes: 21245df307 ("ACPI: video: Add Apple GMUX brightness control detection")
Link: https://lore.kernel.org/platform-driver-x86/20230123113750.462144-1-hdegoede@redhat.com/
Reported-by: Emmanouil Kouroupakis <kartebi@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230124105754.62167-3-hdegoede@redhat.com
2023-01-24 13:41:57 +01:00
..
2022-10-27 13:23:43 +02:00
2022-11-04 12:59:25 +02:00
2022-12-11 21:25:58 +01:00
2022-05-22 20:44:29 +01:00
2022-07-05 20:25:39 +02:00
2023-01-04 14:43:27 -07:00
2022-09-26 12:19:12 -07:00
2022-12-07 09:43:12 -07:00
2022-09-26 19:46:29 -07:00
2022-09-26 10:13:13 -07:00
2022-09-26 10:13:13 -07:00
2022-09-15 09:32:06 -07:00
2022-12-02 18:12:40 +08:00
2022-11-18 09:14:10 +01:00
2022-12-11 18:12:17 -08:00
2022-06-28 10:37:25 -03:00
2022-10-20 10:13:30 +02:00
2022-07-01 14:53:01 +02:00
2022-10-24 12:30:26 +03:00
2022-10-03 14:02:45 -07:00
2022-06-09 21:53:09 -07:00
2022-06-09 21:53:12 -07:00
2022-11-11 18:18:05 -08:00
2022-09-01 18:04:43 +02:00
2022-11-29 09:09:17 +11:00
2022-06-27 06:29:12 -06:00
2022-09-08 12:59:00 -06:00
2022-09-26 13:31:20 +02:00
2022-11-15 00:42:02 -08:00
2022-12-11 19:30:20 -08:00
2022-09-01 18:08:44 +02:00
2022-07-17 17:31:38 -07:00
2022-10-03 14:03:19 -07:00
2022-05-02 14:06:20 -06:00
2022-05-03 16:09:03 -04:00
2022-11-09 19:28:49 -08:00
2022-06-19 10:38:26 +01:00
2022-07-27 14:04:52 +02:00
2022-04-28 23:16:14 -07:00
2022-08-02 12:34:04 -04:00
2022-09-01 17:39:49 -04:00
2022-08-22 14:26:30 +01:00
2022-08-09 14:11:34 -04:00
2022-07-29 20:16:58 -04:00
2022-10-16 17:58:54 -05:00
2022-10-03 17:34:32 -07:00
2022-09-26 19:46:27 -07:00
2023-01-04 14:44:13 -07:00
2022-10-04 20:52:38 +02:00
2022-10-20 10:13:30 +02:00
2022-12-20 03:13:45 +01:00
2022-10-23 18:06:54 -04:00
2022-10-21 10:11:00 -07:00
2022-05-22 21:03:01 +01:00
2022-06-27 14:41:31 +02:00
2022-12-09 19:47:41 -08:00
2022-11-29 15:00:06 -08:00
2022-05-08 01:33:08 -07:00
2022-09-07 12:42:25 +01:00
2022-12-11 18:12:19 -08:00
2022-09-29 15:20:29 +02:00
2022-12-10 13:36:05 -05:00
2022-09-22 16:12:34 +02:00
2022-09-22 16:12:34 +02:00
2022-08-31 13:37:32 +02:00
2022-08-28 16:52:28 +01:00
2022-10-07 09:32:40 -04:00
2022-06-13 09:54:52 -07:00
2022-09-26 19:46:18 -07:00
2022-07-10 21:17:30 -04:00
2022-10-24 12:12:32 -07:00