Kuninori Morimoto
4662c59688
ASoC: soc-pcm: add soc_pcm_hw_clean() and call it from soc_pcm_hw_params/free()
...
soc_pcm_hw_params() does rollback when failed (A),
but, it is almost same as soc_pcm_hw_free().
static int soc_pcm_hw_params(xxx)
{
...
if (ret < 0)
goto xxx_err;
...
return ret;
^ component_err:
| ...
| interface_err:
(A) ...
| codec_err:
| ...
v return ret;
}
The difference is
soc_pcm_hw_free() is for all dai/component/substream,
rollback is for succeeded part only.
This kind of duplicated code can be a hotbed of bugs,
thus, we want to share soc_pcm_hw_free() and rollback.
Now, soc_pcm_hw_params/free() are handling
1) snd_soc_link_hw_params/free()
2) snd_soc_pcm_component_hw_params/free()
3) snd_soc_dai_hw_params/free()
Now, 1) to 3) are handled.
This patch adds new soc_pcm_hw_clean() and call it from
soc_pcm_hw_params() as rollback, and from soc_pcm_hw_free() as
normal close handler.
Other difference is that soc_pcm_hw_free() handles digital mute
if it was last user. Rollback also handles it by this patch.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com >
Link: https://lore.kernel.org/r/87h7rhgqab.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org >
2020-10-26 16:44:18 +00:00
..
2018-07-02 10:56:09 +01:00
2020-09-17 15:53:16 +01:00
2020-01-03 09:24:08 +01:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2008-07-14 09:01:02 +02:00
2019-05-30 11:25:18 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-07 11:52:18 +02:00
2020-07-20 10:10:47 +02:00
2020-03-23 18:09:19 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-02-08 13:00:28 +00:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:35 -07:00
2020-06-12 14:18:02 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-07 11:59:59 +02:00
2017-11-02 11:10:55 +01:00
2020-10-12 13:00:22 +02:00
2019-02-08 16:58:59 +01:00
2019-05-24 17:27:10 +02:00
2018-07-17 22:25:48 +02:00
2020-08-27 14:22:17 +01:00
2020-01-13 13:40:41 +01:00
2019-01-14 19:52:23 +01:00
2020-09-21 23:57:24 +01:00
2020-08-05 12:27:47 +02:00
2020-09-22 12:48:03 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-01-03 09:24:18 +01:00
2020-01-05 16:14:26 +01:00
2019-10-23 06:31:37 +02:00
2020-05-07 22:30:36 +02:00
2019-05-30 11:26:35 -07:00
2017-11-02 11:10:55 +01:00
2019-06-26 12:27:50 +01:00
2012-01-30 21:50:55 +00:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-15 18:01:52 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-19 20:49:25 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:43:07 +02:00
2019-05-24 17:36:45 +02:00
2020-03-30 13:43:00 +02:00
2019-05-30 11:26:35 -07:00
2019-10-08 13:47:20 +01:00
2020-05-07 22:29:14 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-03-23 18:17:24 +00:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-01-03 09:24:19 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2018-08-02 10:56:59 +01:00
2020-07-16 23:24:12 +01:00
2018-07-02 10:52:47 +01:00
2017-11-13 15:45:57 +01:00
2020-10-06 15:12:20 +01:00
2020-09-23 18:13:13 +01:00
2020-05-30 02:11:42 +01:00
2020-10-26 16:44:16 +00:00
2020-10-26 16:44:17 +00:00
2020-06-25 19:21:01 +01:00
2020-03-12 13:30:38 +00:00
2020-10-26 16:44:15 +00:00
2019-02-04 11:59:30 +01:00
2020-10-26 16:44:18 +00:00
2020-09-21 17:28:10 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:41 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:32:52 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-06-05 17:37:07 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2020-01-03 09:24:20 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-10-25 11:06:57 +01:00
2019-05-30 11:26:32 -07:00
2020-06-15 20:58:33 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00